From: Rob Clark <robdclark@gmail.com>
To: dri-devel@lists.freedesktop.org
Cc: linux-arm-msm@vger.kernel.org, Rob Clark <robdclark@gmail.com>
Subject: [PATCH 6/6] drm/msm: EBUSY status handling in msm_gem_fault()
Date: Sun, 20 Oct 2013 12:10:59 -0400 [thread overview]
Message-ID: <1382285459-21490-7-git-send-email-robdclark@gmail.com> (raw)
In-Reply-To: <1382285459-21490-1-git-send-email-robdclark@gmail.com>
Subsequent threads returning EBUSY from vm_insert_pfn() was not
handled correctly. As a result concurrent access from new threads
to mmapped data caused SIGBUS.
See e79e0fe3
Signed-off-by: Rob Clark <robdclark@gmail.com>
---
drivers/gpu/drm/msm/msm_gem.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c
index 291939d..e587d25 100644
--- a/drivers/gpu/drm/msm/msm_gem.c
+++ b/drivers/gpu/drm/msm/msm_gem.c
@@ -178,6 +178,11 @@ out:
case 0:
case -ERESTARTSYS:
case -EINTR:
+ case -EBUSY:
+ /*
+ * EBUSY is ok: this just means that another thread
+ * already did the job.
+ */
return VM_FAULT_NOPAGE;
case -ENOMEM:
return VM_FAULT_OOM;
--
1.8.3.1
next prev parent reply other threads:[~2013-10-20 16:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-20 16:10 [PATCH 0/6] drm/msm: queued up patches for 3.13 Rob Clark
2013-10-20 16:10 ` [PATCH 1/6] drm/msm: prime support Rob Clark
2013-10-20 16:10 ` [PATCH 2/6] drm/msm: support render nodes Rob Clark
2013-10-20 16:10 ` [PATCH 3/6] drm/msm: resync generated headers Rob Clark
2013-10-20 16:10 ` [PATCH 4/6] drm/msm: add plane support Rob Clark
2013-10-20 16:10 ` [PATCH 5/6] drm/msm: rework inactive-work Rob Clark
2013-10-20 16:10 ` Rob Clark [this message]
2013-10-22 10:27 ` [PATCH 0/6] drm/msm: queued up patches for 3.13 David Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1382285459-21490-7-git-send-email-robdclark@gmail.com \
--to=robdclark@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).