From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Ivan T. Ivanov" Subject: Re: [PATCH v4 12/15] usb: phy: msm: Add support for secondary PHY control Date: Wed, 11 Dec 2013 10:23:44 +0200 Message-ID: <1386750224.16289.4.camel@iivanov-dev.int.mm-sol.com> References: <1384267910-32066-1-git-send-email-iivanov@mm-sol.com> <1384267910-32066-13-git-send-email-iivanov@mm-sol.com> <20131115164212.GI24831@e106331-lin.cambridge.arm.com> <1384779462.13631.16.camel@iivanov-dev.int.mm-sol.com> <20131205104252.GK29200@e106331-lin.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from ns.mm-sol.com ([37.157.136.199]:59421 "EHLO extserv.mm-sol.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750743Ab3LKIZO (ORCPT ); Wed, 11 Dec 2013 03:25:14 -0500 In-Reply-To: <20131205104252.GK29200@e106331-lin.cambridge.arm.com> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Mark Rutland Cc: "balbi@ti.com" , "gregkh@linuxfoundation.org" , "rob.herring@calxeda.com" , Pawel Moll , "swarren@wwwdotorg.org" , "ijc+devicetree@hellion.org.uk" , "davidb@codeaurora.org" , "linux-usb@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Manu Gautam , "devicetree@vger.kernel.org" Hi, On Thu, 2013-12-05 at 10:42 +0000, Mark Rutland wrote: > On Mon, Nov 18, 2013 at 12:57:42PM +0000, Ivan T. Ivanov wrote: > > > > Hi Mark, > > > > On Fri, 2013-11-15 at 16:42 +0000, Mark Rutland wrote: > > > On Tue, Nov 12, 2013 at 02:51:47PM +0000, Ivan T. Ivanov wrote: > > > > From: "Ivan T. Ivanov" > > > > > > > > Allow support to use 2nd HSPHY with USB2 Core. > > > > Some platforms may have configuration to allow USB controller > > > > work with any of the two HSPHYs present. By default driver > > > > configures USB core to use primary HSPHY. Add support to allow > > > > user select 2nd HSPHY using DT parameter. > > > > > > > > Signed-off-by: Ivan T. Ivanov > > > > Cc: Manu Gautam > > > > Cc: devicetree@vger.kernel.org > > > > --- > > > > .../devicetree/bindings/usb/msm-hsusb.txt | 6 +++++ > > > > drivers/usb/phy/phy-msm-usb.c | 24 ++++++++++++++++++-- > > > > include/linux/usb/msm_hsusb.h | 1 + > > > > include/linux/usb/msm_hsusb_hw.h | 1 + > > > > 4 files changed, 30 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/Documentation/devicetree/bindings/usb/msm-hsusb.txt b/Documentation/devicetree/bindings/usb/msm-hsusb.txt > > > > index 3f21204..d105ba9 100644 > > > > --- a/Documentation/devicetree/bindings/usb/msm-hsusb.txt > > > > +++ b/Documentation/devicetree/bindings/usb/msm-hsusb.txt > > > > @@ -72,6 +72,12 @@ Optional properties: > > > > - qcom,phy-init-sequence: PHY configuration sequence. val, reg pairs > > > > terminate with -1 > > > > > > > > +- qcom,phy-num: Select number of pyco-phy to use, can be one of > > > > + 0 - PHY one, default > > > > + 1 - Second PHY > > > > + Some platforms may have configuration to allow USB > > > > + controller work with any of the two HSPHYs present. > > > > + > > > > > > Only one can be used at a time? > > > > Yes only one of them. Selected at driver init time. > > Ok. For a given platform, is it likely that both are wired up and > _possibly_ usable? My guess is that this is possible :-) Regards. Ivan > > Thanks > Mark.