From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 290741EC4CF for ; Wed, 11 Dec 2024 21:57:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733954257; cv=none; b=PYUeSlc22ByE2YrhaWfkjxjvKeZKDTDBUgDJr0ogwp4MuVlcTADXbJBGW7/2EexAJ8Mc712S34E2Akia/qB6IrQwL1lfgX+AwBzx9l8VY9zvZJ2gVSY/XHfO3AJJJ8NaWg6hgh/ntmc9A3g/K63vrf7aUourzh6GOOwoxqvHd4g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733954257; c=relaxed/simple; bh=NoocTxI69ryT8lgZX5nyYh4EyrV+I82c3ZNBMnlnPK0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BDFJwel6IwXQ69flgU7ANwZ3nbhVNq4GgBVHyQtJLZ1iMAVzcdtd7OkZOG473mCXXB8k6FIcKDP2Z9gT0UvQ1gU9evfofSK0N9oynQ0ylTBlMGJ1a8DaoGKF515ThyYESPsSjLBRNgwmTNlQq+x7DO06AQeE7p/MN2JYcQNHE2k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=yVEY8Hdc; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yVEY8Hdc" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-434a7ee3d60so6824685e9.1 for ; Wed, 11 Dec 2024 13:57:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1733954253; x=1734559053; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=OiMsT5ZPIfov52Mx3AVw33KMoPobt05c+bdtT6TpK0A=; b=yVEY8HdcZOYUsY8g7PVKHe0lDXk3YDPcwh9j/FVqXDQeuG5JXI9H44c7FvUgkzmnXy Vi0zZNrR5+QCTiI48idYjYWHFk/+VXfP20fYQ3I/jDnJJhLjJ0TBxIHl7fuSd+7EMkas EZ1r+tnMHEiWKvbWve0zH19pvHXHVMV8Wg7FOBgM/POhelOnRZ4GV0EjBjDgAConf+ql +Nsa+qUvY03LKOy+8ZSWMZp+hs8UMbG+PQrvQ4dkVc9R5XhCJ7l2SuQ1tjWugIzkf9rA Zh+nhhf5We/++/Qiy8af9tEdSuZBsAPq3YIxQiKKIkPxJ9J/l5dZb8RMiD/QxvDTkMFf XokQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733954253; x=1734559053; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OiMsT5ZPIfov52Mx3AVw33KMoPobt05c+bdtT6TpK0A=; b=s3A7WhxHud3NDW0vpoDH65Hma85Qrfhp6Upjz/JmFjxEeuz8Ym4ioaDeyo9bpXTS02 uDSG8cNZXcoxArGqhBv4ybl24tVpMiY4wQw2n+/kKtwSXxmGTqhbZB7xnd1+ihwhvwBt nOkcnE0hlJVs3c43+nhkRsuIEfkGASrzKiMndFm9x03G/SDgxFkvAj7VDJB4C//77h7I kv0LFMDS5E/UMhrsJ+MqfpNe2qR3tYDBmCG+fiZsXfwidW1Cbbwf87IZbCFXG/IXbs9M KxkiKn1qEio3z+YTb2MKdMBJjy7YtHt3EOGfEuJOD1+z11YKlwncW+LDcBLxDe5acAR4 UQlQ== X-Forwarded-Encrypted: i=1; AJvYcCUQPpoqnPuRVRM3iMfamya7T+MJW1z5+mu35uONS5fdpxmU0CbeNupuY8TsLrNkRzp0RbicRRHdLYrs8k/v@vger.kernel.org X-Gm-Message-State: AOJu0YzcYWukT5L9Rz3frH46RurqYjqtBx988UczmsRDRsnc0KPLYPyg HUzFWYiwuQwaXMAoJcUp/F2rUqGg1C9S9WlXKthm74gUBS4J0Zh61vIRKuAo+/4= X-Gm-Gg: ASbGncszzF8qpvjEVmeOI9GNl7UtGqim9PIlEp6IVQl4J9B4aIDDWl9rCen2KzNLT2r VxJB2EKo3fpsZ/UNpyTLNywYZt+YDul4d9VH2yMA2KmImOG40sh9flsvB/8yzhzAutCS6KBXEU/ 3GKwkoa3PGdBCJamQhohrmZamdbbleGAucU1BgN+k9FnY2D6CtmZz8kDCikFO4AIqq4N5CiQ5mF m59nMZOdIxGC2CThDvxT8LaJOmlUIEh1Zm+zQThcH9Eak7PoMnua9OBAFJy3tUK59s= X-Google-Smtp-Source: AGHT+IFFp+r/vdKuglbxh8YThlHAVZQ6EWL6sTWl2g1jqrOQgWrFNPXYNjeb7DaZjcHoAt35YUmQpQ== X-Received: by 2002:a05:6000:1543:b0:386:2e8c:e26d with SMTP id ffacd0b85a97d-3878840808emr704391f8f.0.1733954253597; Wed, 11 Dec 2024 13:57:33 -0800 (PST) Received: from [192.168.0.27] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4361d1cd906sm33498175e9.12.2024.12.11.13.57.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Dec 2024 13:57:33 -0800 (PST) Message-ID: <138cc2e5-6b31-49d9-b70e-400a3f3c3bfa@linaro.org> Date: Wed, 11 Dec 2024 21:57:31 +0000 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 15/16] media: qcom: camss: Add CSID 780 support To: Depeng Shao , rfoss@kernel.org, todor.too@gmail.com, mchehab@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, vladimir.zapolskiy@linaro.org Cc: quic_eberman@quicinc.com, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@quicinc.com, Yongsheng Li References: <20241211140738.3835588-1-quic_depengs@quicinc.com> <20241211140738.3835588-16-quic_depengs@quicinc.com> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <20241211140738.3835588-16-quic_depengs@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/12/2024 14:07, Depeng Shao wrote: > +static int csid_configure_testgen_pattern(struct csid_device *csid, s32 val) > +{ > + return 0; > +} Could we avoid this empty callback by checking csid->ctrl in csid.c ? If so, please make that change. If not, it's fine. For either case. Reviewed-by: Bryan O'Donoghue