From: Josh Cartwright <joshc@codeaurora.org>
To: Andrew Morton <akpm@linux-foundation.org>,
Alessandro Zummo <a.zummo@towertech.it>
Cc: linux-arm-msm@vger.kernel.org, rtc-linux@googlegroups.com,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 5/6] rtc: pm8xxx: move device_init_wakeup() before rtc_register
Date: Mon, 10 Mar 2014 13:44:48 -0500 [thread overview]
Message-ID: <1394477089-3996-6-git-send-email-joshc@codeaurora.org> (raw)
In-Reply-To: <1394477089-3996-1-git-send-email-joshc@codeaurora.org>
Setup wakeup capability before rtc_register to ensure the rtc class core
properly sets up our 'wakealarm' sysfs attribute.
Signed-off-by: Josh Cartwright <joshc@codeaurora.org>
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
---
drivers/rtc/rtc-pm8xxx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/rtc/rtc-pm8xxx.c b/drivers/rtc/rtc-pm8xxx.c
index 6e3cd34..197699f 100644
--- a/drivers/rtc/rtc-pm8xxx.c
+++ b/drivers/rtc/rtc-pm8xxx.c
@@ -429,6 +429,8 @@ static int pm8xxx_rtc_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, rtc_dd);
+ device_init_wakeup(&pdev->dev, 1);
+
/* Register the RTC device */
rtc_dd->rtc = devm_rtc_device_register(&pdev->dev, "pm8xxx_rtc",
&pm8xxx_rtc_ops, THIS_MODULE);
@@ -448,8 +450,6 @@ static int pm8xxx_rtc_probe(struct platform_device *pdev)
return rc;
}
- device_init_wakeup(&pdev->dev, 1);
-
dev_dbg(&pdev->dev, "Probe success !!\n");
return 0;
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2014-03-10 18:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-10 18:44 [PATCH v2 0/6] rtc: make the pm8xxx RTC driver usable Josh Cartwright
2014-03-10 18:44 ` [PATCH v2 1/6] rtc: pm8xxx: fixup checkpatch/style issues Josh Cartwright
2014-03-10 18:44 ` [PATCH v2 2/6] rtc: pm8xxx: use regmap API for register accesses Josh Cartwright
2014-03-10 20:47 ` Andrew Morton
2014-03-10 21:35 ` Josh Cartwright
2014-03-10 21:43 ` Andrew Morton
2014-03-10 23:32 ` Mark Brown
2014-03-10 18:44 ` [PATCH v2 3/6] rtc: pm8xxx: use devm_request_any_context_irq Josh Cartwright
2014-03-10 18:44 ` [PATCH v2 4/6] rtc: pm8xxx: add support for devicetree Josh Cartwright
2014-03-10 20:47 ` Andrew Morton
2014-03-10 21:56 ` Josh Cartwright
2014-03-10 18:44 ` Josh Cartwright [this message]
2014-03-10 18:44 ` [PATCH v2 6/6] documentation: bindings: document PMIC8921/8058 RTC Josh Cartwright
2014-03-10 21:22 ` Rob Herring
[not found] ` <CAL_JsqJe7M6i0RKWVPHbvyHbHscMtZmW-xbJuaJTePqYRKWrUg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-03-10 22:11 ` Josh Cartwright
2014-03-10 22:18 ` Andrew Morton
[not found] ` <20140310151807.7274d58d3c50b884585244b6-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2014-03-12 17:17 ` [PATCH v3 6/6] mfd: devicetree: bindings: add pm8xxx RTC description Josh Cartwright
2014-03-21 8:12 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394477089-3996-6-git-send-email-joshc@codeaurora.org \
--to=joshc@codeaurora.org \
--cc=a.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).