From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Ivan T. Ivanov" Subject: Re: [PATCH v6 01/19] usb: phy: msm: Make driver selectable on ARCH_QCOM Date: Tue, 22 Apr 2014 18:16:35 +0300 Message-ID: <1398179795.4724.170.camel@iivanov-dev> References: <1398158438-21579-1-git-send-email-iivanov@mm-sol.com> <1398158438-21579-2-git-send-email-iivanov@mm-sol.com> <20140422145701.GI5524@saruman.home> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from ns.mm-sol.com ([37.157.136.199]:53914 "EHLO extserv.mm-sol.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932681AbaDVPRc (ORCPT ); Tue, 22 Apr 2014 11:17:32 -0400 In-Reply-To: <20140422145701.GI5524@saruman.home> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: balbi@ti.com Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Hi, On Tue, 2014-04-22 at 09:57 -0500, Felipe Balbi wrote: > On Tue, Apr 22, 2014 at 12:20:20PM +0300, Ivan T. Ivanov wrote: > > From: "Ivan T. Ivanov" > > > > Controller could be found on APQ and MSM platforms, > > make configuration description more generic. > > > > Signed-off-by: Ivan T. Ivanov > > --- > > drivers/usb/phy/Kconfig | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig > > index 416e0c8..0c668a3 100644 > > --- a/drivers/usb/phy/Kconfig > > +++ b/drivers/usb/phy/Kconfig > > @@ -171,11 +171,11 @@ config USB_ISP1301 > > module will be called phy-isp1301. > > > > config USB_MSM_OTG > > - tristate "OTG support for Qualcomm on-chip USB controller" > > - depends on (USB || USB_GADGET) && ARCH_MSM > > + tristate "Qualcomm on-chip USB OTG controller support" > > + depends on (USB || USB_GADGET) && (ARCH_MSM || ARCH_QCOM) > > I would actually drop USB || USB_GADGET dependency here just make it > easier to enable the driver on Kconfig, other you have to enable > USB_SUPPORT, then enable USB, go back one menu level, go down to PHY > menu, and choose this driver. > Because phy directory already depends on USB_SUPPORT? Regards, Ivan