From: "Ivan T. Ivanov" <iivanov@mm-sol.com>
To: Rob Herring <robherring2@gmail.com>
Cc: Courtney Cavin <courtney.cavin@sonymobile.com>,
Josh Cartwright <joshc@codeaurora.org>,
Samuel Ortiz <sameo@linux.intel.com>,
Lee Jones <lee.jones@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>
Subject: Re: [RFC PATCH] mfd: pm8x41: Naive function devices registration
Date: Fri, 25 Apr 2014 17:15:50 +0300 [thread overview]
Message-ID: <1398435350.4724.244.camel@iivanov-dev> (raw)
In-Reply-To: <CAL_Jsq+biEgbb7MmDuMsZ-bjocX0u=vvgZQHb6D696eGWDF7WA@mail.gmail.com>
On Fri, 2014-04-25 at 08:43 -0500, Rob Herring wrote:
> On Fri, Apr 25, 2014 at 8:29 AM, Ivan T. Ivanov <iivanov@mm-sol.com> wrote:
> > On Fri, 2014-04-25 at 08:00 -0500, Rob Herring wrote:
> >> On Fri, Apr 25, 2014 at 7:32 AM, Ivan T. Ivanov <iivanov@mm-sol.com> wrote:
> >> > From: "Ivan T. Ivanov" <iivanov@mm-sol.com>
> >> >
> >> > Currently functions that exist in both the controller at the
> >> > same address offset can not be specified with the same names.
> >> >
> >> > Adding Unique Slave ID device address to prefix function
> >> > device names fixes this.
> >> >
> >> > Function devices are SPMI devices, so register them on
> >> > SPMI bus.
> >> >
> >> > Signed-off-by: Ivan T. Ivanov <iivanov@mm-sol.com>
> >> > ---
> >> > drivers/mfd/pm8x41.c | 61 ++++++++++++++++++++++++++++++++++++++++++++++++----
> >>
> >> No, this should be fixed in the core, not the driver.
> >
> > I think that at core level they are no issues.
>
> By core, I mean the device naming conventions used by the DT platform
> device code. There is a problem and it should be handled.
>
> As I mentioned in the other thread, either we should not use the
> address on non-translatable addresses like this or append the parent
> address.
Ok, I see.
Regards,
Ivan
next prev parent reply other threads:[~2014-04-25 14:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-25 12:32 [RFC PATCH] mfd: pm8x41: Naive function devices registration Ivan T. Ivanov
2014-04-25 13:00 ` Rob Herring
2014-04-25 13:29 ` Ivan T. Ivanov
2014-04-25 13:43 ` Rob Herring
2014-04-25 14:15 ` Ivan T. Ivanov [this message]
2014-04-25 14:15 ` Josh Cartwright
2014-04-25 14:34 ` Ivan T. Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1398435350.4724.244.camel@iivanov-dev \
--to=iivanov@mm-sol.com \
--cc=courtney.cavin@sonymobile.com \
--cc=joshc@codeaurora.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robherring2@gmail.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).