[PATCH 1/3] usb: phy: msm: cast to unsigned long int

[PATCH 1/3] usb: phy: msm: cast to unsigned long int

[Felipe Balbi]

this solves the following build warning found when
running compile tests.

drivers/usb/phy/phy-msm-usb.c: In function ‘msm_otg_read_dt’:
drivers/usb/phy/phy-msm-usb.c:1459:20: warning: cast from pointer \
	to integer of different size [-Wpointer-to-int-cast]
  pdata->phy_type = (int) id->data;
                    ^
Signed-off-by: Felipe Balbi <balbi@ti.com>
---

all patches are on top of Ivan's 20 patch series.

 drivers/usb/phy/phy-msm-usb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c
index 9dc7918..c9963c8 100644
--- a/drivers/usb/phy/phy-msm-usb.c
+++ b/drivers/usb/phy/phy-msm-usb.c
@@ -1456,7 +1456,7 @@ static int msm_otg_read_dt(struct platform_device *pdev, struct msm_otg *motg)
 	motg->pdata = pdata;
 
 	id = of_match_device(msm_otg_dt_match, &pdev->dev);
-	pdata->phy_type = (int) id->data;
+	pdata->phy_type = (unsigned long int) id->data;
 
 	motg->link_rst = devm_reset_control_get(&pdev->dev, "link");
 	if (IS_ERR(motg->link_rst))
-- 
2.0.0.rc1

[PATCH 2/3] usb: phy: msm: switch over to writel()

[Felipe Balbi]

Remove that single instance of writel_relaxed()
call which is only available on ARM architecture.

This will let us build test this driver on all
different architectures.

Signed-off-by: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
---
 drivers/usb/phy/phy-msm-usb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c
index c9963c8..13b59ad 100644
--- a/drivers/usb/phy/phy-msm-usb.c
+++ b/drivers/usb/phy/phy-msm-usb.c
@@ -1600,7 +1600,7 @@ static int msm_otg_probe(struct platform_device *pdev)
 		if (IS_ERR(phy_select))
 			return PTR_ERR(phy_select);
 		/* Enable second PHY with the OTG port */
-		writel_relaxed(0x1, phy_select);
+		writel(0x1, phy_select);
 	}
 
 	dev_info(&pdev->dev, "OTG regs = %p\n", motg->regs);
-- 
2.0.0.rc1

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/3] usb: phy: msm: switch over to writel()

[Ivan T. Ivanov]

On Wed, 2014-04-30 at 11:38 -0500, Felipe Balbi wrote:
> Remove that single instance of writel_relaxed()
> call which is only available on ARM architecture.
> 
> This will let us build test this driver on all
> different architectures.
> 
> Signed-off-by: Felipe Balbi <balbi@ti.com>

Reviewed-by: Ivan T. Ivanov <iivanov@mm-sol.com>

> ---
>  drivers/usb/phy/phy-msm-usb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c
> index c9963c8..13b59ad 100644
> --- a/drivers/usb/phy/phy-msm-usb.c
> +++ b/drivers/usb/phy/phy-msm-usb.c
> @@ -1600,7 +1600,7 @@ static int msm_otg_probe(struct platform_device *pdev)
>  		if (IS_ERR(phy_select))
>  			return PTR_ERR(phy_select);
>  		/* Enable second PHY with the OTG port */
> -		writel_relaxed(0x1, phy_select);
> +		writel(0x1, phy_select);
>  	}
>  
>  	dev_info(&pdev->dev, "OTG regs = %p\n", motg->regs);

Re: [PATCH 1/3] usb: phy: msm: cast to unsigned long int

[Ivan T. Ivanov]

On Wed, 2014-04-30 at 11:38 -0500, Felipe Balbi wrote:
> this solves the following build warning found when
> running compile tests.
> 
> drivers/usb/phy/phy-msm-usb.c: In function ‘msm_otg_read_dt’:
> drivers/usb/phy/phy-msm-usb.c:1459:20: warning: cast from pointer \
> 	to integer of different size [-Wpointer-to-int-cast]
>   pdata->phy_type = (int) id->data;
>                     ^
> Signed-off-by: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
> ---
> 
> all patches are on top of Ivan's 20 patch series.
> 
>  drivers/usb/phy/phy-msm-usb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c
> index 9dc7918..c9963c8 100644
> --- a/drivers/usb/phy/phy-msm-usb.c
> +++ b/drivers/usb/phy/phy-msm-usb.c
> @@ -1456,7 +1456,7 @@ static int msm_otg_read_dt(struct platform_device *pdev, struct msm_otg *motg)
>  	motg->pdata = pdata;
>  
>  	id = of_match_device(msm_otg_dt_match, &pdev->dev);
> -	pdata->phy_type = (int) id->data;
> +	pdata->phy_type = (unsigned long int) id->data;

Probably cast to enum msm_usb_phy_type will be better.

Regards,
Ivan

>  
>  	motg->link_rst = devm_reset_control_get(&pdev->dev, "link");
>  	if (IS_ERR(motg->link_rst))


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/3] usb: phy: msm: cast to unsigned long int

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 1290 bytes --]

On Sat, May 03, 2014 at 09:56:32AM +0300, Ivan T. Ivanov wrote:
> On Wed, 2014-04-30 at 11:38 -0500, Felipe Balbi wrote:
> > this solves the following build warning found when
> > running compile tests.
> > 
> > drivers/usb/phy/phy-msm-usb.c: In function ‘msm_otg_read_dt’:
> > drivers/usb/phy/phy-msm-usb.c:1459:20: warning: cast from pointer \
> > 	to integer of different size [-Wpointer-to-int-cast]
> >   pdata->phy_type = (int) id->data;
> >                     ^
> > Signed-off-by: Felipe Balbi <balbi@ti.com>
> > ---
> > 
> > all patches are on top of Ivan's 20 patch series.
> > 
> >  drivers/usb/phy/phy-msm-usb.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c
> > index 9dc7918..c9963c8 100644
> > --- a/drivers/usb/phy/phy-msm-usb.c
> > +++ b/drivers/usb/phy/phy-msm-usb.c
> > @@ -1456,7 +1456,7 @@ static int msm_otg_read_dt(struct platform_device *pdev, struct msm_otg *motg)
> >  	motg->pdata = pdata;
> >  
> >  	id = of_match_device(msm_otg_dt_match, &pdev->dev);
> > -	pdata->phy_type = (int) id->data;
> > +	pdata->phy_type = (unsigned long int) id->data;
> 
> Probably cast to enum msm_usb_phy_type will be better.

will do.

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH 1/3] usb: phy: msm: cast to unsigned long int

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 2565 bytes --]

On Mon, May 05, 2014 at 10:03:31AM -0500, Felipe Balbi wrote:
> On Sat, May 03, 2014 at 09:56:32AM +0300, Ivan T. Ivanov wrote:
> > On Wed, 2014-04-30 at 11:38 -0500, Felipe Balbi wrote:
> > > this solves the following build warning found when
> > > running compile tests.
> > > 
> > > drivers/usb/phy/phy-msm-usb.c: In function ‘msm_otg_read_dt’:
> > > drivers/usb/phy/phy-msm-usb.c:1459:20: warning: cast from pointer \
> > > 	to integer of different size [-Wpointer-to-int-cast]
> > >   pdata->phy_type = (int) id->data;
> > >                     ^
> > > Signed-off-by: Felipe Balbi <balbi@ti.com>
> > > ---
> > > 
> > > all patches are on top of Ivan's 20 patch series.
> > > 
> > >  drivers/usb/phy/phy-msm-usb.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c
> > > index 9dc7918..c9963c8 100644
> > > --- a/drivers/usb/phy/phy-msm-usb.c
> > > +++ b/drivers/usb/phy/phy-msm-usb.c
> > > @@ -1456,7 +1456,7 @@ static int msm_otg_read_dt(struct platform_device *pdev, struct msm_otg *motg)
> > >  	motg->pdata = pdata;
> > >  
> > >  	id = of_match_device(msm_otg_dt_match, &pdev->dev);
> > > -	pdata->phy_type = (int) id->data;
> > > +	pdata->phy_type = (unsigned long int) id->data;
> > 
> > Probably cast to enum msm_usb_phy_type will be better.
> 
> will do.

commit fe8ef54c824e5b01192462ef82861e65f57d299c
Author: Felipe Balbi <balbi@ti.com>
Date:   Wed Apr 30 11:33:04 2014 -0500

    usb: phy: msm: cast to unsigned long int
    
    this solves the following build warning found when
    running compile tests.
    
    drivers/usb/phy/phy-msm-usb.c: In function ‘msm_otg_read_dt’:
    drivers/usb/phy/phy-msm-usb.c:1459:20: warning: cast from pointer \
    	to integer of different size [-Wpointer-to-int-cast]
      pdata->phy_type = (int) id->data;
                        ^
    Signed-off-by: Felipe Balbi <balbi@ti.com>

diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c
index 9dc7918..591b406 100644
--- a/drivers/usb/phy/phy-msm-usb.c
+++ b/drivers/usb/phy/phy-msm-usb.c
@@ -1456,7 +1456,7 @@ static int msm_otg_read_dt(struct platform_device *pdev, struct msm_otg *motg)
 	motg->pdata = pdata;
 
 	id = of_match_device(msm_otg_dt_match, &pdev->dev);
-	pdata->phy_type = (int) id->data;
+	pdata->phy_type = (enum msm_usb_phy_type) id->data;
 
 	motg->link_rst = devm_reset_control_get(&pdev->dev, "link");
 	if (IS_ERR(motg->link_rst))

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[PATCH 3/3] usb: phy: msm: enable build on other architectures

[Felipe Balbi]

By adding COMPILE_TEST to the list of dependencies
we can build test this driver on all other architectures
which is very valuable for maintainers applying patches
and to find silly mistakes during development.

Signed-off-by: Felipe Balbi <balbi@ti.com>
---
 drivers/usb/phy/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig
index 0c668a3..fbbced8 100644
--- a/drivers/usb/phy/Kconfig
+++ b/drivers/usb/phy/Kconfig
@@ -172,7 +172,7 @@ config USB_ISP1301
 
 config USB_MSM_OTG
 	tristate "Qualcomm on-chip USB OTG controller support"
-	depends on (USB || USB_GADGET) && (ARCH_MSM || ARCH_QCOM)
+	depends on (USB || USB_GADGET) && (ARCH_MSM || ARCH_QCOM || COMPILE_TEST)
 	select USB_PHY
 	help
 	  Enable this to support the USB OTG transceiver on Qualcomm chips. It
-- 
2.0.0.rc1

Re: [PATCH 3/3] usb: phy: msm: enable build on other architectures

[Ivan T. Ivanov]

On Wed, 2014-04-30 at 11:38 -0500, Felipe Balbi wrote:
> By adding COMPILE_TEST to the list of dependencies
> we can build test this driver on all other architectures
> which is very valuable for maintainers applying patches
> and to find silly mistakes during development.
> 
> Signed-off-by: Felipe Balbi <balbi@ti.com>

Reviewed-by: Ivan T. Ivanov <iivanov@mm-sol.com>

> ---
>  drivers/usb/phy/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig
> index 0c668a3..fbbced8 100644
> --- a/drivers/usb/phy/Kconfig
> +++ b/drivers/usb/phy/Kconfig
> @@ -172,7 +172,7 @@ config USB_ISP1301
>  
>  config USB_MSM_OTG
>  	tristate "Qualcomm on-chip USB OTG controller support"
> -	depends on (USB || USB_GADGET) && (ARCH_MSM || ARCH_QCOM)
> +	depends on (USB || USB_GADGET) && (ARCH_MSM || ARCH_QCOM || COMPILE_TEST)
>  	select USB_PHY
>  	help
>  	  Enable this to support the USB OTG transceiver on Qualcomm chips. It