linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Ivan T. Ivanov" <iivanov@mm-sol.com>
To: Felipe Balbi <balbi@ti.com>
Cc: tim.bird@sonymobile.com, linux-arm-msm@vger.kernel.org,
	Linux USB Mailing List <linux-usb@vger.kernel.org>
Subject: Re: [PATCH 2/3] usb: phy: msm: switch over to writel()
Date: Sat, 03 May 2014 09:58:45 +0300	[thread overview]
Message-ID: <1399100325.7131.3.camel@violet> (raw)
In-Reply-To: <1398875916-14461-2-git-send-email-balbi@ti.com>

On Wed, 2014-04-30 at 11:38 -0500, Felipe Balbi wrote:
> Remove that single instance of writel_relaxed()
> call which is only available on ARM architecture.
> 
> This will let us build test this driver on all
> different architectures.
> 
> Signed-off-by: Felipe Balbi <balbi@ti.com>

Reviewed-by: Ivan T. Ivanov <iivanov@mm-sol.com>

> ---
>  drivers/usb/phy/phy-msm-usb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c
> index c9963c8..13b59ad 100644
> --- a/drivers/usb/phy/phy-msm-usb.c
> +++ b/drivers/usb/phy/phy-msm-usb.c
> @@ -1600,7 +1600,7 @@ static int msm_otg_probe(struct platform_device *pdev)
>  		if (IS_ERR(phy_select))
>  			return PTR_ERR(phy_select);
>  		/* Enable second PHY with the OTG port */
> -		writel_relaxed(0x1, phy_select);
> +		writel(0x1, phy_select);
>  	}
>  
>  	dev_info(&pdev->dev, "OTG regs = %p\n", motg->regs);

  reply	other threads:[~2014-05-03  6:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-30 16:38 [PATCH 1/3] usb: phy: msm: cast to unsigned long int Felipe Balbi
2014-04-30 16:38 ` [PATCH 3/3] usb: phy: msm: enable build on other architectures Felipe Balbi
2014-05-03  7:00   ` Ivan T. Ivanov
     [not found] ` <1398875916-14461-1-git-send-email-balbi-l0cyMroinI0@public.gmane.org>
2014-04-30 16:38   ` [PATCH 2/3] usb: phy: msm: switch over to writel() Felipe Balbi
2014-05-03  6:58     ` Ivan T. Ivanov [this message]
2014-05-03  6:56   ` [PATCH 1/3] usb: phy: msm: cast to unsigned long int Ivan T. Ivanov
2014-05-05 15:03     ` Felipe Balbi
2014-05-05 15:30       ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1399100325.7131.3.camel@violet \
    --to=iivanov@mm-sol.com \
    --cc=balbi@ti.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=tim.bird@sonymobile.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).