From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FEA3C77B75 for ; Wed, 17 May 2023 20:25:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229448AbjEQUZT (ORCPT ); Wed, 17 May 2023 16:25:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53260 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229733AbjEQUZR (ORCPT ); Wed, 17 May 2023 16:25:17 -0400 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B90F7DB1 for ; Wed, 17 May 2023 13:25:15 -0700 (PDT) Received: by mail-lj1-x229.google.com with SMTP id 38308e7fff4ca-2ac7f53ae44so13167501fa.2 for ; Wed, 17 May 2023 13:25:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684355113; x=1686947113; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gm3y2wIKXeo4RLdtNri9QzjjhdM2vmdYj4Pt4IbNgeQ=; b=T3UU2KsQKVP7jzVL0YJ9F+QUdQsuiP1YJmhRbdmpoDAZBtYZASegDO0CGJ0SlOQoSV QPRQHD4KchB4UXReT/BvncaFoxApXXHWzVtWBhaoUjuo3CS+p7rA8pGgi7wf9Wp+I25y T4S/NQWlvOnp3aCcfBuhKbAc2ieIsaLhnYe5plu4ClZNDqAxFD44i65ORMH9CgV9W0Ph g10aUdmJ70+dVSaJGtvYNKLL2DuJCN7CHlaFmxHCK+PvM5QRy7vgJu4IYlI3KuPkhUMM OU4hByTHiiULBMS8WrbdWQl+QcsQfv8sCqp/FN985t56olljbCVr7pjrINH+/m5AtsO4 HQ9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684355113; x=1686947113; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gm3y2wIKXeo4RLdtNri9QzjjhdM2vmdYj4Pt4IbNgeQ=; b=A9l/7bp/Rch/v1jbVb6uobkFyPX5rhPLlAto2gju01xCU38FmrWuB0vbAW/Y3rgH+m 0xkItvxDRh3cPhbjz4LUxCYp7B+CRXu1IENVHxW3Q6l6HLryPmSN5gOMbnJZMj3oAuV/ x/w/cVtJzHAZt1SmOfKZ/G8+6y4PeFZpyJG4Kg+a0U7Kb9B+weKcQef+NBvxP54BS4ri vomTddqGWItfvNxfwxZoqDQRKzAqepNXePLlZtt90kKPPb1ZH6RhUNcTaVy8ng0O45eF rgOkIMjmmd1IGOGLPzcWLJTwOgoClDoEcbBEIJqV3pGpRc8TUrZoD4dR/bSQeb30uFWH VG+Q== X-Gm-Message-State: AC+VfDxTIzMDWsZ34SmBuSMZOgC7H7fImF1/m+EzBLVT0HLpyP4Q3/eG EQwliXcweOIiYkSy4UuV7wfLjA== X-Google-Smtp-Source: ACHHUZ7R9mpYrHl5GpfD2kyel38ZdFHESzb8buFCHSAUaVXx3wxYh2W6X5t0lDlBw2zfZpGSaAA/NA== X-Received: by 2002:a2e:999a:0:b0:2ae:d269:5a1e with SMTP id w26-20020a2e999a000000b002aed2695a1emr5041062lji.21.1684355113248; Wed, 17 May 2023 13:25:13 -0700 (PDT) Received: from [192.168.1.101] (abxi58.neoplus.adsl.tpnet.pl. [83.9.2.58]) by smtp.gmail.com with ESMTPSA id y5-20020a2e95c5000000b002addbc16a54sm2021760ljh.41.2023.05.17.13.25.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 May 2023 13:25:12 -0700 (PDT) Message-ID: <13f7055b-8ec2-68c3-06a4-d650f76c0ac2@linaro.org> Date: Wed, 17 May 2023 22:25:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v2 00/18] Venus QoL / maintainability fixes Content-Language: en-US To: Vikash Garodia , Bryan O'Donoghue , Stanimir Varbanov , Andy Gross , Bjorn Andersson , Mauro Carvalho Chehab , Dikshita Agarwal , Mansur Alisha Shaik , Jonathan Marek , Hans Verkuil , Dikshita Agarwal Cc: Mauro Carvalho Chehab , Stanimir Varbanov , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Marijn Suijten , stable@vger.kernel.org References: <20230228-topic-venus-v2-0-d95d14949c79@linaro.org> <049c7e3e-eaf2-0253-bf5b-83b9e8f949ab@quicinc.com> From: Konrad Dybcio In-Reply-To: <049c7e3e-eaf2-0253-bf5b-83b9e8f949ab@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 16.05.2023 14:57, Vikash Garodia wrote: > > On 5/12/2023 8:31 AM, Bryan O'Donoghue wrote: >> On 04/05/2023 09:00, Konrad Dybcio wrote: >>> Tested on 8250, but pretty please test it on your boards too! >> >> What's the definition of test here ? >> >> I ran this >> >> ffplay -codec:video h264_v4l2m2m FantasticFour-ROTSS.mp4 >> >> and this >> >> ffplay -codec:video vp8_v4l2m2m /mnt/big-buck-bunny_trailer.webm >> >> on db410c with no errors. Then again I applied and disapplied the 8x8 264 fix to >> that branch and saw no discernable difference so I'm not very confident we have >> good coverage. >> >> @Stan @Vikash could you give some suggested tests for coverage here ? > > I could think of below test aspects for this series > 1. Suspend Resume > 2. Concurrency test > 3. Module load -> video usecase -> module unload -> module load -> video > usecase. This would ensure video firmware is reloaded and functional. > 4. Video playback and encode for all supported resolution and codecs. > 5. In general, video playback with more test content. > > I would be testing the series with stability test suite on CrOS. That would be > either on sc7180 or sc7280 setup. > > Konrad, you can post the new version as one patch needs to be dropped. Test can > be done on the new version. There are few patches in the series pending review, > which can be done in parallel. Sure, working on it! Konrad > > -Vikash > >> >> @Konrad - get a db410c ! >> >> My superficial first-pass on this series looks good but, before giving a >> Tested-by here, I think we should define a set of coverage tests, run them - the >> upper end on sm8250 and lower end msm8916 "makes sense to me" >> >> 20? different gstreamer tests at different formats and different sizes on our >> selected platforms db410c, rb5, rb3 I have - also an 820 I haven't booted and an >> enforce sdm660. >> >> Which tests will we use to validate this series and subsequent series to ensure >> we don't have more regressions ? >> >> --- >> bod