From: Dolev Raviv <draviv@codeaurora.org>
To: James.Bottomley@HansenPartnership.com
Cc: linux-scsi@vger.kernel.org, linux-scsi-owner@vger.kernel.org,
sthumma@codeaurora.org, linux-arm-msm@vger.kernel.org,
santoshsy@gmail.com, Dolev Raviv <draviv@codeaurora.org>
Subject: [PATCH V2 2/5] scsi: ufs: fix endianness sparse warnings
Date: Tue, 22 Jul 2014 17:23:47 +0300 [thread overview]
Message-ID: <1406039030-14246-3-git-send-email-draviv@codeaurora.org> (raw)
In-Reply-To: <1406039030-14246-1-git-send-email-draviv@codeaurora.org>
From: Sujit Reddy Thumma <sthumma@codeaurora.org>
Fix many warnings with incorrect endian assumptions
which makes the code unportable to new architectures.
The UFS specification defines the byte order as big-endian
for UPIU structure and little-endian for the host controller
transfer/task management descriptors.
Signed-off-by: Sujit Reddy Thumma <sthumma@codeaurora.org>
Signed-off-by: Dolev Raviv <draviv@codeaurora.org>
---
drivers/scsi/ufs/ufshcd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 694c8cc..514f65a 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -1325,7 +1325,7 @@ static int ufshcd_query_descriptor(struct ufs_hba *hba,
ufshcd_init_query(hba, &request, &response, opcode, idn, index,
selector);
hba->dev_cmd.query.descriptor = desc_buf;
- request->upiu_req.length = *buf_len;
+ request->upiu_req.length = cpu_to_be16(*buf_len);
switch (opcode) {
case UPIU_QUERY_OPCODE_WRITE_DESC:
@@ -1351,7 +1351,7 @@ static int ufshcd_query_descriptor(struct ufs_hba *hba,
}
hba->dev_cmd.query.descriptor = NULL;
- *buf_len = response->upiu_res.length;
+ *buf_len = be16_to_cpu(response->upiu_res.length);
out_unlock:
mutex_unlock(&hba->dev_cmd.lock);
--
1.8.5.2
--
QUALCOMM ISRAEL, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2014-07-22 14:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-22 14:23 [PATCH V2 0/5] scsi: ufs: LU queue depth management Dolev Raviv
2014-07-22 14:23 ` [PATCH 1/5] scsi: ufs: query descriptor API Dolev Raviv
2014-07-22 14:23 ` Dolev Raviv [this message]
2014-07-22 14:23 ` [PATCH V2 3/5] scsi: ufs: device query status and size check Dolev Raviv
2014-07-22 14:23 ` [PATCH V2 4/5] scsi: ufs: Logical Unit (LU) command queue depth Dolev Raviv
2014-07-22 14:23 ` [PATCH V2 5/5] scsi: ufs: Fix queue depth handling for best effort cases Dolev Raviv
2014-07-22 16:05 ` [PATCH V2 0/5] scsi: ufs: LU queue depth management Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1406039030-14246-3-git-send-email-draviv@codeaurora.org \
--to=draviv@codeaurora.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-scsi-owner@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=santoshsy@gmail.com \
--cc=sthumma@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).