linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dolev Raviv <draviv@codeaurora.org>
To: James.Bottomley@HansenPartnership.com, hch@infradead.org
Cc: linux-scsi@vger.kernel.org, linux-scsi-owner@vger.kernel.org,
	linux-arm-msm@vger.kernel.org, santoshsy@gmail.com,
	Subhash Jadavani <subhashj@codeaurora.org>,
	Sujit Reddy Thumma <sthumma@codeaurora.org>,
	Dolev Raviv <draviv@codeaurora.org>
Subject: [PATCH V6 01/18] scsi: fixing the "type" for well known LUs
Date: Thu, 25 Sep 2014 15:32:19 +0300	[thread overview]
Message-ID: <1411648356-3883-2-git-send-email-draviv@codeaurora.org> (raw)
In-Reply-To: <1411648356-3883-1-git-send-email-draviv@codeaurora.org>

From: Subhash Jadavani <subhashj@codeaurora.org>

Some devices may respond with wrong type for well-known logical units.
This patch forces well-known type for devices which doesn't report it
correct.

Signed-off-by: Subhash Jadavani <subhashj@codeaurora.org>
Signed-off-by: Sujit Reddy Thumma <sthumma@codeaurora.org>
Signed-off-by: Dolev Raviv <draviv@codeaurora.org>

diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c
index 56675db..1095d5a 100644
--- a/drivers/scsi/scsi_scan.c
+++ b/drivers/scsi/scsi_scan.c
@@ -805,6 +805,19 @@ static int scsi_add_lun(struct scsi_device *sdev, unsigned char *inq_result,
 	} else {
 		sdev->type = (inq_result[0] & 0x1f);
 		sdev->removable = (inq_result[1] & 0x80) >> 7;
+
+		/*
+		 * some devices may respond with wrong type for
+		 * well-known logical units. Force well-known type
+		 * to enumerate them correctly.
+		 */
+		if (scsi_is_wlun(sdev->lun) && sdev->type != TYPE_WLUN) {
+			sdev_printk(KERN_WARNING, sdev,
+				"%s: correcting incorrect peripheral device type 0x%x for W-LUN 0x%16phN\n",
+				__func__, sdev->type, sdev->lun);
+			sdev->type = TYPE_WLUN;
+		}
+
 	}
 
 	if (sdev->type == TYPE_RBC || sdev->type == TYPE_ROM) {
diff --git a/include/scsi/scsi.h b/include/scsi/scsi.h
index 261e708..d17178e 100644
--- a/include/scsi/scsi.h
+++ b/include/scsi/scsi.h
@@ -333,6 +333,7 @@ static inline int scsi_status_is_good(int status)
 #define TYPE_RBC	    0x0e
 #define TYPE_OSD            0x11
 #define TYPE_ZBC            0x14
+#define TYPE_WLUN           0x1e    /* well-known logical unit */
 #define TYPE_NO_LUN         0x7f
 
 /* SCSI protocols; these are taken from SPC-3 section 7.5 */
-- 
1.8.5.2
-- 
QUALCOMM ISRAEL, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation

  reply	other threads:[~2014-09-25 12:32 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-25 12:32 [PATCH/RESEND V6 00/18] UFS: Power management support Dolev Raviv
2014-09-25 12:32 ` Dolev Raviv [this message]
2014-09-26  8:13   ` [PATCH V6 01/18] scsi: fixing the "type" for well known LUs Christoph Hellwig
2014-10-03 18:40     ` Elliott, Robert (Server Storage)
2014-09-25 12:32 ` [PATCH V6 02/18] scsi: sysfs: don't add scsi_device if its already added Dolev Raviv
2014-09-26  8:14   ` Christoph Hellwig
2014-09-26 13:41     ` Hannes Reinecke
2014-09-30 21:54     ` Martin K. Petersen
2014-09-25 12:32 ` [PATCH/RESEND V6 03/18] scsi: ufs: Allow vendor specific initialization Dolev Raviv
2014-09-25 12:32 ` [PATCH/RESEND V6 04/18] scsi: ufs: Add regulator enable support Dolev Raviv
2014-09-25 12:32 ` [PATCH/RESEND V6 05/18] scsi: ufs: Add clock initialization support Dolev Raviv
2014-09-25 12:32 ` [PATCH/RESEND V6 06/18] scsi: ufs: add voting support for host controller power Dolev Raviv
2014-09-25 12:32 ` [PATCH/RESEND V6 07/18] scsi: ufs: refactor query descriptor API support Dolev Raviv
2014-09-25 12:32 ` [PATCH/RESEND V6 08/18] scsi: ufs: improve init sequence Dolev Raviv
2014-09-25 12:32 ` [PATCH/RESEND V6 09/18] scsi: ufs: Active Power Mode - configuring bActiveICCLevel Dolev Raviv
2014-09-25 12:32 ` [PATCH V6 10/18] scsi: ufs: manually add well known logical units Dolev Raviv
2014-10-03 16:16   ` Akinobu Mita
2014-10-03 16:35     ` Subhash Jadavani
2014-10-03 16:35     ` Christoph Hellwig
2014-10-05  7:31       ` Akinobu Mita
2014-09-25 12:32 ` [PATCH V6 11/18] scsi: ufs: introduce well known logical unit in ufs Dolev Raviv
2014-09-25 12:32 ` [PATCH V6 12/18] scsi: ufs: add UFS power management support Dolev Raviv
2014-09-25 12:32 ` [PATCH/RESEND V6 13/18] scsi: ufs: refactor configuring power mode Dolev Raviv
2014-10-03 16:20   ` Akinobu Mita
2014-10-03 16:42     ` Subhash Jadavani
2014-09-25 12:32 ` [PATCH/RESEND V6 14/18] scsi: ufs: Add support for clock gating Dolev Raviv
2014-09-25 12:32 ` [PATCH/RESEND V6 15/18] scsi: ufs: Add freq-table-hz property for UFS device Dolev Raviv
2014-09-25 12:32 ` [PATCH/RESEND V6 16/18] scsi: ufs: Add support for clock scaling using devfreq framework Dolev Raviv
2014-09-25 12:32 ` [PATCH/RESEND V6 17/18] scsi: ufs: tune bkops while power managment events Dolev Raviv
2014-09-25 12:32 ` [PATCH/RESEND V6 18/18] scsi: ufs: definitions for phy interface Dolev Raviv
2014-09-25 15:43 ` [PATCH/RESEND V6 00/18] UFS: Power management support David Miller
2014-09-30 14:26 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1411648356-3883-2-git-send-email-draviv@codeaurora.org \
    --to=draviv@codeaurora.org \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=hch@infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-scsi-owner@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=santoshsy@gmail.com \
    --cc=sthumma@codeaurora.org \
    --cc=subhashj@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).