From: "Ivan T. Ivanov" <iivanov@mm-sol.com>
To: Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>
Cc: "Ivan T. Ivanov" <iivanov@mm-sol.com>,
Angelo Compagnucci <angelo.compagnucci@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: [PATCH v4 0/2] Initial support for voltage ADC
Date: Mon, 3 Nov 2014 17:24:28 +0200 [thread overview]
Message-ID: <1415028270-25860-1-git-send-email-iivanov@mm-sol.com> (raw)
Hi,
This is the forth version of this driver. V3 could be found here [1].
Changes since v3.
- Addressed review comments from Hartmut Knaack and Mark Rutland:
Better description of 'reg' property.
Add # to address-cells and size-cells DT document.
Dropped interrupt-names property, it was not actually used by driver.
DT header file, which contain channels names definitions, is part of
documentation patch now.
Clarified 'qcom,decimation' property. Hopefully it make sense now.
Make more explicit that all reference channels configuration nodes have
to be defined in DT.
- Promote dev_dbg to dev_err in error paths. Stan, I hope you are ok with this :-)
- Use 32 bit calculations in calibration routine.
- Read ADC result with one regmap call.
- Show status and state registers if ADC conversin fails. Errors should not
normally happen, so I will like to see content of this registers in such cases.
- Use new struct iio_info::of_xlate for channel number translation.
- Removed device wakeup initialization code, which didn't make sense to me
for such kind of device.
Patches depend on "iio: inkern: Add of_xlate function to struct iio_info" patch,
which is included in IIO testing branch [2].
[1] http://comments.gmane.org/gmane.linux.ports.arm.msm/9741
[2] http://git.kernel.org/cgit/linux/kernel/git/jic23/iio.git/log/?h=testing
Stanimir Varbanov (2):
DT: iio: vadc: document dt binding
iio: vadc: Qualcomm SPMI PMIC voltage ADC driver
.../devicetree/bindings/iio/adc/qcom,spmi-vadc.txt | 129 +++
drivers/iio/adc/Kconfig | 14 +
drivers/iio/adc/Makefile | 1 +
drivers/iio/adc/qcom-spmi-vadc.c | 1015 ++++++++++++++++++++
include/dt-bindings/iio/qcom,spmi-vadc.h | 119 +++
5 files changed, 1278 insertions(+)
create mode 100644 Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt
create mode 100644 drivers/iio/adc/qcom-spmi-vadc.c
create mode 100644 include/dt-bindings/iio/qcom,spmi-vadc.h
--
1.9.1
next reply other threads:[~2014-11-03 15:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-03 15:24 Ivan T. Ivanov [this message]
[not found] ` <1415028270-25860-1-git-send-email-iivanov-NEYub+7Iv8PQT0dZR+AlfA@public.gmane.org>
2014-11-03 15:24 ` [PATCH v4 1/2] DT: iio: vadc: document dt binding Ivan T. Ivanov
[not found] ` <1415028270-25860-2-git-send-email-iivanov-NEYub+7Iv8PQT0dZR+AlfA@public.gmane.org>
2014-11-05 0:01 ` Hartmut Knaack
2014-11-05 13:12 ` Jonathan Cameron
2014-11-05 14:07 ` Ivan T. Ivanov
2014-11-03 15:24 ` [PATCH v4 2/2] iio: vadc: Qualcomm SPMI PMIC voltage ADC driver Ivan T. Ivanov
2014-11-05 13:09 ` Jonathan Cameron
[not found] ` <545A218F.5060301-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2014-11-05 13:57 ` Ivan T. Ivanov
[not found] ` <1415195855.3660.4.camel-NEYub+7Iv8PQT0dZR+AlfA@public.gmane.org>
2014-11-05 14:06 ` Jonathan Cameron
2014-11-05 15:01 ` Ivan T. Ivanov
[not found] ` <1415199681.3660.8.camel-NEYub+7Iv8PQT0dZR+AlfA@public.gmane.org>
2014-11-05 15:32 ` Jonathan Cameron
[not found] ` <1415028270-25860-3-git-send-email-iivanov-NEYub+7Iv8PQT0dZR+AlfA@public.gmane.org>
2014-11-10 21:11 ` Hartmut Knaack
2014-11-11 8:21 ` Ivan T. Ivanov
2014-11-11 22:39 ` Hartmut Knaack
[not found] ` <54629026.3080002-Mmb7MZpHnFY@public.gmane.org>
2014-11-12 8:55 ` Ivan T. Ivanov
2014-11-17 22:12 ` Hartmut Knaack
2014-11-18 8:23 ` Ivan T. Ivanov
[not found] ` <1416299013.30131.4.camel-NEYub+7Iv8PQT0dZR+AlfA@public.gmane.org>
2014-11-22 11:55 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415028270-25860-1-git-send-email-iivanov@mm-sol.com \
--to=iivanov@mm-sol.com \
--cc=angelo.compagnucci@gmail.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox