From: Gilad Avidov <gavidov@codeaurora.org>
To: gavidov@codeaurora.org, sdharia@codeaurora.org,
mlocke@codeaurora.org, linux-arm-msm@vger.kernel.org,
gregkh@linuxfoundation.org, svarbanov@mm-sol.com
Cc: linux-kernel@vger.kernel.org, iivanov@mm-sol.com,
galak@codeaurora.org, agross@codeaurora.org
Subject: [PATCH V5 0/2] add support for pmic_arb v2 and correct framework
Date: Wed, 25 Mar 2015 11:37:30 -0600 [thread overview]
Message-ID: <1427305052-1284-1-git-send-email-gavidov@codeaurora.org> (raw)
pmic_arb v2 has no support for spmi non-data commands and thus
returns -EOPNOTSUPP on .cmd callback. This causes a failure in
spmi_drv_probe() which sends a wakeup command to the slave before
probing its driver. This patchset removes the wakeup from
spmi_drv_probe() since the spmi spec stipulates that a slaves
default state is active and doesn't need a wakeup.
Changes from v3 to v4:
* Remove the claim that this is a bug fix off the commit text
* Unmap the core register space as soon as we know that it will not be used
* Assign the core reg space to a local until we know if it appropriate to use
it to configure the controller fields (on v1) or unmap it (on v2).
Changes from v4 to v5:
* remove the unmap added in v4 since it is used again and the mapping is managed.
* correct printf formatting for 64bit compilers.
* correct base address for reading the channel table.
Gilad Avidov (2):
spmi: remove wakeup command before slave probe
spmi: pmic_arb: add support for hw version 2
.../bindings/spmi/qcom,spmi-pmic-arb.txt | 6 +-
drivers/spmi/spmi-pmic-arb.c | 319 +++++++++++++++++----
drivers/spmi/spmi.c | 9 +-
3 files changed, 267 insertions(+), 67 deletions(-)
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
next reply other threads:[~2015-03-25 17:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-25 17:37 Gilad Avidov [this message]
2015-03-25 17:37 ` [PATCH V5 1/2] spmi: remove wakeup command before slave probe Gilad Avidov
2015-03-25 17:37 ` [PATCH V5 2/2] spmi: pmic_arb: add support for hw version 2 Gilad Avidov
2015-03-26 9:51 ` [PATCH V5 0/2] add support for pmic_arb v2 and correct framework Ivan T. Ivanov
2015-03-26 15:26 ` Kumar Gala
2015-03-26 22:51 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427305052-1284-1-git-send-email-gavidov@codeaurora.org \
--to=gavidov@codeaurora.org \
--cc=agross@codeaurora.org \
--cc=galak@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=iivanov@mm-sol.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mlocke@codeaurora.org \
--cc=sdharia@codeaurora.org \
--cc=svarbanov@mm-sol.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).