linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Gilad Avidov <gavidov@codeaurora.org>
To: gavidov@codeaurora.org, sdharia@codeaurora.org,
	mlocke@codeaurora.org, linux-arm-msm@vger.kernel.org,
	gregkh@linuxfoundation.org, svarbanov@mm-sol.com
Cc: linux-kernel@vger.kernel.org, iivanov@mm-sol.com,
	galak@codeaurora.org, agross@codeaurora.org
Subject: [PATCH V5 1/2] spmi: remove wakeup command before slave probe
Date: Wed, 25 Mar 2015 11:37:31 -0600	[thread overview]
Message-ID: <1427305052-1284-2-git-send-email-gavidov@codeaurora.org> (raw)
In-Reply-To: <1427305052-1284-1-git-send-email-gavidov@codeaurora.org>

According to spmi spec a slave powers up into startup state and then
transitions into active state. Thus, the wakeup command is not required
before calling the slave's probe. The wakeup command is only needed for
slaves that are in sleep state after receiving the sleep command.

Cc: galak@codeaurora.org
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
Reviewed-by: Sagar Dharia <sdharia@codeaurora.org>
Acked-by: Josh Cartwright <joshc@eso.teric.us>
Signed-off-by: Gilad Avidov <gavidov@codeaurora.org>
---
 drivers/spmi/spmi.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/drivers/spmi/spmi.c b/drivers/spmi/spmi.c
index 1d92f51..9493843 100644
--- a/drivers/spmi/spmi.c
+++ b/drivers/spmi/spmi.c
@@ -1,4 +1,5 @@
-/* Copyright (c) 2012-2013, The Linux Foundation. All rights reserved.
+/*
+ * Copyright (c) 2012-2015, The Linux Foundation. All rights reserved.
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 2 and
@@ -316,11 +317,6 @@ static int spmi_drv_probe(struct device *dev)
 	struct spmi_device *sdev = to_spmi_device(dev);
 	int err;
 
-	/* Ensure the slave is in ACTIVE state */
-	err = spmi_command_wakeup(sdev);
-	if (err)
-		goto fail_wakeup;
-
 	pm_runtime_get_noresume(dev);
 	pm_runtime_set_active(dev);
 	pm_runtime_enable(dev);
@@ -335,7 +331,6 @@ fail_probe:
 	pm_runtime_disable(dev);
 	pm_runtime_set_suspended(dev);
 	pm_runtime_put_noidle(dev);
-fail_wakeup:
 	return err;
 }
 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation

  reply	other threads:[~2015-03-25 17:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-25 17:37 [PATCH V5 0/2] add support for pmic_arb v2 and correct framework Gilad Avidov
2015-03-25 17:37 ` Gilad Avidov [this message]
2015-03-25 17:37 ` [PATCH V5 2/2] spmi: pmic_arb: add support for hw version 2 Gilad Avidov
2015-03-26  9:51 ` [PATCH V5 0/2] add support for pmic_arb v2 and correct framework Ivan T. Ivanov
2015-03-26 15:26   ` Kumar Gala
2015-03-26 22:51     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1427305052-1284-2-git-send-email-gavidov@codeaurora.org \
    --to=gavidov@codeaurora.org \
    --cc=agross@codeaurora.org \
    --cc=galak@codeaurora.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=iivanov@mm-sol.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mlocke@codeaurora.org \
    --cc=sdharia@codeaurora.org \
    --cc=svarbanov@mm-sol.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).