From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Bolle Subject: Re: [PATCH 2/2] soc: qcom: Add Shared Memory Manager driver Date: Sat, 04 Apr 2015 13:16:18 +0200 Message-ID: <1428146178.7898.75.camel@x220> References: <1428102200-5948-1-git-send-email-bjorn.andersson@sonymobile.com> <1428102200-5948-2-git-send-email-bjorn.andersson@sonymobile.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from lb1-smtp-cloud6.xs4all.net ([194.109.24.24]:45651 "EHLO lb1-smtp-cloud6.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752134AbbDDLQW (ORCPT ); Sat, 4 Apr 2015 07:16:22 -0400 In-Reply-To: <1428102200-5948-2-git-send-email-bjorn.andersson@sonymobile.com> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Bjorn Andersson Cc: Kumar Gala , Andy Gross , David Brown , Jeffrey Hugo , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org On Fri, 2015-04-03 at 16:03 -0700, Bjorn Andersson wrote: > --- a/drivers/soc/qcom/Kconfig > +++ b/drivers/soc/qcom/Kconfig > +config QCOM_SMEM > + tristate "Qualcomm Shared Memory Manager (SMEM)" > + depends on ARCH_QCOM > + help > + Say y here to enable support for the Qualcomm Shared Memory Manager. > + The driver provides an interface to items in a heap shared among all > + processors in a Qualcomm platform. > --- a/drivers/soc/qcom/Makefile > +++ b/drivers/soc/qcom/Makefile > @@ -1 +1,2 @@ > +obj-$(CONFIG_QCOM_SMEM) += smem.o Just to make absolutely sure I'm not misreading this Makefile: if QCOM_SMEM is set to 'm' this will generate the module smem.ko, right? > --- /dev/null > +++ b/drivers/soc/qcom/smem.c > @@ -0,0 +1,763 @@ > +/* > + * Copyright (c) 2015, Sony Mobile Communications AB. > + * Copyright (c) 2012-2013, The Linux Foundation. All rights reserved. > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 and > + * only version 2 as published by the Free Software Foundation. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + */ > +MODULE_LICENSE("GPLv2"); "GPLv2" doesn't indicate a GPL compatible license according to include/linux/license.h. Loading smem.ko should trigger a warning and taint the kernel. So you want MODULE_LICENSE("GPL v2"); here. Paul Bolle