From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Ivan T. Ivanov" Subject: Re: [PATCH] mfd: qcom-rpm: Add apq8064 QDSS clock resource Date: Tue, 07 Jul 2015 10:06:44 +0300 Message-ID: <1436252804.21031.4.camel@linaro.org> References: <1431959738-32220-1-git-send-email-ivan.ivanov@linaro.org> <20150706203359.GA20663@sonymobile.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wg0-f43.google.com ([74.125.82.43]:36823 "EHLO mail-wg0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751041AbbGGHGs (ORCPT ); Tue, 7 Jul 2015 03:06:48 -0400 Received: by wgbgr6 with SMTP id gr6so5123568wgb.3 for ; Tue, 07 Jul 2015 00:06:47 -0700 (PDT) In-Reply-To: <20150706203359.GA20663@sonymobile.com> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Bjorn Andersson Cc: Lee Jones , Samuel Ortiz , "linux-kernel@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" On Mon, 2015-07-06 at 13:33 -0700, Bjorn Andersson wrote: > On Mon 18 May 07:35 PDT 2015, Ivan T. Ivanov wrote: > > > Qualcomm Debug Subsystem clock is used by CoreSight components. > > Add required definitions for it. > > > > Signed-off-by: Ivan T. Ivanov ivanov@linaro.org> > > Sorry for the slow response Ivan. > > > --- > > drivers/mfd/qcom_rpm.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/mfd/qcom_rpm.c b/drivers/mfd/qcom_rpm.c > > index eceb34f..313aeae 100644 > > --- a/drivers/mfd/qcom_rpm.c > > +++ b/drivers/mfd/qcom_rpm.c > > @@ -149,6 +149,7 @@ static const struct qcom_rpm_resource apq8064_rpm_resource_table[] = { > > [QCOM_RPM_USB_OTG_SWITCH] ={ 210, 125, 82, 1 }, > > [QCOM_RPM_HDMI_SWITCH] ={ 211, 126, 83, 1 }, > > [QCOM_RPM_DDR_DMM] ={ 212, 127, 84, 2 }, > > + [QCOM_RPM_QDSS_CLK] ={ 214, 129, 7, 1 }, > > 214, 7 and 1 are correct. But as far as I can see in my tables the QDSS > clock doesn't have any status (129 seems to be EBI1_CH0_RANGE). > > The status_id was originally included because I was reading it and I saw > that Srinivas has some code that reads it, but unless it shows to be > useful we should probably just drop that entire column... > > But for now please mark it as -1 or so and we can have a chat with > Srinivas on dropping the column later. Thanks, I was unsure about this. This is just what I have found digging into codeaurora sources. Will change and resubmit. Ivan