linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Ivan T. Ivanov" <ivan.ivanov@linaro.org>
To: Tim Bird <tbird20d@gmail.com>
Cc: Peter Chen <Peter.Chen@freescale.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>
Subject: Re: [PATCH v3] usb: chipidea: Use extcon framework for VBUS and ID detect
Date: Thu, 30 Jul 2015 09:55:31 +0300	[thread overview]
Message-ID: <1438239331.2144.18.camel@linaro.org> (raw)
In-Reply-To: <CA+bK7J7EEh1-G7YYNBhwd2h_R1uAqzXrz0DAMf524ZSc75WfEQ@mail.gmail.com>


On Wed, 2015-07-29 at 12:10 -0700, Tim Bird wrote:
> On Tue, Jun 2, 2015 at 6:14 AM, Ivan T. Ivanov ivanov@linaro.org> wrote:
> > On recent Qualcomm platforms VBUS and ID lines are not routed to
> > USB PHY LINK controller. Use extcon framework to receive connect
> > and disconnect ID and VBUS notification.
> > 
> > Signed-off-by: Ivan T. Ivanov ivanov@linaro.org>
> > ---
> > Changes sice v2 [1].
> > 
> > * Simulate IRQ on extcon event - used to trigger OTG state machine.
> > 
> > I have to admit that I couldn't test complete Chipidea OTG state machine,
> > because my setup is little weird. I am using "qcom,usb-otg-ci" as PHY/OTG
> > provider, "qcom,ehci-host" as host controller driver and "qcom,ci-hdrc" for
> > device role.
> 
> Ivan,
> 
> Do you have patches for the code (presumably pmic code) where the vbus and id
> lines are signaled?  Presumably you've added some extcon_set_cable_state() calls
> somewhere in your source tree, for this to work.  I'm wondering if you
> can share your
> work in progress, or let me know when you plan to push that upstream?
> 

Well, not exactly. Maybe change description is badly worded. 
I have DB410c where VBUS and ID lines are not routed to USB controller, 
but to GPIO. So from the chipidea core driver point of view ID and VBUS
changes/IRQs are triggered from extcon driver "linux,extcon-usb-gpio"

> I'm interested in testing the msm usb code (specifically host mode support)
> on my dragonboard here.
> 

Since yesterday, Felipe kindly merged simple usb-phy driver for 8x16[1].
Which allow just using "qcom,ci-hdrc" and "qcom,usb-8x16-phy" to have
DRD support on 8x16 chipsets. I have tried to use "chipidea,usb2", but 
unfortunately quirks in "qcom,ci-hdrc" are required.

Once we have similar usb-phy drivers for 8x60, 8064, 8074 and 8084,
I believe the we can remove "qcom,usb-otg-xxx" monster. 

usb-phy driver for 8074 should be very similar to 8x16 one.

Regards,
Ivan

[1] http://bit.ly/1U6IjK4

      reply	other threads:[~2015-07-30  6:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-02 13:14 [PATCH v3] usb: chipidea: Use extcon framework for VBUS and ID detect Ivan T. Ivanov
2015-06-05  7:03 ` Peter Chen
2015-06-05  7:37   ` Ivan T. Ivanov
     [not found]     ` <1433489827.6540.0.camel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-06-05  9:26       ` Peter Chen
2015-09-07 11:45         ` Ivan T. Ivanov
     [not found] ` <1433250873-20780-1-git-send-email-ivan.ivanov-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-07-29 19:10   ` Tim Bird
2015-07-30  6:55     ` Ivan T. Ivanov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1438239331.2144.18.camel@linaro.org \
    --to=ivan.ivanov@linaro.org \
    --cc=Peter.Chen@freescale.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=tbird20d@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).