linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Clark <robdclark@gmail.com>
To: dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org
Cc: Bjorn Andersson <bjorn.andersson@sonymobile.com>,
	Stephen Boyd <sboyd@codeaurora.org>,
	Rob Clark <robdclark@gmail.com>
Subject: [PATCH 1/5] qcom-scm: fix endianess issue in __qcom_scm_is_call_available
Date: Mon,  5 Oct 2015 10:22:07 -0400	[thread overview]
Message-ID: <1444054931-2147-2-git-send-email-robdclark@gmail.com> (raw)
In-Reply-To: <1444054931-2147-1-git-send-email-robdclark@gmail.com>

Signed-off-by: Rob Clark <robdclark@gmail.com>
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
---
 drivers/firmware/qcom_scm-32.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/firmware/qcom_scm-32.c b/drivers/firmware/qcom_scm-32.c
index e9c306b..c1e4325 100644
--- a/drivers/firmware/qcom_scm-32.c
+++ b/drivers/firmware/qcom_scm-32.c
@@ -480,15 +480,15 @@ void __qcom_scm_cpu_power_down(u32 flags)
 int __qcom_scm_is_call_available(u32 svc_id, u32 cmd_id)
 {
 	int ret;
-	u32 svc_cmd = (svc_id << 10) | cmd_id;
-	u32 ret_val = 0;
+	__le32 svc_cmd = cpu_to_le32((svc_id << 10) | cmd_id);
+	__le32 ret_val = 0;
 
 	ret = qcom_scm_call(QCOM_SCM_SVC_INFO, QCOM_IS_CALL_AVAIL_CMD, &svc_cmd,
 			sizeof(svc_cmd), &ret_val, sizeof(ret_val));
 	if (ret)
 		return ret;
 
-	return ret_val;
+	return le32_to_cpu(ret_val);
 }
 
 int __qcom_scm_hdcp_req(struct qcom_scm_hdcp_req *req, u32 req_cnt, u32 *resp)
-- 
2.4.3

  reply	other threads:[~2015-10-05 14:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-05 14:22 [PATCH 0/5] qcom-scm fixes and support for OCMEM Rob Clark
2015-10-05 14:22 ` Rob Clark [this message]
2015-10-05 14:22 ` [PATCH 2/5] qcom-scm: fix header compile errors Rob Clark
2015-10-05 14:22 ` [PATCH 3/5] qcom-scm: add missing prototype for qcom_scm_is_available() Rob Clark
2015-10-05 14:22 ` [PATCH 4/5] qcom-scm: add support to restore secure config Rob Clark
2015-10-05 14:29   ` Rob Clark
2015-10-06 23:48     ` [PATCH] " Rob Clark
2015-10-05 14:22 ` [PATCH 5/5] qcom-scm: add OCMEM lock/unlock interface Rob Clark
2015-10-05 15:41   ` Rob Clark
2015-10-06 23:49     ` [PATCH] " Rob Clark

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1444054931-2147-2-git-send-email-robdclark@gmail.com \
    --to=robdclark@gmail.com \
    --cc=bjorn.andersson@sonymobile.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=sboyd@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).