* [PATCH] drivers/spi: spi-qup: report errors on probe failures
@ 2015-10-07 21:47 Jorge Ramirez-Ortiz
2015-10-07 21:47 ` Jorge Ramirez-Ortiz
0 siblings, 1 reply; 2+ messages in thread
From: Jorge Ramirez-Ortiz @ 2015-10-07 21:47 UTC (permalink / raw)
To: jorge.ramirez-ortiz, agross, linux-arm-msm, linux-soc,
srinivas.kandagatla, nicolas.dechesne
Trivial patch to report errors during driver probe.
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] drivers/spi: spi-qup: report errors on probe failures
2015-10-07 21:47 [PATCH] drivers/spi: spi-qup: report errors on probe failures Jorge Ramirez-Ortiz
@ 2015-10-07 21:47 ` Jorge Ramirez-Ortiz
0 siblings, 0 replies; 2+ messages in thread
From: Jorge Ramirez-Ortiz @ 2015-10-07 21:47 UTC (permalink / raw)
To: jorge.ramirez-ortiz, agross, linux-arm-msm, linux-soc,
srinivas.kandagatla, nicolas.dechesne
Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
---
drivers/spi/spi-qup.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/spi/spi-qup.c b/drivers/spi/spi-qup.c
index 810a7fa..01a0f47 100644
--- a/drivers/spi/spi-qup.c
+++ b/drivers/spi/spi-qup.c
@@ -901,8 +901,10 @@ static int spi_qup_probe(struct platform_device *pdev)
ret = devm_request_irq(dev, irq, spi_qup_qup_irq,
IRQF_TRIGGER_HIGH, pdev->name, controller);
- if (ret)
+ if (ret) {
+ dev_err(dev, "failed to request IRQ\n");
goto error_dma;
+ }
pm_runtime_set_autosuspend_delay(dev, MSEC_PER_SEC);
pm_runtime_use_autosuspend(dev);
@@ -910,8 +912,10 @@ static int spi_qup_probe(struct platform_device *pdev)
pm_runtime_enable(dev);
ret = devm_spi_register_master(dev, master);
- if (ret)
+ if (ret) {
+ dev_err(dev, "failed to register controller\n");
goto disable_pm;
+ }
return 0;
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-07 21:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-07 21:47 [PATCH] drivers/spi: spi-qup: report errors on probe failures Jorge Ramirez-Ortiz
2015-10-07 21:47 ` Jorge Ramirez-Ortiz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).