linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
To: jorge.ramirez-ortiz@linaro.org, agross@codeaurora.org,
	linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
	srinivas.kandagatla@linaro.org, nicolas.dechesne@linaro.org
Subject: [PATCH] drivers/spi: spi-qup: report errors on probe failures
Date: Wed,  7 Oct 2015 17:47:49 -0400	[thread overview]
Message-ID: <1444254469-12431-2-git-send-email-jorge.ramirez-ortiz@linaro.org> (raw)
In-Reply-To: <1444254469-12431-1-git-send-email-jorge.ramirez-ortiz@linaro.org>

Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
---
 drivers/spi/spi-qup.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/spi/spi-qup.c b/drivers/spi/spi-qup.c
index 810a7fa..01a0f47 100644
--- a/drivers/spi/spi-qup.c
+++ b/drivers/spi/spi-qup.c
@@ -901,8 +901,10 @@ static int spi_qup_probe(struct platform_device *pdev)
 
 	ret = devm_request_irq(dev, irq, spi_qup_qup_irq,
 			       IRQF_TRIGGER_HIGH, pdev->name, controller);
-	if (ret)
+	if (ret) {
+		dev_err(dev, "failed to request IRQ\n");
 		goto error_dma;
+	}
 
 	pm_runtime_set_autosuspend_delay(dev, MSEC_PER_SEC);
 	pm_runtime_use_autosuspend(dev);
@@ -910,8 +912,10 @@ static int spi_qup_probe(struct platform_device *pdev)
 	pm_runtime_enable(dev);
 
 	ret = devm_spi_register_master(dev, master);
-	if (ret)
+	if (ret) {
+		dev_err(dev, "failed to register controller\n");
 		goto disable_pm;
+	}
 
 	return 0;
 
-- 
2.1.4

      reply	other threads:[~2015-10-07 21:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-07 21:47 [PATCH] drivers/spi: spi-qup: report errors on probe failures Jorge Ramirez-Ortiz
2015-10-07 21:47 ` Jorge Ramirez-Ortiz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1444254469-12431-2-git-send-email-jorge.ramirez-ortiz@linaro.org \
    --to=jorge.ramirez-ortiz@linaro.org \
    --cc=agross@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-soc@vger.kernel.org \
    --cc=nicolas.dechesne@linaro.org \
    --cc=srinivas.kandagatla@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).