From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jorge Ramirez-Ortiz Subject: [PATCH] drivers/spi: spi-qup: report errors on probe failures Date: Wed, 7 Oct 2015 17:47:49 -0400 Message-ID: <1444254469-12431-2-git-send-email-jorge.ramirez-ortiz@linaro.org> References: <1444254469-12431-1-git-send-email-jorge.ramirez-ortiz@linaro.org> Return-path: Received: from mail-qg0-f42.google.com ([209.85.192.42]:34804 "EHLO mail-qg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756537AbbJGVsB (ORCPT ); Wed, 7 Oct 2015 17:48:01 -0400 Received: by qgez77 with SMTP id z77so27040340qge.1 for ; Wed, 07 Oct 2015 14:48:00 -0700 (PDT) In-Reply-To: <1444254469-12431-1-git-send-email-jorge.ramirez-ortiz@linaro.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: jorge.ramirez-ortiz@linaro.org, agross@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, srinivas.kandagatla@linaro.org, nicolas.dechesne@linaro.org Signed-off-by: Jorge Ramirez-Ortiz --- drivers/spi/spi-qup.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-qup.c b/drivers/spi/spi-qup.c index 810a7fa..01a0f47 100644 --- a/drivers/spi/spi-qup.c +++ b/drivers/spi/spi-qup.c @@ -901,8 +901,10 @@ static int spi_qup_probe(struct platform_device *pdev) ret = devm_request_irq(dev, irq, spi_qup_qup_irq, IRQF_TRIGGER_HIGH, pdev->name, controller); - if (ret) + if (ret) { + dev_err(dev, "failed to request IRQ\n"); goto error_dma; + } pm_runtime_set_autosuspend_delay(dev, MSEC_PER_SEC); pm_runtime_use_autosuspend(dev); @@ -910,8 +912,10 @@ static int spi_qup_probe(struct platform_device *pdev) pm_runtime_enable(dev); ret = devm_spi_register_master(dev, master); - if (ret) + if (ret) { + dev_err(dev, "failed to register controller\n"); goto disable_pm; + } return 0; -- 2.1.4