* [PATCH 1/2] dt-bindings: drm/msm: Update bindings for MDP5 @ 2015-10-16 12:06 Archit Taneja 2015-10-16 12:06 ` [PATCH 2/2] arm64: dtsi: Add device nodes for GPU and MDSS on MSM8916 Archit Taneja 2015-10-18 3:19 ` [PATCH 1/2] dt-bindings: drm/msm: Update bindings for MDP5 Bjorn Andersson 0 siblings, 2 replies; 6+ messages in thread From: Archit Taneja @ 2015-10-16 12:06 UTC (permalink / raw) To: agross; +Cc: linux-arm-msm, robdclark, devicetree, Archit Taneja MDP5 has a different compatible string (which causes checkpatch warnings when we try to add MDP5 device nodes). It also has different list of clocks. Update the bindings for MDP5. Signed-off-by: Archit Taneja <architt@codeaurora.org> --- Documentation/devicetree/bindings/drm/msm/mdp.txt | 23 ++++++++++++++++------- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/Documentation/devicetree/bindings/drm/msm/mdp.txt b/Documentation/devicetree/bindings/drm/msm/mdp.txt index 1a0598e..e926daa 100644 --- a/Documentation/devicetree/bindings/drm/msm/mdp.txt +++ b/Documentation/devicetree/bindings/drm/msm/mdp.txt @@ -3,18 +3,27 @@ Qualcomm adreno/snapdragon display controller Required properties: - compatible: * "qcom,mdp" - mdp4 + * "qcom,mdss_mdp" - mdp5 - reg: Physical base address and length of the controller's registers. - interrupts: The interrupt signal from the display controller. - connectors: array of phandles for output device(s) - clocks: device clocks See ../clocks/clock-bindings.txt for details. -- clock-names: the following clocks are required: - * "core_clk" - * "iface_clk" - * "lut_clk" - * "src_clk" - * "hdmi_clk" - * "mpd_clk" +- clock-names: the following clocks are required. + For MDP4: + * "core_clk" + * "iface_clk" + * "lut_clk" + * "src_clk" + * "hdmi_clk" + * "mdp_clk" + For MDP5: + * "bus_clk" + * "iface_clk" + * "core_clk_src" + * "core_clk" + * "lut_clk" (some MDP5 versions may not need this) + * "vsync_clk" Optional properties: - gpus: phandle for gpu device -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] arm64: dtsi: Add device nodes for GPU and MDSS on MSM8916 2015-10-16 12:06 [PATCH 1/2] dt-bindings: drm/msm: Update bindings for MDP5 Archit Taneja @ 2015-10-16 12:06 ` Archit Taneja 2015-10-18 3:19 ` [PATCH 1/2] dt-bindings: drm/msm: Update bindings for MDP5 Bjorn Andersson 1 sibling, 0 replies; 6+ messages in thread From: Archit Taneja @ 2015-10-16 12:06 UTC (permalink / raw) To: agross; +Cc: linux-arm-msm, robdclark, devicetree, Archit Taneja Add device nodes for gpu, mdp and dsi blocks. The gpu and dsi nodes are missing the 'power-domains' property needed for configuring GDSC. This needs to be added when its available. Signed-off-by: Archit Taneja <architt@codeaurora.org> --- arch/arm64/boot/dts/qcom/msm8916.dtsi | 105 ++++++++++++++++++++++++++++++++++ 1 file changed, 105 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi index ac006e8..7807d77 100644 --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi @@ -391,6 +391,111 @@ interrupt-controller; #interrupt-cells = <4>; }; + + gpu: qcom,adreno-3xx@01c00000 { + compatible = "qcom,adreno-3xx"; + #stream-id-cells = <16>; + reg = <0x01c00000 0x20000>; + reg-names = "kgsl_3d0_reg_memory"; + interrupts = <GIC_SPI 33 IRQ_TYPE_NONE>; + interrupt-names = "kgsl_3d0_irq"; + clocks = + <&gcc GCC_OXILI_GFX3D_CLK>, + <&gcc GCC_OXILI_AHB_CLK>, + <&gcc GCC_OXILI_GMEM_CLK>, + <&gcc GCC_BIMC_GFX_CLK>, + <&gcc GCC_BIMC_GPU_CLK>, + <&gcc GFX3D_CLK_SRC>; + clock-names = + "core_clk", + "iface_clk", + "mem_clk", + "mem_iface_clk", + "alt_mem_iface_clk", + "gfx3d_clk_src"; + + qcom,chipid = <0x03000600>; + qcom,gpu-pwrlevels { + compatible = "qcom,gpu-pwrlevels"; + qcom,gpu-pwrlevel@0 { + qcom,gpu-freq = <400000000>; + }; + qcom,gpu-pwrlevel@1 { + qcom,gpu-freq = <19200000>; + }; + }; + }; + + mdss_mdp: qcom,mdss_mdp@1a00000 { + compatible = "qcom,mdss_mdp"; + reg = <0x1a00000 0x90000>, + <0x1ac8000 0x3000>; + reg-names = "mdp_phys", + "vbif_phys"; + interrupts = <GIC_SPI 72 IRQ_TYPE_NONE>; + + interrupt-controller; + #interrupt-cells = <1>; + + connectors = <&mdss_dsi0>; + gpus = <&gpu>; + + clocks = <&gcc GCC_MDSS_AHB_CLK>, + <&gcc GCC_MDSS_AXI_CLK>, + <&gcc MDP_CLK_SRC>, + <&gcc GCC_MDSS_MDP_CLK>, + <&gcc GCC_MDSS_VSYNC_CLK>; + clock-names = "iface_clk", + "bus_clk", + "core_clk_src", + "core_clk", + "vsync_clk"; + }; + + mdss_dsi0: qcom,mdss_dsi@1a98000 { + compatible = "qcom,mdss-dsi-ctrl"; + qcom,dsi-host-index = <0>; + #address-cells = <1>; + #size-cells = <0>; + reg = <0x1a98000 0x25c>; + reg-names = "dsi_ctrl"; + interrupt-parent = <&mdss_mdp>; + interrupts = <4 IRQ_TYPE_NONE>; + + clocks = <&gcc GCC_MDSS_MDP_CLK>, + <&gcc GCC_MDSS_AHB_CLK>, + <&gcc GCC_MDSS_AXI_CLK>, + <&gcc GCC_MDSS_BYTE0_CLK>, + <&gcc GCC_MDSS_PCLK0_CLK>, + <&gcc GCC_MDSS_ESC0_CLK>, + <&gcc BYTE0_CLK_SRC>, + <&gcc PCLK0_CLK_SRC>; + clock-names = "mdp_core_clk", + "iface_clk", + "bus_clk", + "byte_clk", + "pixel_clk", + "core_clk", + "byte_clk_src", + "pixel_clk_src"; + qcom,dsi-phy = <&mdss_dsi_phy0>; + status = "disabled"; + }; + + mdss_dsi_phy0: qcom,mdss_dsi_phy@1a98300 { + compatible = "qcom,dsi-phy-28nm-lp"; + qcom,dsi-phy-index = <0>; + reg = <0x1a98300 0xd4>, + <0x1a98500 0x280>, + <0x1a98780 0x30>; + reg-names = "dsi_pll", + "dsi_phy", + "dsi_phy_regulator"; + + clocks = <&gcc GCC_MDSS_AHB_CLK>; + clock-names = "iface_clk"; + status = "disabled"; + }; }; }; -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: drm/msm: Update bindings for MDP5 2015-10-16 12:06 [PATCH 1/2] dt-bindings: drm/msm: Update bindings for MDP5 Archit Taneja 2015-10-16 12:06 ` [PATCH 2/2] arm64: dtsi: Add device nodes for GPU and MDSS on MSM8916 Archit Taneja @ 2015-10-18 3:19 ` Bjorn Andersson [not found] ` <CAJAp7OhSLFHAdg9POwfhFRU2NmYS8Oc-Zpn8-UCdLfpBWepbdw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 1 sibling, 1 reply; 6+ messages in thread From: Bjorn Andersson @ 2015-10-18 3:19 UTC (permalink / raw) To: Archit Taneja Cc: Andy Gross, linux-arm-msm, Rob Clark, devicetree@vger.kernel.org On Fri, Oct 16, 2015 at 5:06 AM, Archit Taneja <architt@codeaurora.org> wrote: > MDP5 has a different compatible string (which causes checkpatch warnings > when we try to add MDP5 device nodes). It also has different list of > clocks. > > Update the bindings for MDP5. > > Signed-off-by: Archit Taneja <architt@codeaurora.org> > --- > Documentation/devicetree/bindings/drm/msm/mdp.txt | 23 ++++++++++++++++------- > 1 file changed, 16 insertions(+), 7 deletions(-) > > diff --git a/Documentation/devicetree/bindings/drm/msm/mdp.txt b/Documentation/devicetree/bindings/drm/msm/mdp.txt > index 1a0598e..e926daa 100644 > --- a/Documentation/devicetree/bindings/drm/msm/mdp.txt > +++ b/Documentation/devicetree/bindings/drm/msm/mdp.txt > @@ -3,18 +3,27 @@ Qualcomm adreno/snapdragon display controller > Required properties: > - compatible: > * "qcom,mdp" - mdp4 > + * "qcom,mdss_mdp" - mdp5 Wouldn't it be better to name these "qcom,mdp4" and "qcom,mdp5" so that we don't have to rely on some magic detection mechanism to support future versions? Regards, Bjorn ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <CAJAp7OhSLFHAdg9POwfhFRU2NmYS8Oc-Zpn8-UCdLfpBWepbdw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH 1/2] dt-bindings: drm/msm: Update bindings for MDP5 [not found] ` <CAJAp7OhSLFHAdg9POwfhFRU2NmYS8Oc-Zpn8-UCdLfpBWepbdw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2015-10-19 5:49 ` Archit Taneja 2015-10-20 18:17 ` Rob Clark 0 siblings, 1 reply; 6+ messages in thread From: Archit Taneja @ 2015-10-19 5:49 UTC (permalink / raw) To: Bjorn Andersson Cc: Andy Gross, linux-arm-msm, Rob Clark, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On 10/18/2015 08:49 AM, Bjorn Andersson wrote: > On Fri, Oct 16, 2015 at 5:06 AM, Archit Taneja <architt-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> wrote: >> MDP5 has a different compatible string (which causes checkpatch warnings >> when we try to add MDP5 device nodes). It also has different list of >> clocks. >> >> Update the bindings for MDP5. >> >> Signed-off-by: Archit Taneja <architt-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> >> --- >> Documentation/devicetree/bindings/drm/msm/mdp.txt | 23 ++++++++++++++++------- >> 1 file changed, 16 insertions(+), 7 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/drm/msm/mdp.txt b/Documentation/devicetree/bindings/drm/msm/mdp.txt >> index 1a0598e..e926daa 100644 >> --- a/Documentation/devicetree/bindings/drm/msm/mdp.txt >> +++ b/Documentation/devicetree/bindings/drm/msm/mdp.txt >> @@ -3,18 +3,27 @@ Qualcomm adreno/snapdragon display controller >> Required properties: >> - compatible: >> * "qcom,mdp" - mdp4 >> + * "qcom,mdss_mdp" - mdp5 > > Wouldn't it be better to name these "qcom,mdp4" and "qcom,mdp5" so > that we don't have to rely on some magic detection mechanism to > support future versions? My guess is that compatibility string "mdss_mdp" came from the downstream kernels. Chips having MDP4 were supported on downstream kernels that preceded DT. Since we don't have any MDP DT upstream, I think we could go with the string names you suggested. It might break things for people who might try to use an old downstream dts file with a new kernel. But that doesn't sound like the worst thing. Archit > > Regards, > Bjorn > -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: drm/msm: Update bindings for MDP5 2015-10-19 5:49 ` Archit Taneja @ 2015-10-20 18:17 ` Rob Clark 2015-10-23 7:47 ` Archit Taneja 0 siblings, 1 reply; 6+ messages in thread From: Rob Clark @ 2015-10-20 18:17 UTC (permalink / raw) To: Archit Taneja Cc: Bjorn Andersson, Andy Gross, linux-arm-msm, devicetree@vger.kernel.org On Mon, Oct 19, 2015 at 1:49 AM, Archit Taneja <architt@codeaurora.org> wrote: > > On 10/18/2015 08:49 AM, Bjorn Andersson wrote: >> >> On Fri, Oct 16, 2015 at 5:06 AM, Archit Taneja <architt@codeaurora.org> >> wrote: >>> >>> MDP5 has a different compatible string (which causes checkpatch warnings >>> when we try to add MDP5 device nodes). It also has different list of >>> clocks. >>> >>> Update the bindings for MDP5. >>> >>> Signed-off-by: Archit Taneja <architt@codeaurora.org> >>> --- >>> Documentation/devicetree/bindings/drm/msm/mdp.txt | 23 >>> ++++++++++++++++------- >>> 1 file changed, 16 insertions(+), 7 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/drm/msm/mdp.txt >>> b/Documentation/devicetree/bindings/drm/msm/mdp.txt >>> index 1a0598e..e926daa 100644 >>> --- a/Documentation/devicetree/bindings/drm/msm/mdp.txt >>> +++ b/Documentation/devicetree/bindings/drm/msm/mdp.txt >>> @@ -3,18 +3,27 @@ Qualcomm adreno/snapdragon display controller >>> Required properties: >>> - compatible: >>> * "qcom,mdp" - mdp4 >>> + * "qcom,mdss_mdp" - mdp5 >> >> >> Wouldn't it be better to name these "qcom,mdp4" and "qcom,mdp5" so >> that we don't have to rely on some magic detection mechanism to >> support future versions? > > > My guess is that compatibility string "mdss_mdp" came from the > downstream kernels. Chips having MDP4 were supported on downstream > kernels that preceded DT. > > Since we don't have any MDP DT upstream, I think we could go with the > string names you suggested. It might break things for people who might > try to use an old downstream dts file with a new kernel. But that > doesn't sound like the worst thing. it would break things for downstream 3.10/mdp5 dt files.. but what I'd suggest is to make the code look for both qcom,mdp5 and qcom,mdss_mdp but only document the former BR, -R > Archit > >> >> Regards, >> Bjorn >> > > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > hosted by The Linux Foundation ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: drm/msm: Update bindings for MDP5 2015-10-20 18:17 ` Rob Clark @ 2015-10-23 7:47 ` Archit Taneja 0 siblings, 0 replies; 6+ messages in thread From: Archit Taneja @ 2015-10-23 7:47 UTC (permalink / raw) To: Rob Clark Cc: Bjorn Andersson, Andy Gross, linux-arm-msm, devicetree@vger.kernel.org On 10/20/2015 11:47 PM, Rob Clark wrote: > On Mon, Oct 19, 2015 at 1:49 AM, Archit Taneja <architt@codeaurora.org> wrote: >> >> On 10/18/2015 08:49 AM, Bjorn Andersson wrote: >>> >>> On Fri, Oct 16, 2015 at 5:06 AM, Archit Taneja <architt@codeaurora.org> >>> wrote: >>>> >>>> MDP5 has a different compatible string (which causes checkpatch warnings >>>> when we try to add MDP5 device nodes). It also has different list of >>>> clocks. >>>> >>>> Update the bindings for MDP5. >>>> >>>> Signed-off-by: Archit Taneja <architt@codeaurora.org> >>>> --- >>>> Documentation/devicetree/bindings/drm/msm/mdp.txt | 23 >>>> ++++++++++++++++------- >>>> 1 file changed, 16 insertions(+), 7 deletions(-) >>>> >>>> diff --git a/Documentation/devicetree/bindings/drm/msm/mdp.txt >>>> b/Documentation/devicetree/bindings/drm/msm/mdp.txt >>>> index 1a0598e..e926daa 100644 >>>> --- a/Documentation/devicetree/bindings/drm/msm/mdp.txt >>>> +++ b/Documentation/devicetree/bindings/drm/msm/mdp.txt >>>> @@ -3,18 +3,27 @@ Qualcomm adreno/snapdragon display controller >>>> Required properties: >>>> - compatible: >>>> * "qcom,mdp" - mdp4 >>>> + * "qcom,mdss_mdp" - mdp5 >>> >>> >>> Wouldn't it be better to name these "qcom,mdp4" and "qcom,mdp5" so >>> that we don't have to rely on some magic detection mechanism to >>> support future versions? >> >> >> My guess is that compatibility string "mdss_mdp" came from the >> downstream kernels. Chips having MDP4 were supported on downstream >> kernels that preceded DT. >> >> Since we don't have any MDP DT upstream, I think we could go with the >> string names you suggested. It might break things for people who might >> try to use an old downstream dts file with a new kernel. But that >> doesn't sound like the worst thing. > > it would break things for downstream 3.10/mdp5 dt files.. but what > I'd suggest is to make the code look for both qcom,mdp5 and > qcom,mdss_mdp but only document the former That's a good idea. I'll update the patches to do that. Archit > > BR, > -R > >> Archit >> >>> >>> Regards, >>> Bjorn >>> >> >> -- >> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, >> hosted by The Linux Foundation -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-10-23 7:47 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-16 12:06 [PATCH 1/2] dt-bindings: drm/msm: Update bindings for MDP5 Archit Taneja
2015-10-16 12:06 ` [PATCH 2/2] arm64: dtsi: Add device nodes for GPU and MDSS on MSM8916 Archit Taneja
2015-10-18 3:19 ` [PATCH 1/2] dt-bindings: drm/msm: Update bindings for MDP5 Bjorn Andersson
[not found] ` <CAJAp7OhSLFHAdg9POwfhFRU2NmYS8Oc-Zpn8-UCdLfpBWepbdw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-10-19 5:49 ` Archit Taneja
2015-10-20 18:17 ` Rob Clark
2015-10-23 7:47 ` Archit Taneja
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).