From: Bjorn Andersson <bjorn@kryo.se>
To: Ohad Ben-Cohen <ohad@wizery.com>
Cc: fengwei.yin@linaro.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, srinivas.kandagatla@linaro.org
Subject: [PATCH v2 1/4] remoteproc: core: Make the loaded resource table optional
Date: Sun, 27 Dec 2015 17:15:43 -0800 [thread overview]
Message-ID: <1451265346-14969-2-git-send-email-bjorn.andersson@sonymobile.com> (raw)
In-Reply-To: <1451265346-14969-1-git-send-email-bjorn.andersson@sonymobile.com>
Remote processors like the ones found in the Qualcomm SoCs does not have
a resource table passed to them, so make it optional by only populating
it if it does exist.
Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
---
Changes since v1:
- None
drivers/remoteproc/remoteproc_core.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
index 3d7d58a109d8..c04a786dc051 100644
--- a/drivers/remoteproc/remoteproc_core.c
+++ b/drivers/remoteproc/remoteproc_core.c
@@ -856,12 +856,8 @@ static int rproc_fw_boot(struct rproc *rproc, const struct firmware *fw)
* copy this information to device memory.
*/
loaded_table = rproc_find_loaded_rsc_table(rproc, fw);
- if (!loaded_table) {
- ret = -EINVAL;
- goto clean_up;
- }
-
- memcpy(loaded_table, rproc->cached_table, tablesz);
+ if (loaded_table)
+ memcpy(loaded_table, rproc->cached_table, tablesz);
/* power up the remote processor */
ret = rproc->ops->start(rproc);
--
2.5.0
next prev parent reply other threads:[~2015-12-28 1:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-28 1:15 [PATCH v2 0/4] Qualcomm WCNSS Peripheral Image Loader Bjorn Andersson
2015-12-28 1:15 ` Bjorn Andersson [this message]
2015-12-28 1:15 ` [PATCH v2 2/4] remoteproc: Add additional crash reasons Bjorn Andersson
2015-12-28 1:15 ` [PATCH v2 3/4] dt-binding: remoteproc: Introduce Qualcomm WCNSS loader binding Bjorn Andersson
2015-12-29 18:34 ` Rob Herring
2015-12-29 19:09 ` Andy Gross
2015-12-28 1:15 ` [PATCH v2 4/4] remoteproc: qcom: Introduce WCNSS peripheral image loader Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1451265346-14969-2-git-send-email-bjorn.andersson@sonymobile.com \
--to=bjorn@kryo.se \
--cc=fengwei.yin@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox