From: Yaniv Gardi <ygardi@codeaurora.org>
To: robherring2@gmail.com, James.Bottomley@HansenPartnership.com,
pebolle@tiscali.nl, hch@infradead.org
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-arm-msm@vger.kernel.org, santoshsy@gmail.com,
linux-scsi-owner@vger.kernel.org, subhashj@codeaurora.org,
ygardi@codeaurora.org, gbroner@codeaurora.org,
draviv@codeaurora.org, Vinayak Holikatti <vinholikatti@gmail.com>,
"James E.J. Bottomley" <JBottomley@odin.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: [PATCH v7 08/14] scsi: ufs: add retries for hibern8 enter
Date: Mon, 1 Feb 2016 15:02:44 +0200 [thread overview]
Message-ID: <1454331770-29642-9-git-send-email-ygardi@codeaurora.org> (raw)
In-Reply-To: <1454331770-29642-1-git-send-email-ygardi@codeaurora.org>
If hibern8 enter command fails then UFS link state may be unknown which
may result into timeout of all the commands issued after failure.
This change does 2 things (for pre-defined number of retry counts) after
hibern8 enter failure:
1. Recovers the UFS link to active state
2. If link is recovered to active state, tries to put the UFS link in
hibern8 enter again until retry count expires.
Reviewed-by: Gilad Broner <gbroner@codeaurora.org>
Reviewed-by: Dolev Raviv <draviv@codeaurora.org>
Signed-off-by: Subhash Jadavani <subhashj@codeaurora.org>
Signed-off-by: Yaniv Gardi <ygardi@codeaurora.org>
---
drivers/scsi/ufs/ufshcd.c | 26 ++++++++++++++++++++++++--
1 file changed, 24 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 4c0827f..1581d03 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -74,6 +74,9 @@
/* maximum number of link-startup retries */
#define DME_LINKSTARTUP_RETRIES 3
+/* Maximum retries for Hibern8 enter */
+#define UIC_HIBERN8_ENTER_RETRIES 3
+
/* maximum number of reset retries before giving up */
#define MAX_HOST_RESET_RETRIES 5
@@ -2387,13 +2390,32 @@ out:
return ret;
}
-static int ufshcd_uic_hibern8_enter(struct ufs_hba *hba)
+static int __ufshcd_uic_hibern8_enter(struct ufs_hba *hba)
{
+ int ret;
struct uic_command uic_cmd = {0};
uic_cmd.command = UIC_CMD_DME_HIBER_ENTER;
+ ret = ufshcd_uic_pwr_ctrl(hba, &uic_cmd);
+
+ if (ret)
+ dev_err(hba->dev, "%s: hibern8 enter failed. ret = %d\n",
+ __func__, ret);
+
+ return ret;
+}
+
+static int ufshcd_uic_hibern8_enter(struct ufs_hba *hba)
+{
+ int ret = 0, retries;
- return ufshcd_uic_pwr_ctrl(hba, &uic_cmd);
+ for (retries = UIC_HIBERN8_ENTER_RETRIES; retries > 0; retries--) {
+ ret = __ufshcd_uic_hibern8_enter(hba);
+ if (!ret || ret == -ENOLINK)
+ goto out;
+ }
+out:
+ return ret;
}
static int ufshcd_uic_hibern8_exit(struct ufs_hba *hba)
--
1.8.5.2
--
QUALCOMM ISRAEL, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2016-02-01 13:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-01 13:02 [PATCH v7 00/14] Big fixes, retries, handle a race condition Yaniv Gardi
2016-02-01 13:02 ` [PATCH v7 01/14] scsi: ufs: clear UTRD, UPIU req and rsp before new transfers Yaniv Gardi
2016-02-01 13:02 ` [PATCH v7 02/14] scsi: ufs: clear fields " Yaniv Gardi
2016-02-02 10:07 ` Winkler, Tomas
2016-02-01 13:02 ` [PATCH v7 03/14] scsi: ufs: verify command tag validity Yaniv Gardi
2016-02-01 13:02 ` [PATCH v7 04/14] scsi: ufs: clear outstanding_request bit in case query timeout Yaniv Gardi
2016-02-01 13:02 ` [PATCH v7 05/14] scsi: ufs: increase fDeviceInit query response timeout Yaniv Gardi
2016-02-01 13:02 ` [PATCH v7 06/14] scsi: ufs: avoid exception event handler racing with PM callbacks Yaniv Gardi
2016-02-01 13:02 ` [PATCH v7 07/14] scsi: ufs: add retries to dme_peer get and set attribute Yaniv Gardi
2016-02-01 13:02 ` Yaniv Gardi [this message]
2016-02-01 13:02 ` [PATCH v7 09/14] scsi: ufs: fix error recovery after the hibern8 exit failure Yaniv Gardi
2016-02-01 13:02 ` [PATCH v7 10/14] scsi: ufs: retry failed query flag requests Yaniv Gardi
2016-02-01 13:02 ` [PATCH v7 11/14] scsi: ufs: reduce the interrupts for power mode change requests Yaniv Gardi
2016-02-01 13:02 ` [PATCH v7 12/14] scsi: ufs: add missing memory barriers Yaniv Gardi
2016-02-01 13:02 ` [PATCH v7 13/14] scsi: ufs: commit descriptors before setting the doorbell Yaniv Gardi
2016-02-01 13:02 ` [PATCH v7 14/14] scsi: ufs: add wrapper for retrying sending query attribute Yaniv Gardi
2016-02-11 1:48 ` [PATCH v7 00/14] Big fixes, retries, handle a race condition Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454331770-29642-9-git-send-email-ygardi@codeaurora.org \
--to=ygardi@codeaurora.org \
--cc=JBottomley@odin.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=draviv@codeaurora.org \
--cc=gbroner@codeaurora.org \
--cc=hch@infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi-owner@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=pebolle@tiscali.nl \
--cc=robherring2@gmail.com \
--cc=santoshsy@gmail.com \
--cc=subhashj@codeaurora.org \
--cc=vinholikatti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).