From: Yaniv Gardi <ygardi@codeaurora.org>
To: James.Bottomley@HansenPartnership.com
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-arm-msm@vger.kernel.org, santoshsy@gmail.com,
linux-scsi-owner@vger.kernel.org, ygardi@codeaurora.org,
Subhash Jadavani <subhashj@codeaurora.org>,
Vinayak Holikatti <vinholikatti@gmail.com>,
"James E.J. Bottomley" <JBottomley@odin.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: [PATCH v8 13/17] scsi: ufs: fix leakage during link off state
Date: Thu, 10 Mar 2016 17:37:17 +0200 [thread overview]
Message-ID: <1457624241-20525-14-git-send-email-ygardi@codeaurora.org> (raw)
In-Reply-To: <1457624241-20525-1-git-send-email-ygardi@codeaurora.org>
Currently when we try to put the link in off/disabled state during
suspend, it seems link is not being kept in low power mode.
This patch fixes the issue by putting the link in hibern8 first
(so device also puts the link in low power mode) and then stop the
host controller.
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Subhash Jadavani <subhashj@codeaurora.org>
Signed-off-by: Yaniv Gardi <ygardi@codeaurora.org>
---
drivers/scsi/ufs/ufshcd.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 305210f..93cc02f 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -5688,6 +5688,16 @@ static int ufshcd_link_state_transition(struct ufs_hba *hba,
(!check_for_bkops || (check_for_bkops &&
!hba->auto_bkops_enabled))) {
/*
+ * Let's make sure that link is in low power mode, we are doing
+ * this currently by putting the link in Hibern8. Otherway to
+ * put the link in low power mode is to send the DME end point
+ * to device and then send the DME reset command to local
+ * unipro. But putting the link in hibern8 is much faster.
+ */
+ ret = ufshcd_uic_hibern8_enter(hba);
+ if (ret)
+ goto out;
+ /*
* Change controller state to "reset state" which
* should also put the link in off/reset state
*/
--
1.8.5.2
--
QUALCOMM ISRAEL, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2016-03-10 15:37 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-10 15:37 [PATCH v8 00/17] add fixes, device quirks, error recovery, Yaniv Gardi
2016-03-10 15:37 ` [PATCH v8 01/17] scsi: ufs-qcom: add number of lanes per direction Yaniv Gardi
2016-03-10 15:37 ` [PATCH v8 02/17] scsi: ufs: avoid spurious UFS host controller interrupts Yaniv Gardi
2016-03-10 15:37 ` [PATCH v8 03/17] scsi: ufs: implement scsi host timeout handler Yaniv Gardi
2016-03-10 15:37 ` [PATCH v8 04/17] scsi: ufs: verify hba controller hce reg value Yaniv Gardi
2016-03-10 15:37 ` [PATCH v8 05/17] scsi: ufs: add support to read device and string descriptors Yaniv Gardi
2016-03-10 15:37 ` [PATCH v8 06/17] scsi: ufs: separate device and host quirks Yaniv Gardi
2016-03-10 15:37 ` [PATCH v8 07/17] scsi: ufs: disable vccq if it's not needed by UFS device Yaniv Gardi
2016-03-10 15:37 ` [PATCH v8 08/17] scsi: ufs: make error handling bit faster Yaniv Gardi
2016-03-10 15:37 ` [PATCH v8 09/17] scsi: ufs: add error recovery after DL NAC error Yaniv Gardi
2016-03-10 15:37 ` [PATCH v8 10/17] scsi: ufs: add retry for query descriptors Yaniv Gardi
2016-03-10 15:37 ` [PATCH v8 11/17] scsi: ufs: handle non spec compliant bkops behaviour by device Yaniv Gardi
2016-03-10 15:37 ` [PATCH v8 12/17] scsi: ufs: tune UniPro parameters to optimize hibern8 exit time Yaniv Gardi
2016-03-10 15:37 ` Yaniv Gardi [this message]
2016-03-10 15:37 ` [PATCH v8 14/17] scsi: ufs: add device quirk delay before putting UFS rails in LPM Yaniv Gardi
2016-03-10 15:37 ` [PATCH v8 15/17] scsi: ufs-qcom: set PA_Local_TX_LCC_Enable before link startup Yaniv Gardi
2016-03-10 15:37 ` [PATCH v8 16/17] scsi: ufs-qcom: enable/disable the device ref clock Yaniv Gardi
2016-03-10 15:37 ` [PATCH v8 17/17] scsi: ufs-qcom: add printouts of testbus debug registers Yaniv Gardi
2016-03-11 2:36 ` [PATCH v8 00/17] add fixes, device quirks, error recovery, Martin K. Petersen
2016-03-11 8:51 ` Hannes Reinecke
2016-03-14 19:59 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457624241-20525-14-git-send-email-ygardi@codeaurora.org \
--to=ygardi@codeaurora.org \
--cc=JBottomley@odin.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi-owner@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=santoshsy@gmail.com \
--cc=subhashj@codeaurora.org \
--cc=vinholikatti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).