Re: [PATCH] drm: BIT(DRM_ROTATE_?) -> DRM_ROTATE_?

[Joonas Lahtinen <joonas.lahtinen@linux.intel.com>]

On ti, 2016-07-26 at 10:05 +0100, Liviu Dudau wrote:
> > --- a/drivers/gpu/drm/arm/malidp_planes.c
> > +++ b/drivers/gpu/drm/arm/malidp_planes.c
> > @@ -108,7 +108,7 @@ static int malidp_de_plane_check(struct drm_plane *plane,
> >  		return -EINVAL;
> >  
> >  	/* packed RGB888 / BGR888 can't be rotated or flipped */
> > -	if (state->rotation != BIT(DRM_ROTATE_0) &&
> > +	if (state->rotation != DRM_ROTATE_0 &&
> >  	    (state->fb->pixel_format == DRM_FORMAT_RGB888 ||
> >  	     state->fb->pixel_format == DRM_FORMAT_BGR888))
> >  		return -EINVAL;
> > @@ -188,9 +188,9 @@ static void malidp_de_plane_update(struct drm_plane *plane,
> >  	/* setup the rotation and axis flip bits */
> >  	if (plane->state->rotation & DRM_ROTATE_MASK)
> >  		val = ilog2(plane->state->rotation & DRM_ROTATE_MASK) << LAYER_ROT_OFFSET;
> > -	if (plane->state->rotation & BIT(DRM_REFLECT_X))
> > +	if (plane->state->rotation & DRM_REFLECT_X)
> >  		val |= LAYER_V_FLIP;
> > -	if (plane->state->rotation & BIT(DRM_REFLECT_Y))
> > +	if (plane->state->rotation & DRM_REFLECT_Y)
> >  		val |= LAYER_H_FLIP;
> >  
> >  	/* set the 'enable layer' bit */
> > @@ -255,12 +255,12 @@ int malidp_de_planes_init(struct drm_device *drm)
> >  			goto cleanup;
> >  
> >  		if (!drm->mode_config.rotation_property) {
> > -			unsigned long flags = BIT(DRM_ROTATE_0) |
> > -					      BIT(DRM_ROTATE_90) |
> > -					      BIT(DRM_ROTATE_180) |
> > -					      BIT(DRM_ROTATE_270) |
> > -					      BIT(DRM_REFLECT_X) |
> > -					      BIT(DRM_REFLECT_Y);
> > +			unsigned long flags = DRM_ROTATE_0 |
> > +					      DRM_ROTATE_90 |
> > +					      DRM_ROTATE_180 |
> > +					      DRM_ROTATE_270 |
> > +					      DRM_REFLECT_X |
> > +					      DRM_REFLECT_Y;
> >  			drm->mode_config.rotation_property =
> >  				drm_mode_create_rotation_property(drm, flags);
> >  		}
> > @@ -268,7 +268,7 @@ int malidp_de_planes_init(struct drm_device *drm)
> >  		if (drm->mode_config.rotation_property && (id != DE_SMART))
> >  			drm_object_attach_property(&plane->base.base,
> >  						   drm->mode_config.rotation_property,
> > -						   BIT(DRM_ROTATE_0));
> > +						   DRM_ROTATE_0);
> >  
> >  		drm_plane_helper_add(&plane->base,
> >  				     &malidp_de_plane_helper_funcs);
> This patch touches arm/mali-dp driver but the maintainers have not been Cc-ed in the patch? Did
> get_maintainer.pl fail to show our e-mails? (Driver has been added recently, wondering if there
> are issues with MAINTAINERS entry).
> 

Being a mechanical change, I just picked all mailing lists from "open
list" or "maintainer" entries with grep, only adding David and the ones
who I've discussed the intent to do the change with (in the hope they
will review)

But now looking looking, I missed the "supporter" entries and thus your
mailing list. CC'ing the Mali DP mailing list now too.

So my bad, and thanks for notifying.

> The change looks OK to me for mali-dp. So:
> 
> Acked-by: Liviu Dudau <Liviu.Dudau@arm.com>
> 
> (one comment at the end of email as well).
> 
> Best regards,
> Liviu
> 

<SNIP>

> > --- a/include/drm/drm_crtc.h
> > +++ b/include/drm/drm_crtc.h
> > @@ -84,13 +84,13 @@ static inline uint64_t I642U64(int64_t val)
> >   * DRM_REFLECT_Y reflects the image along the specified axis prior to rotation
> >   */
> >  #define DRM_ROTATE_MASK 0x0f
> > -#define DRM_ROTATE_0	0
> > -#define DRM_ROTATE_90	1
> > -#define DRM_ROTATE_180	2
> > -#define DRM_ROTATE_270	3
> > +#define DRM_ROTATE_0	BIT(0)
> This seems not to be indented properly?

This is result of being in patch form where '+'/' '/'-' is being added
to the beginning of line before the tab, so the spacing might be off.
When applied, the code is indented properly.

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation