From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joonas Lahtinen Subject: Re: [PATCH] drm: BIT(DRM_ROTATE_?) -> DRM_ROTATE_? Date: Tue, 26 Jul 2016 14:53:17 +0300 Message-ID: <1469533997.4681.79.camel@linux.intel.com> References: <1469430025-13540-1-git-send-email-joonas.lahtinen@linux.intel.com> <20160726090557.GB8609@e106497-lin.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mga03.intel.com ([134.134.136.65]:17185 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753799AbcGZLxW (ORCPT ); Tue, 26 Jul 2016 07:53:22 -0400 In-Reply-To: <20160726090557.GB8609@e106497-lin.cambridge.arm.com> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Liviu Dudau Cc: Direct Rendering Infrastructure - Development , linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, Daniel Vetter , freedreno@lists.freedesktop.org, Mali DP Maintainers On ti, 2016-07-26 at 10:05 +0100, Liviu Dudau wrote: > > --- a/drivers/gpu/drm/arm/malidp_planes.c > > +++ b/drivers/gpu/drm/arm/malidp_planes.c > > @@ -108,7 +108,7 @@ static int malidp_de_plane_check(struct drm_pla= ne *plane, > > =C2=A0 return -EINVAL; > > =C2=A0 > > =C2=A0 /* packed RGB888 / BGR888 can't be rotated or flipped */ > > - if (state->rotation !=3D BIT(DRM_ROTATE_0) && > > + if (state->rotation !=3D DRM_ROTATE_0 && > > =C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0(state->fb->pixel_format =3D=3D DRM_= =46ORMAT_RGB888 || > > =C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0state->fb->pixel_format =3D=3D= DRM_FORMAT_BGR888)) > > =C2=A0 return -EINVAL; > > @@ -188,9 +188,9 @@ static void malidp_de_plane_update(struct drm_p= lane *plane, > > =C2=A0 /* setup the rotation and axis flip bits */ > > =C2=A0 if (plane->state->rotation & DRM_ROTATE_MASK) > > =C2=A0 val =3D ilog2(plane->state->rotation & DRM_ROTATE_MASK) << = LAYER_ROT_OFFSET; > > - if (plane->state->rotation & BIT(DRM_REFLECT_X)) > > + if (plane->state->rotation & DRM_REFLECT_X) > > =C2=A0 val |=3D LAYER_V_FLIP; > > - if (plane->state->rotation & BIT(DRM_REFLECT_Y)) > > + if (plane->state->rotation & DRM_REFLECT_Y) > > =C2=A0 val |=3D LAYER_H_FLIP; > > =C2=A0 > > =C2=A0 /* set the 'enable layer' bit */ > > @@ -255,12 +255,12 @@ int malidp_de_planes_init(struct drm_device *= drm) > > =C2=A0 goto cleanup; > > =C2=A0 > > =C2=A0 if (!drm->mode_config.rotation_property) { > > - unsigned long flags =3D BIT(DRM_ROTATE_0) | > > - =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0BIT(DRM_ROTATE_90) | > > - =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0BIT(DRM_ROTATE_180) | > > - =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0BIT(DRM_ROTATE_270) | > > - =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0BIT(DRM_REFLECT_X) | > > - =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0BIT(DRM_REFLECT_Y); > > + unsigned long flags =3D DRM_ROTATE_0 | > > + =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0DRM_ROTATE_90 | > > + =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0DRM_ROTATE_180 | > > + =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0DRM_ROTATE_270 | > > + =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0DRM_REFLECT_X | > > + =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0DRM_REFLECT_Y; > > =C2=A0 drm->mode_config.rotation_property =3D > > =C2=A0 drm_mode_create_rotation_property(drm, flags); > > =C2=A0 } > > @@ -268,7 +268,7 @@ int malidp_de_planes_init(struct drm_device *dr= m) > > =C2=A0 if (drm->mode_config.rotation_property && (id !=3D DE_SMART= )) > > =C2=A0 drm_object_attach_property(&plane->base.base, > > =C2=A0 =C2=A0=C2=A0=C2=A0drm->mode_config.rotation_property, > > - =C2=A0=C2=A0=C2=A0BIT(DRM_ROTATE_0)); > > + =C2=A0=C2=A0=C2=A0DRM_ROTATE_0); > > =C2=A0 > > =C2=A0 drm_plane_helper_add(&plane->base, > > =C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0&malidp_de_plane_helper_fun= cs); > This patch touches arm/mali-dp driver but the maintainers have not be= en Cc-ed in the patch? Did > get_maintainer.pl fail to show our e-mails? (Driver has been added re= cently, wondering if there > are issues with MAINTAINERS entry). >=20 Being a mechanical change, I just picked all mailing lists from "open list" or "maintainer" entries with grep, only adding David and the ones who I've discussed the intent to do the change with=C2=A0(in the hope t= hey will review) But now looking looking, I missed the "supporter" entries and thus your mailing list. CC'ing the Mali DP mailing list now too. So my bad, and thanks for notifying. > The change looks OK to me for mali-dp. So: >=20 > Acked-by: Liviu Dudau >=20 > (one comment at the end of email as well). >=20 > Best regards, > Liviu >=20 > > --- a/include/drm/drm_crtc.h > > +++ b/include/drm/drm_crtc.h > > @@ -84,13 +84,13 @@ static inline uint64_t I642U64(int64_t val) > > =C2=A0 * DRM_REFLECT_Y reflects the image along the specified axis = prior to rotation > > =C2=A0 */ > > =C2=A0#define DRM_ROTATE_MASK 0x0f > > -#define DRM_ROTATE_0 0 > > -#define DRM_ROTATE_90 1 > > -#define DRM_ROTATE_180 2 > > -#define DRM_ROTATE_270 3 > > +#define DRM_ROTATE_0 BIT(0) > This seems not to be indented properly? This is result of being in patch form where '+'/' '/'-' is being added to the beginning of line before the tab, so the spacing might be off. When applied, the code is indented properly. Regards, Joonas --=20 Joonas Lahtinen Open Source Technology Center Intel Corporation