From: Sinan Kaya <okaya@codeaurora.org>
To: dmaengine@vger.kernel.org, timur@codeaurora.org,
cov@codeaurora.org, vinod.koul@intel.com, jcm@redhat.com
Cc: agross@codeaurora.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Sinan Kaya <okaya@codeaurora.org>
Subject: [PATCH V3 0/3] dmaengine: qcom_hidma: add error reporting
Date: Tue, 23 Aug 2016 00:48:08 -0400 [thread overview]
Message-ID: <1471927691-28827-1-git-send-email-okaya@codeaurora.org> (raw)
Three changes:
1. There is a race condition between data transfer callback and descriptor
free code. The callback routine may decide to clear the resources even
though the descriptor has not yet been freed.
2. DMA Engine framework now supports direct error reporting to the client
via the callback.
Pass the DMA errors to the client by passing a result argument. The HW only
supports a generic error when something goes wrong. That's why, using
DMA_TRANS_ABORTED all the time.
3. The HIDMA driver is capable of error detection. However, the error was
not being passed back to the client when tx_status API is called.
------------------------
Changes from v2 (https://patchwork.kernel.org/patch/9253379/)
------------------------
- Implement the error passing to the client.
- Get rid of the reset in the interrupt handler when an error happens and
put the HW into disabled state. The only way to recover is for the client to
terminate the channel.
Sinan Kaya (3):
dmaengine: qcom_hidma: release the descriptor before the callback
dmaengine: qcom_hidma: report transfer errors with new interface
dmaengine: qcom_hidma: add error reporting for tx_status
drivers/dma/qcom/hidma.c | 50 +++++++++++++++++++++++++++++++++++----------
drivers/dma/qcom/hidma.h | 1 +
drivers/dma/qcom/hidma_ll.c | 32 +++++++----------------------
3 files changed, 47 insertions(+), 36 deletions(-)
--
1.8.2.1
next reply other threads:[~2016-08-23 4:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-23 4:48 Sinan Kaya [this message]
2016-08-23 4:48 ` [PATCH V3 1/3] dmaengine: qcom_hidma: release the descriptor before the callback Sinan Kaya
2016-08-23 4:48 ` [PATCH V3 2/3] dmaengine: qcom_hidma: report transfer errors with new interface Sinan Kaya
2016-08-23 4:48 ` [PATCH V3 3/3] dmaengine: qcom_hidma: add error reporting for tx_status Sinan Kaya
2016-08-30 17:04 ` Vinod Koul
2016-08-30 17:37 ` Sinan Kaya
2016-08-30 17:51 ` Sinan Kaya
2016-08-31 4:21 ` Vinod Koul
2016-08-29 15:30 ` [PATCH V3 0/3] dmaengine: qcom_hidma: add error reporting Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471927691-28827-1-git-send-email-okaya@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=agross@codeaurora.org \
--cc=cov@codeaurora.org \
--cc=dmaengine@vger.kernel.org \
--cc=jcm@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=timur@codeaurora.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).