From: Avaneesh Kumar Dwivedi <akdwived@codeaurora.org>
To: bjorn.andersson@linaro.org
Cc: sboyd@codeaurora.org, agross@codeaurora.org,
linux-arm-msm@vger.kernel.org,
Avaneesh Kumar Dwivedi <akdwived@codeaurora.org>
Subject: [PATCH v4 05/10] remoteproc: qcom: Separate out regulator disable routine in two
Date: Wed, 16 Nov 2016 22:31:31 +0530 [thread overview]
Message-ID: <1479315696-15490-6-git-send-email-akdwived@codeaurora.org> (raw)
In-Reply-To: <1479315696-15490-1-git-send-email-akdwived@codeaurora.org>
It is needed that one disable proxy regulators when handover interrupt
is received from mss subsystem while on certain chip there are few
regulator which are never disabled. So separating out disable interface
in two separate routine.
Signed-off-by: Avaneesh Kumar Dwivedi <akdwived@codeaurora.org>
---
drivers/remoteproc/qcom_q6v5_pil.c | 36 +++++++++++++++++++++++++++++++++++-
1 file changed, 35 insertions(+), 1 deletion(-)
diff --git a/drivers/remoteproc/qcom_q6v5_pil.c b/drivers/remoteproc/qcom_q6v5_pil.c
index 8843605..57c67e1 100644
--- a/drivers/remoteproc/qcom_q6v5_pil.c
+++ b/drivers/remoteproc/qcom_q6v5_pil.c
@@ -255,8 +255,42 @@ static int q6v5_regulator_enable(struct q6v5 *qproc,
return rc;
}
+static void q6v5_proxy_regulator_disable(struct q6v5 *qproc)
+{
+ int i;
+ struct reg_info *regs = qproc->proxy_regs;
+
+ for (i = 0; i < qproc->proxy_reg_count; i++) {
+ if (regs[i].uV > 0)
+ regulator_set_voltage(regs[i].reg, 0, INT_MAX);
+
+ if (regs[i].uA > 0)
+ regulator_set_load(regs[i].reg, 0);
+
+ regulator_disable(regs[i].reg);
+ }
+}
+
+static void q6v5_active_regulator_disable(struct q6v5 *qproc)
+{
+ int i;
+ struct reg_info *regs = qproc->active_regs;
+
+ for (i = 0; i < qproc->active_reg_count; i++) {
+ if (regs[i].uV > 0)
+ regulator_set_voltage(regs[i].reg, 0, INT_MAX);
+
+ if (regs[i].uA > 0)
+ regulator_set_load(regs[i].reg, 0);
+
+ regulator_disable(regs[i].reg);
+ }
+}
+
static void q6v5_regulator_disable(struct q6v5 *qproc)
{
+ q6v5_proxy_regulator_disable(qproc);
+ q6v5_active_regulator_disable(qproc);
}
static int q6v5_load(struct rproc *rproc, const struct firmware *fw)
@@ -629,7 +663,7 @@ static int q6v5_start(struct rproc *rproc)
assert_reset:
reset_control_assert(qproc->mss_restart);
disable_vdd:
- q6v5_regulator_disable(qproc);
+ q6v5_active_regulator_disable(qproc);
disable_proxy_clk:
return ret;
}
--
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2016-11-16 17:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-16 17:01 [PATCH v4 00/10]remoteproc: qcom: Add support to hexagon q6v56 in qcom hexagon rproc driver Avaneesh Kumar Dwivedi
2016-11-16 17:01 ` [PATCH v4 01/10] remoteproc: qcom: Add and initialize private data for hexagon dsp Avaneesh Kumar Dwivedi
2016-11-16 17:01 ` [PATCH v4 02/10] remoteproc: qcom: Initialize MSS reset control handle Avaneesh Kumar Dwivedi
2016-11-16 17:01 ` [PATCH v4 03/10] remoteproc: qcom: Initialize clock and regulator handle with private data Avaneesh Kumar Dwivedi
2016-11-16 17:01 ` [PATCH v4 04/10] remoteproc: qcom: Modify regulator enable and disable interface Avaneesh Kumar Dwivedi
2016-11-16 17:01 ` Avaneesh Kumar Dwivedi [this message]
2016-11-16 17:01 ` [PATCH v4 06/10] remoteproc: qcom: Modify clock enable and disable routine Avaneesh Kumar Dwivedi
2016-11-16 17:01 ` [PATCH v4 07/10] remoteproc: qcom: Add new routine for mss restart programming Avaneesh Kumar Dwivedi
2016-11-16 17:01 ` [PATCH v4 08/10] remoteproc: qcom: Modify reset sequence for hexagon to support q6v56 Avaneesh Kumar Dwivedi
2016-11-16 17:01 ` [PATCH v4 09/10] remoteproc: qcom: Modify stop routine for q6v56 specific step Avaneesh Kumar Dwivedi
2016-11-16 17:01 ` [PATCH v4 10/10] remoteproc: qcom: Adding required initialization for q6v5 hexagon Avaneesh Kumar Dwivedi
2016-11-16 23:03 ` [PATCH v4 00/10]remoteproc: qcom: Add support to hexagon q6v56 in qcom hexagon rproc driver Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1479315696-15490-6-git-send-email-akdwived@codeaurora.org \
--to=akdwived@codeaurora.org \
--cc=agross@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).