From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ritesh Harjani Subject: [RESEND RFC 3/3] mmc: sdhci: Add more debug info in case of data error Date: Tue, 10 Jan 2017 12:11:55 +0530 Message-ID: <1484030515-16722-4-git-send-email-riteshh@codeaurora.org> References: <1484030515-16722-1-git-send-email-riteshh@codeaurora.org> Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:41792 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757043AbdAJGmn (ORCPT ); Tue, 10 Jan 2017 01:42:43 -0500 In-Reply-To: <1484030515-16722-1-git-send-email-riteshh@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: adrian.hunter@intel.com, ulf.hansson@linaro.org Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, shawn.lin@rock-chips.com, linux-arm-msm@vger.kernel.org, georgi.djakov@linaro.org, asutoshd@codeaurora.org, stummala@codeaurora.org, venkatg@codeaurora.org, pramod.gurav@linaro.org, jeremymc@redhat.com, Ritesh Harjani print error log message and dump sdhc registers for debugging purpose in case of data errors (except when tuning commands generate CRC/timeout/end bit errors). Signed-off-by: Ritesh Harjani Signed-off-by: Asutosh Das --- drivers/mmc/host/sdhci.c | 21 +++++++++++++++++++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index 73a8918..2e51e49 100644 --- a/drivers/mmc/host/sdhci.c +++ b/drivers/mmc/host/sdhci.c @@ -2616,9 +2616,26 @@ static void sdhci_data_irq(struct sdhci_host *host, u32 intmask) host->ops->adma_workaround(host, intmask); } - if (host->data->error) + if (host->data->error) { + bool pr_msg = true; + + if (intmask & (SDHCI_INT_DATA_CRC | SDHCI_INT_DATA_TIMEOUT | + SDHCI_INT_DATA_END_BIT)) { + command = SDHCI_GET_CMD(sdhci_readw(host, + SDHCI_COMMAND)); + if (command == MMC_SEND_TUNING_BLOCK_HS200 || + command == MMC_SEND_TUNING_BLOCK) + pr_msg = false; + } + if (pr_msg) { + pr_err("%s: data txfr (0x%08x) error: %d\n", + mmc_hostname(host->mmc), intmask, + host->data->error); + sdhci_dumpregs(host); + } + sdhci_finish_data(host); - else { + } else { if (intmask & (SDHCI_INT_DATA_AVAIL | SDHCI_INT_SPACE_AVAIL)) sdhci_transfer_pio(host); -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.