From: Vivek Gautam <vivek.gautam@codeaurora.org>
To: p.zabel@pengutronix.de, swarren@wwwdotorg.org, balbi@kernel.org
Cc: linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-usb@vger.kernel.org, thierry.reding@gmail.com,
gregkh@linuxfoundation.org, linux-arm-msm@vger.kernel.org,
Vivek Gautam <vivek.gautam@codeaurora.org>
Subject: [PATCH V3 2/4] reset: Add APIs to manage array of resets
Date: Tue, 18 Apr 2017 16:51:26 +0530 [thread overview]
Message-ID: <1492514488-27385-3-git-send-email-vivek.gautam@codeaurora.org> (raw)
In-Reply-To: <1492514488-27385-1-git-send-email-vivek.gautam@codeaurora.org>
Many devices may want to request a bunch of resets
and control them. So it's better to manage them as an
array. Add APIs to _get(), _assert(), and _deassert()
an array of reset_control.
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org>
---
drivers/reset/core.c | 177 ++++++++++++++++++++++++++++++++++++++++++++++++++
include/linux/reset.h | 93 ++++++++++++++++++++++++++
2 files changed, 270 insertions(+)
diff --git a/drivers/reset/core.c b/drivers/reset/core.c
index f0a06a7aca93..54bd3be5e7a4 100644
--- a/drivers/reset/core.c
+++ b/drivers/reset/core.c
@@ -488,3 +488,180 @@ int of_reset_control_get_count(struct device_node *node)
return count;
}
EXPORT_SYMBOL_GPL(of_reset_control_get_count);
+
+/**
+ * APIs to manage an array of reset controls.
+ */
+/**
+ * reset_control_array_assert: assert a list of resets
+ *
+ * @resets: reset control array holding info about the list of resets
+ *
+ * This API doesn't guarantee that the reset lines controlled by
+ * the reset array are asserted in any particular order.
+ *
+ * Returns 0 on success or error number on failure.
+ */
+int reset_control_array_assert(struct reset_control_array *resets)
+{
+ int ret, i;
+
+ if (!resets)
+ return 0;
+
+ if (IS_ERR(resets))
+ return -EINVAL;
+
+ for (i = 0; i < resets->num_rstcs; i++) {
+ ret = reset_control_assert(resets->rstc[i]);
+ if (ret)
+ return ret;
+ }
+
+ return 0;
+}
+EXPORT_SYMBOL_GPL(reset_control_array_assert);
+
+/**
+ * reset_control_array_deassert: deassert a list of resets
+ *
+ * @resets: reset control array holding info about the list of resets
+ *
+ * This API doesn't guarantee that the reset lines controlled by
+ * the reset array are deasserted in any particular order.
+ *
+ * Returns 0 on success or error number on failure.
+ */
+int reset_control_array_deassert(struct reset_control_array *resets)
+{
+ int ret, i;
+
+ if (!resets)
+ return 0;
+
+ if (IS_ERR(resets))
+ return -EINVAL;
+
+ for (i = 0; i < resets->num_rstcs; i++) {
+ ret = reset_control_deassert(resets->rstc[i]);
+ if (ret)
+ goto err;
+ }
+
+ return 0;
+
+err:
+ while (i--)
+ reset_control_assert(resets->rstc[i]);
+ return ret;
+}
+EXPORT_SYMBOL_GPL(reset_control_array_deassert);
+
+static void devm_reset_control_array_release(struct device *dev, void *res)
+{
+ struct reset_control_array *resets = res;
+
+ reset_control_array_put(resets);
+}
+
+/**
+ * of_reset_control_array_get - Get a list of reset controls using
+ * device node.
+ *
+ * @np: device node for the device that requests the reset controls array
+ * @shared: whether reset controls are shared or not
+ * @optional: whether it is optional to get the reset controls
+ *
+ * Returns pointer to allocated reset_control_array on success or
+ * error on failure
+ */
+struct reset_control_array *
+of_reset_control_array_get(struct device_node *np, bool shared, bool optional)
+{
+ struct reset_control_array *resets;
+ struct reset_control *rstc;
+ int num, i;
+ void *err;
+
+ num = of_reset_control_get_count(np);
+ if (num < 0)
+ return ERR_PTR(num);
+
+ resets = kzalloc(sizeof(*resets) + sizeof(resets->rstc[0]) * num,
+ GFP_KERNEL);
+ if (!resets)
+ return ERR_PTR(-ENOMEM);
+
+ for (i = 0; i < num; i++) {
+ rstc = __of_reset_control_get(np, NULL, i, shared, optional);
+ if (IS_ERR(rstc)) {
+ err = ERR_CAST(rstc);
+ goto err_rst;
+ }
+ resets->rstc[i] = rstc;
+ }
+ resets->num_rstcs = num;
+
+ return resets;
+
+err_rst:
+ while (--i >= 0)
+ reset_control_put(resets->rstc[i]);
+
+ kfree(resets);
+
+ return err;
+}
+EXPORT_SYMBOL_GPL(of_reset_control_array_get);
+
+/**
+ * devm_reset_control_array_get - Resource managed reset control array get
+ *
+ * @dev: device that requests the list of reset controls
+ * @shared: whether reset controls are shared or not
+ * @optional: whether it is optional to get the reset controls
+ *
+ * The reset control array APIs are intended for a list of resets
+ * that just have to be asserted or deasserted, without any
+ * requirements on the order.
+ *
+ * Returns pointer to allocated reset_control_array on success or
+ * error on failure
+ */
+struct reset_control_array *
+devm_reset_control_array_get(struct device *dev, bool shared, bool optional)
+{
+ struct reset_control_array **devres;
+ struct reset_control_array *resets;
+
+ devres = devres_alloc(devm_reset_control_array_release,
+ sizeof(*devres), GFP_KERNEL);
+ if (!devres)
+ return ERR_PTR(-ENOMEM);
+
+ resets = of_reset_control_array_get(dev->of_node, shared, optional);
+ if (IS_ERR(resets)) {
+ devres_free(resets);
+ return resets;
+ }
+
+ *devres = resets;
+ devres_add(dev, devres);
+
+ return resets;
+}
+EXPORT_SYMBOL_GPL(devm_reset_control_array_get);
+
+void reset_control_array_put(struct reset_control_array *resets)
+{
+ int i;
+
+ if (IS_ERR_OR_NULL(resets))
+ return;
+
+ for (i = 0; i < resets->num_rstcs; i++)
+ reset_control_put(resets->rstc[i]);
+
+ kfree(resets);
+}
+EXPORT_SYMBOL_GPL(reset_control_array_put);
diff --git a/include/linux/reset.h b/include/linux/reset.h
index 1b5a6aafd3e6..8edb69e93355 100644
--- a/include/linux/reset.h
+++ b/include/linux/reset.h
@@ -5,6 +5,11 @@
struct reset_control;
+struct reset_control_array {
+ unsigned int num_rstcs;
+ struct reset_control *rstc[];
+};
+
#ifdef CONFIG_RESET_CONTROLLER
int reset_control_reset(struct reset_control *rstc);
@@ -26,6 +31,14 @@ struct reset_control *__devm_reset_control_get(struct device *dev,
int __must_check device_reset(struct device *dev);
int of_reset_control_get_count(struct device_node *node);
+int reset_control_array_assert(struct reset_control_array *resets);
+int reset_control_array_deassert(struct reset_control_array *resets);
+struct reset_control_array *devm_reset_control_array_get(struct device *dev,
+ bool shared, bool optional);
+struct reset_control_array *of_reset_control_array_get(struct device_node *np,
+ bool shared, bool optional);
+void reset_control_array_put(struct reset_control_array *resets);
+
static inline int device_reset_optional(struct device *dev)
{
return device_reset(dev);
@@ -95,6 +108,35 @@ static inline int of_reset_control_get_count(struct device_node *node)
return -ENOTSUPP;
}
+static inline
+int reset_control_array_assert(struct reset_control_array *resets)
+{
+ return 0;
+}
+
+static inline
+int reset_control_array_deassert(struct reset_control_array *resets)
+{
+ return 0;
+}
+
+static inline struct reset_control_array *
+devm_reset_control_array_get(struct device *dev, bool shared, bool optional)
+{
+ return optional ? NULL : ERR_PTR(-ENOTSUPP);
+}
+
+static inline struct reset_control_array *
+of_reset_control_array_get(struct device_node *np, bool shared, bool optional)
+{
+ return optional ? NULL : ERR_PTR(-ENOTSUPP);
+}
+
+static inline
+void reset_control_array_put(struct reset_control_array *resets)
+{
+}
+
#endif /* CONFIG_RESET_CONTROLLER */
/**
@@ -380,4 +422,55 @@ static inline struct reset_control *devm_reset_control_get_by_index(
{
return devm_reset_control_get_exclusive_by_index(dev, index);
}
+
+/*
+ * APIs to manage a list of reset controllers
+ */
+static inline struct reset_control_array *
+devm_reset_control_array_get_exclusive(struct device *dev)
+{
+ return devm_reset_control_array_get(dev, false, false);
+}
+
+static inline struct reset_control_array *
+devm_reset_control_array_get_shared(struct device *dev)
+{
+ return devm_reset_control_array_get(dev, true, false);
+}
+
+static inline struct reset_control_array *
+devm_reset_control_array_get_optional_exclusive(struct device *dev)
+{
+ return devm_reset_control_array_get(dev, false, true);
+}
+
+static inline struct reset_control_array *
+devm_reset_control_array_get_optional_shared(struct device *dev)
+{
+ return devm_reset_control_array_get(dev, true, true);
+}
+
+static inline struct reset_control_array *
+of_reset_control_array_get_exclusive(struct device_node *node)
+{
+ return of_reset_control_array_get(node, false, false);
+}
+
+static inline struct reset_control_array *
+of_reset_control_array_get_shared(struct device_node *node)
+{
+ return of_reset_control_array_get(node, true, false);
+}
+
+static inline struct reset_control_array *
+of_reset_control_array_get_optional_exclusive(struct device_node *node)
+{
+ return of_reset_control_array_get(node, false, true);
+}
+
+static inline struct reset_control_array *
+of_reset_control_array_get_optional_shared(struct device_node *node)
+{
+ return of_reset_control_array_get(node, true, true);
+}
#endif
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2017-04-18 11:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-18 11:21 [PATCH V3 0/4] reset: APIs to manage a list of resets Vivek Gautam
2017-04-18 11:21 ` [PATCH V3 1/4] reset: Add API to count number of reset available with device Vivek Gautam
[not found] ` <1492514488-27385-2-git-send-email-vivek.gautam-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-04-19 10:25 ` Philipp Zabel
[not found] ` <1492597532.2970.61.camel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2017-04-19 11:49 ` Vivek Gautam
2017-04-18 11:21 ` Vivek Gautam [this message]
2017-04-19 10:31 ` [PATCH V3 2/4] reset: Add APIs to manage array of resets Philipp Zabel
[not found] ` <1492597912.2970.65.camel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2017-04-19 11:55 ` Vivek Gautam
2017-04-18 11:21 ` [PATCH V3 3/4] usb: dwc3: of-simple: Add support to get resets for the device Vivek Gautam
[not found] ` <1492514488-27385-4-git-send-email-vivek.gautam-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-04-19 10:32 ` Philipp Zabel
2017-04-19 12:02 ` Vivek Gautam
2017-04-18 11:21 ` [PATCH V3 4/4] soc/tegra: pmc: Use the new reset APIs to manage reset controllers Vivek Gautam
2017-04-19 10:40 ` Philipp Zabel
[not found] ` <1492514488-27385-5-git-send-email-vivek.gautam-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-04-24 12:45 ` Jon Hunter
2017-04-25 4:15 ` Vivek Gautam
[not found] ` <afcddcbe-7086-2739-6de2-84f5c1d34374-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-04-25 10:05 ` Jon Hunter
[not found] ` <b3f2cbe5-4a1a-2f7b-2e4a-6a06eeadc890-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2017-04-25 10:33 ` Philipp Zabel
2017-04-25 10:54 ` Jon Hunter
[not found] ` <afdb02e5-9299-fec9-9451-8271c220744b-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2017-04-25 11:06 ` Vivek Gautam
[not found] ` <5e0c2030-ad96-15fc-1dc4-db6cd11d52c3-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-04-25 11:11 ` Jon Hunter
[not found] ` <ff663727-dcdf-b3e7-616d-5e770d32d782-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2017-04-25 17:50 ` Vivek Gautam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1492514488-27385-3-git-send-email-vivek.gautam@codeaurora.org \
--to=vivek.gautam@codeaurora.org \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).