From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tirupathi Reddy Subject: [PATCH V1] regulator: core: Fix voltage change propagations to supply regulators Date: Thu, 25 May 2017 15:33:17 +0530 Message-ID: <1495706597-10605-1-git-send-email-tirupath@codeaurora.org> Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:54550 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1032114AbdEYKDc (ORCPT ); Thu, 25 May 2017 06:03:32 -0400 Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: broonie@kernel.org, lgirdwood@gmail.com Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Tirupathi Reddy Some regulators support get_voltage and some support get_voltage_sel operations. Do voltage change propagation only when the current regulator has a minimum dropout voltage specified or if the current regulator lacks both get_voltage and get_voltage_sel operations. Signed-off-by: Tirupathi Reddy --- drivers/regulator/core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index c0d9ae8..9fecbd4 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -2938,7 +2938,8 @@ static int regulator_set_voltage_unlocked(struct regulator *regulator, if (rdev->supply && regulator_ops_is_valid(rdev->supply->rdev, REGULATOR_CHANGE_VOLTAGE) && - (rdev->desc->min_dropout_uV || !rdev->desc->ops->get_voltage)) { + (rdev->desc->min_dropout_uV || !(rdev->desc->ops->get_voltage || + rdev->desc->ops->get_voltage_sel))) { int current_supply_uV; int selector; -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation