linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Philipp Zabel <p.zabel@pengutronix.de>
To: Vivek Gautam <vivek.gautam@codeaurora.org>
Cc: linux-kernel@vger.kernel.org, Jon Hunter <jonathanh@nvidia.com>,
	Felipe Balbi <balbi@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Thierry Reding <treding@nvidia.com>,
	linux-tegra@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v5 3/6] reset: hide reset control arrays behind struct reset_control
Date: Mon, 19 Jun 2017 14:18:33 +0200	[thread overview]
Message-ID: <1497874713.2993.70.camel@pengutronix.de> (raw)
In-Reply-To: <c15af5af-3b30-07eb-52c8-af0aff87f3b4@codeaurora.org>

Hi Vivek,

On Tue, 2017-06-13 at 12:16 +0530, Vivek Gautam wrote:
[...]
> > @@ -102,18 +94,6 @@ static inline struct reset_control *__devm_reset_control_get(
> >   	return optional ? NULL : ERR_PTR(-ENOTSUPP);
> >   }
> >   
> > -static inline
> > -int reset_control_array_assert(struct reset_control_array *resets)
> > -{
> > -	return 0;
> > -}
> > -
> > -static inline
> > -int reset_control_array_deassert(struct reset_control_array *resets)
> > -{
> > -	return 0;
> > -}
> > -
> >   static inline struct reset_control_array *
> 
> This has to return just 'struct reset_control *'.
> That should resolve kbuild errors.
>
> Rest looks good to me.
> Reviewed-by: Vivek Gautam <vivek.gautam@codeaurora.org>

Thanks, I had already fixed this locally, prompted by the kbuild test
robot. I'll send a v6. I would like to merge this patch into the first
"reset: Add APIs to manage array of resets" patch, if that's ok with
you.

regards
Philipp

  reply	other threads:[~2017-06-19 12:18 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-01 16:51 [PATCH v5 0/6] reset: APIs to manage a list of resets Philipp Zabel
2017-06-01 16:51 ` [PATCH v5 2/6] reset: Add APIs to manage array " Philipp Zabel
2017-06-01 16:52 ` [PATCH v5 4/6] usb: dwc3: of-simple: Re-order resource handling in remove Philipp Zabel
     [not found] ` <20170601165203.15315-1-p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2017-06-01 16:51   ` [PATCH v5 1/6] reset: use kref for reference counting Philipp Zabel
2017-06-01 16:52   ` [PATCH v5 3/6] reset: hide reset control arrays behind struct reset_control Philipp Zabel
     [not found]     ` <20170601165203.15315-4-p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2017-06-01 23:09       ` kbuild test robot
2017-06-02  0:12       ` kbuild test robot
2017-06-13  6:46     ` Vivek Gautam
2017-06-19 12:18       ` Philipp Zabel [this message]
2017-06-19 13:06         ` Vivek Gautam
2017-06-01 16:52   ` [PATCH v5 5/6] usb: dwc3: of-simple: Add support to get resets for the device Philipp Zabel
2017-06-01 16:52   ` [PATCH v5 6/6] soc/tegra: pmc: Use the new reset APIs to manage reset controllers Philipp Zabel
2017-06-19 12:37     ` Philipp Zabel
2017-06-13  7:05   ` [PATCH v5 0/6] reset: APIs to manage a list of resets Vivek Gautam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1497874713.2993.70.camel@pengutronix.de \
    --to=p.zabel@pengutronix.de \
    --cc=balbi@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jonathanh@nvidia.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=treding@nvidia.com \
    --cc=vivek.gautam@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).