Re: [PATCH 01/11] dt-bindings: crypto: qcom,ice: Require power-domain and iface clk

[Krzysztof Kozlowski <krzk@kernel.org>]

On 23/01/2026 08:11, Harshal Dev wrote:
> Update the inline-crypto engine DT binding to reflect that power-domain and
> clock-names are now mandatory. Also update the maximum number of clocks
> that can be specified to two. These new fields are mandatory because ICE
> needs to vote on the power domain before it attempts to vote on the core
> and iface clocks to avoid clock 'stuck' issues.
> 
> Signed-off-by: Harshal Dev <harshal.dev@oss.qualcomm.com>
> ---
>  .../bindings/crypto/qcom,inline-crypto-engine.yaml         | 14 +++++++++++++-
>  1 file changed, 13 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml
> index c3408dcf5d20..1c2416117d4c 100644
> --- a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml
> +++ b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml
> @@ -28,12 +28,20 @@ properties:
>      maxItems: 1
>  
>    clocks:
> +    maxItems: 2

This is ABI break and your commit msg suggests things were not perfect,
but it is not explicit - was this working or not? How is it that ICE was
never tested?

> +
> +  clock-names:
> +    maxItems: 2

Why "yellowpony" is a correct name? Please look at existing code to see
how this is done.


> +
> +  power-domains:
>      maxItems: 1
>  
>  required:
>    - compatible
>    - reg
>    - clocks
> +  - clock-names
> +  - power-domains

Another ABI break...

Best regards,
Krzysztof