Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: "André Apitzsch" <git@apitzsch.eu>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
	Robert Foss	 <rfoss@kernel.org>,
	Todor Tomov <todor.too@gmail.com>,
	Vladimir Zapolskiy	 <vladimir.zapolskiy@linaro.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	 Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	 Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>
Cc: ~postmarketos/upstreaming@lists.sr.ht,
	phone-devel@vger.kernel.org,  linux-media@vger.kernel.org,
	linux-arm-msm@vger.kernel.org,  devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Vincent Knecht <vincent.knecht@mailoo.org>
Subject: Re: [PATCH 0/4] Add CAMSS support for MSM8939
Date: Tue, 23 Sep 2025 12:27:41 +0200	[thread overview]
Message-ID: <14e75b6ebc3e558d3449f8b4043d31260bfaffc4.camel@apitzsch.eu> (raw)
In-Reply-To: <bfc3838c-b2fe-40c9-a1bf-f5269b48dca9@linaro.org>

Hi,

Am Montag, dem 08.09.2025 um 11:56 +0100 schrieb Bryan O'Donoghue:
> On 07/09/2025 23:04, André Apitzsch via B4 Relay wrote:
> > (This series resumes [1].)
> > 
> > This series adds CAMSS support for MSM8939.  It's mostly identical
> > to
> > MSM8916, except for some clocks and an additional CSI.
> > 
> > To fix black stripes across sensor output, and garbage in CSID TPG
> > output, 2 VFE VBIF register settings are needed.  So the 2nd patch
> > adds
> > helper functions to do just that.
> > 
> > Patch 1: documents qcom,msm8939-camss DT bindings
> > Patch 2: adds helper for VFE VBIF settings
> > Patch 3: adds CAMSS_8x39 version in CAMSS driver
> > Patch 4: adds camss and cci in msm8939.dtsi
> > 
> > Changes compared to [1]:
> > - Move bindings patch to the beginning
> > - Make the order of {reg, clock, interrupt} items the same as in
> > 8916 +
> >    append additional items
> > - Drop R-b tags from bindings and dts patches as order of items was
> >    changed
> > 
> > [1]
> > https://lore.kernel.org/all/20250613-camss-8x39-vbif-v5-0-a002301a7730@mailoo.org/
> > 
> > Signed-off-by: Vincent Knecht <vincent.knecht@mailoo.org>
> > [André: Apply reviewer comments]
> > Signed-off-by: André Apitzsch <git@apitzsch.eu>
> > ---
> > Vincent Knecht (4):
> >        media: dt-bindings: Add qcom,msm8939-camss
> >        media: qcom: camss: vfe: Add VBIF setting support
> >        media: qcom: camss: Add support for MSM8939
> >        arm64: dts: qcom: msm8939: Add camss and cci
> > 
> >   .../bindings/media/qcom,msm8939-camss.yaml         | 254
> > +++++++++++++++++++++
> >   arch/arm64/boot/dts/qcom/msm8939-pm8916.dtsi       |   4 +
> >   arch/arm64/boot/dts/qcom/msm8939.dtsi              | 146
> > ++++++++++++
> >   drivers/media/platform/qcom/camss/Makefile         |   1 +
> >   drivers/media/platform/qcom/camss/camss-csiphy.c   |   1 +
> >   drivers/media/platform/qcom/camss/camss-ispif.c    |   8 +-
> >   drivers/media/platform/qcom/camss/camss-vfe-4-1.c  |  12 +
> >   drivers/media/platform/qcom/camss/camss-vfe-vbif.c |  31 +++
> >   drivers/media/platform/qcom/camss/camss-vfe-vbif.h |  19 ++
> >   drivers/media/platform/qcom/camss/camss-vfe.c      |  10 +
> >   drivers/media/platform/qcom/camss/camss-vfe.h      |   3 +
> >   drivers/media/platform/qcom/camss/camss.c          | 157
> > +++++++++++++
> >   drivers/media/platform/qcom/camss/camss.h          |   1 +
> >   13 files changed, 645 insertions(+), 2 deletions(-)
> > ---
> > base-commit: be5d4872e528796df9d7425f2bd9b3893eb3a42c
> > change-id: 20250517-camss-8x39-vbif-975ff5819198
> > 
> > Best regards,
> 
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>

any chance, this series can be applied for the next merge window?

Best regards,
André

      reply	other threads:[~2025-09-23 10:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-07 22:04 [PATCH 0/4] Add CAMSS support for MSM8939 André Apitzsch via B4 Relay
2025-09-07 22:04 ` [PATCH 1/4] media: dt-bindings: Add qcom,msm8939-camss André Apitzsch via B4 Relay
2025-09-08  8:22   ` Krzysztof Kozlowski
2025-09-07 22:04 ` [PATCH 2/4] media: qcom: camss: vfe: Add VBIF setting support André Apitzsch via B4 Relay
2025-09-07 22:04 ` [PATCH 3/4] media: qcom: camss: Add support for MSM8939 André Apitzsch via B4 Relay
2025-09-07 22:04 ` [PATCH 4/4] arm64: dts: qcom: msm8939: Add camss and cci André Apitzsch via B4 Relay
2025-10-07 13:46   ` Konrad Dybcio
2025-09-08  4:51 ` [PATCH 0/4] Add CAMSS support for MSM8939 Bryan O'Donoghue
2025-09-08  5:44   ` André Apitzsch
2025-09-08 10:56 ` Bryan O'Donoghue
2025-09-23 10:27   ` André Apitzsch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=14e75b6ebc3e558d3449f8b4043d31260bfaffc4.camel@apitzsch.eu \
    --to=git@apitzsch.eu \
    --cc=andersson@kernel.org \
    --cc=bryan.odonoghue@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=phone-devel@vger.kernel.org \
    --cc=rfoss@kernel.org \
    --cc=robh@kernel.org \
    --cc=todor.too@gmail.com \
    --cc=vincent.knecht@mailoo.org \
    --cc=vladimir.zapolskiy@linaro.org \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox