From: Philipp Zabel <p.zabel@pengutronix.de>
To: linux-kernel@vger.kernel.org
Cc: Vivek Gautam <vivek.gautam@codeaurora.org>,
Jon Hunter <jonathanh@nvidia.com>,
Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thierry Reding <treding@nvidia.com>,
linux-tegra@vger.kernel.org, linux-usb@vger.kernel.org,
linux-arm-msm@vger.kernel.org, kernel@pengutronix.de,
Philipp Zabel <p.zabel@pengutronix.de>
Subject: [PATCH v7 3/4] usb: dwc3: of-simple: Add support to get resets for the device
Date: Wed, 19 Jul 2017 17:59:07 +0200 [thread overview]
Message-ID: <1500479948-29988-4-git-send-email-p.zabel@pengutronix.de> (raw)
In-Reply-To: <1500479948-29988-1-git-send-email-p.zabel@pengutronix.de>
From: Vivek Gautam <vivek.gautam@codeaurora.org>
Add support to get a list of resets available for the device.
These resets must be kept de-asserted until the device is
in use.
Cc: Felipe Balbi <balbi@kernel.org>
Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org>
[p.zabel@pengutronix.de: switch to hidden reset control array]
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
No changes since v6.
---
drivers/usb/dwc3/dwc3-of-simple.c | 27 +++++++++++++++++++++++++--
1 file changed, 25 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c
index a9bac09d3750d..23d2221bde9df 100644
--- a/drivers/usb/dwc3/dwc3-of-simple.c
+++ b/drivers/usb/dwc3/dwc3-of-simple.c
@@ -29,11 +29,13 @@
#include <linux/of.h>
#include <linux/of_platform.h>
#include <linux/pm_runtime.h>
+#include <linux/reset.h>
struct dwc3_of_simple {
struct device *dev;
struct clk **clks;
int num_clocks;
+ struct reset_control *resets;
};
static int dwc3_of_simple_clk_init(struct dwc3_of_simple *simple, int count)
@@ -96,9 +98,20 @@ static int dwc3_of_simple_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, simple);
simple->dev = dev;
+ simple->resets = of_reset_control_array_get_optional_exclusive(np);
+ if (IS_ERR(simple->resets)) {
+ ret = PTR_ERR(simple->resets);
+ dev_err(dev, "failed to get device resets, err=%d\n", ret);
+ return ret;
+ }
+
+ ret = reset_control_deassert(simple->resets);
+ if (ret)
+ goto err_resetc_put;
+
ret = dwc3_of_simple_clk_init(simple, of_clk_get_parent_count(np));
if (ret)
- return ret;
+ goto err_resetc_assert;
ret = of_platform_populate(np, NULL, NULL, dev);
if (ret) {
@@ -107,7 +120,7 @@ static int dwc3_of_simple_probe(struct platform_device *pdev)
clk_put(simple->clks[i]);
}
- return ret;
+ goto err_resetc_assert;
}
pm_runtime_set_active(dev);
@@ -115,6 +128,13 @@ static int dwc3_of_simple_probe(struct platform_device *pdev)
pm_runtime_get_sync(dev);
return 0;
+
+err_resetc_assert:
+ reset_control_assert(simple->resets);
+
+err_resetc_put:
+ reset_control_put(simple->resets);
+ return ret;
}
static int dwc3_of_simple_remove(struct platform_device *pdev)
@@ -130,6 +150,9 @@ static int dwc3_of_simple_remove(struct platform_device *pdev)
clk_put(simple->clks[i]);
}
+ reset_control_assert(simple->resets);
+ reset_control_put(simple->resets);
+
pm_runtime_put_sync(dev);
pm_runtime_disable(dev);
--
2.11.0
next prev parent reply other threads:[~2017-07-19 15:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-19 15:59 [PATCH v7 0/4] reset: APIs to manage a list of resets Philipp Zabel
[not found] ` <1500479948-29988-1-git-send-email-p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2017-07-19 15:59 ` [PATCH v7 1/4] reset: Add APIs to manage array " Philipp Zabel
2017-10-19 18:54 ` Bjorn Andersson
2017-10-20 12:20 ` Philipp Zabel
2017-11-01 22:24 ` Bjorn Andersson
2017-11-02 12:57 ` Philipp Zabel
2017-07-19 15:59 ` [PATCH v7 2/4] usb: dwc3: of-simple: Re-order resource handling in remove Philipp Zabel
2017-10-19 9:36 ` Felipe Balbi
2017-07-19 15:59 ` [PATCH v7 4/4] soc/tegra: pmc: Use the new reset APIs to manage reset controllers Philipp Zabel
2017-10-19 15:17 ` Philipp Zabel
[not found] ` <1508426260.7665.24.camel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2017-10-20 15:51 ` Jon Hunter
2017-10-23 9:20 ` Philipp Zabel
2018-03-09 8:09 ` Thierry Reding
2017-07-19 15:59 ` Philipp Zabel [this message]
2017-10-19 9:38 ` [PATCH v7 3/4] usb: dwc3: of-simple: Add support to get resets for the device Felipe Balbi
[not found] ` <87y3o7h3zu.fsf-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-10-19 10:45 ` Philipp Zabel
2017-10-19 11:30 ` Felipe Balbi
[not found] ` <1508409939.7665.7.camel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2017-10-19 11:31 ` Felipe Balbi
[not found] ` <87shefgyqc.fsf-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-10-19 11:47 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1500479948-29988-4-git-send-email-p.zabel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=treding@nvidia.com \
--cc=vivek.gautam@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).