From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 1/3] driver-core: platform: Add platform_irq_count() Date: Thu, 07 Jan 2016 11:32:51 +0100 Message-ID: <15028940.raimA3k85Q@wuerfel> References: <1452129169-2014-1-git-send-email-sboyd@codeaurora.org> <1452129169-2014-2-git-send-email-sboyd@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: Received: from mout.kundenserver.de ([212.227.17.10]:57624 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751403AbcAGKdb (ORCPT ); Thu, 7 Jan 2016 05:33:31 -0500 In-Reply-To: <1452129169-2014-2-git-send-email-sboyd@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: linux-arm-kernel@lists.infradead.org Cc: Stephen Boyd , Linus Walleij , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Greg Kroah-Hartman , Andy Gross On Wednesday 06 January 2016 17:12:47 Stephen Boyd wrote: > A recent patch added calls to of_irq_count() in the qcom pinctrl > drivers and that caused module build failures because > of_irq_count() is not an exported symbol. We shouldn't export > of_irq_count() to modules because it's an internal OF API that > shouldn't be used by drivers. Platform drivers should use > platform device APIs instead. Therefore, add a platform_irq_count() > API that mirrors the of_irq_count() API so that platform drivers > can stay DT agnostic. > > Cc: Rob Herring > Cc: Greg Kroah-Hartman > Cc: Andy Gross > Signed-off-by: Stephen Boyd > Acked-by: Arnd Bergmann I think there are a couple of other drivers that can use this too. Arnd