From: Chris Lew <clew@codeaurora.org>
To: bjorn.andersson@linaro.org, andy.gross@linaro.org,
david.brown@linaro.org
Cc: aneela@codeaurora.org, linux-arm-msm@vger.kernel.org,
linux-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
clew@codeaurora.org
Subject: [PATCH v2 1/5] soc: qcom: smem: Use le32_to_cpu for partition size comparison
Date: Thu, 14 Sep 2017 14:24:58 -0700 [thread overview]
Message-ID: <1505424302-29147-2-git-send-email-clew@codeaurora.org> (raw)
In-Reply-To: <1505424302-29147-1-git-send-email-clew@codeaurora.org>
Endianness can vary in the system, add le32_to_cpu when comparing
size values from smem.
Signed-off-by: Chris Lew <clew@codeaurora.org>
---
Changes since v1:
- New change
drivers/soc/qcom/smem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/qcom/smem.c b/drivers/soc/qcom/smem.c
index c28275be0038..db04c45d4132 100644
--- a/drivers/soc/qcom/smem.c
+++ b/drivers/soc/qcom/smem.c
@@ -698,7 +698,7 @@ static int qcom_smem_enumerate_partitions(struct qcom_smem *smem,
return -EINVAL;
}
- if (header->size != entry->size) {
+ if (le32_to_cpu(header->size) != le32_to_cpu(entry->size)) {
dev_err(smem->dev,
"Partition %d has invalid size\n", i);
return -EINVAL;
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2017-09-14 21:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-14 21:24 [PATCH v2 0/5] Qualcomm SMEM V12 Support Chris Lew
2017-09-14 21:24 ` Chris Lew [this message]
2017-09-15 1:08 ` [PATCH v2 1/5] soc: qcom: smem: Use le32_to_cpu for partition size comparison Bjorn Andersson
2017-09-15 18:33 ` Stephen Boyd
2017-09-15 18:39 ` Stephen Boyd
2017-09-15 20:53 ` Chris Lew
2017-10-05 3:59 ` Bjorn Andersson
2017-09-14 21:24 ` [PATCH v2 2/5] soc: qcom: smem: Read version by using the smem header Chris Lew
2017-09-15 1:09 ` Bjorn Andersson
2017-09-14 21:25 ` [PATCH v2 3/5] soc: qcom: smem: Support global partition Chris Lew
2017-09-15 18:33 ` Bjorn Andersson
2017-09-15 21:02 ` Chris Lew
2017-10-05 4:15 ` Bjorn Andersson
2017-09-14 21:25 ` [PATCH v2 4/5] soc: qcom: smem: Support dynamic item limit Chris Lew
2017-09-15 18:40 ` Bjorn Andersson
2017-09-14 21:25 ` [PATCH v2 5/5] soc: qcom: smem: Increase the number of hosts Chris Lew
2017-09-15 18:40 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1505424302-29147-2-git-send-email-clew@codeaurora.org \
--to=clew@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=aneela@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).