Re: [PATCH v4 14/16] phy: Add USB speed related PHY modes

Manu Gautam
2018-01-08T04:46:06Z

Hi,

On 1/5/2018 4:31 PM, Kishon Vijay Abraham I wrote:
>> +enum phy_mode phy_get_mode(struct phy *phy)
>> +{
>> + enum phy_mode ret;
>> +
>> + if (!phy || !phy->ops->get_mode)
>> + return PHY_MODE_INVALID;
>> +
>> + mutex_lock(&phy->mutex);
>> + ret = phy->ops->get_mode(phy);
> Since get_mode only has to return the phy mode, there is no need for an ops
> here. Just add phy_mode in phy_attrs in set_mode and return it here.

Sure, will re-send patch set with this change.