* [PATCH] wcn36xx: Fix warning due to duplicate scan_completed notification
@ 2018-02-15 11:08 Loic Poulain
0 siblings, 0 replies; only message in thread
From: Loic Poulain @ 2018-02-15 11:08 UTC (permalink / raw)
To: kvalo-sgV2jX0FEOL9JmXXK+q4OQ, k.eugene.e-Re5JQEeQqe8AvxtiuMwx3w
Cc: linux-wireless-u79uwXL29TY76Z2rM5mHXA,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA,
bjorn.andersson-QSEj5FYQhm4dnm+yROfE0A,
nicolas.dechesne-QSEj5FYQhm4dnm+yROfE0A,
wcn36xx-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Loic Poulain
The wcn36xx_cancel_hw_scan method stops the hw scan and notify the
scan completion via ieee80211_scan_completed.
However, on scan offload cancellation, firmware sends a scan complete
indication, triggering a new call to ieee80211_scan_completed.
This leads to kernel warn since the scan has already been completed.
Signed-off-by: Loic Poulain <loic.poulain-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
---
drivers/net/wireless/ath/wcn36xx/main.c | 9 +++------
drivers/net/wireless/ath/wcn36xx/smd.c | 2 ++
2 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c
index ab5be6d..fcc98d4 100644
--- a/drivers/net/wireless/ath/wcn36xx/main.c
+++ b/drivers/net/wireless/ath/wcn36xx/main.c
@@ -666,16 +666,13 @@ static void wcn36xx_cancel_hw_scan(struct ieee80211_hw *hw,
{
struct wcn36xx *wcn = hw->priv;
- if (!wcn36xx_smd_stop_hw_scan(wcn)) {
- struct cfg80211_scan_info scan_info = { .aborted = true };
-
- ieee80211_scan_completed(wcn->hw, &scan_info);
- }
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2018-02-15 11:08 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-15 11:08 [PATCH] wcn36xx: Fix warning due to duplicate scan_completed notification Loic Poulain
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).