linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ulf Hansson <ulf.hansson@linaro.org>
To: "Rafael J . Wysocki" <rjw@rjwysocki.net>,
	Sudeep Holla <sudeep.holla@arm.com>,
	Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	linux-pm@vger.kernel.org
Cc: Kevin Hilman <khilman@kernel.org>,
	Lina Iyer <ilina@codeaurora.org>,
	Lina Iyer <lina.iyer@linaro.org>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Stephen Boyd <sboyd@kernel.org>, Juri Lelli <juri.lelli@arm.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	linux-arm-kernel@lists.infradead.org,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v7 22/26] drivers: firmware: psci: Introduce psci_dt_topology_init()
Date: Thu, 12 Apr 2018 13:14:27 +0200	[thread overview]
Message-ID: <1523531671-27491-23-git-send-email-ulf.hansson@linaro.org> (raw)
In-Reply-To: <1523531671-27491-1-git-send-email-ulf.hansson@linaro.org>

In case the hierarchical layout is used in DT, we want to initialize the
corresponding PM domain topology for the CPUs, by using the generic PM
domain (aka genpd) infrastructure.

At first glance, it may seem feasible to hook into the existing
psci_dt_init() function, although because it's called quite early in the
boot sequence, allocating the dynamic data structure for a genpd doesn't
work.

Therefore, let's export a new init function for PSCI,
psci_dt_topology_init(), which the ARM machine code should call from a
suitable initcall.

Succeeding to initialize the PM domain topology, which means at least one
instance of a genpd becomes created, allows us to continue to enable the
PSCI OS initiated mode for the platform. If everything turns out fine,
let's print a message in log to inform the user about the changed mode.

In case of any failures, we stick to the default PSCI Platform Coordinated
mode. Moreover, in case the kernel started from a kexec call, let's make
sure to explicitly default to this mode during boot, in case the previous
kernel changed the mode.

Cc: Lina Iyer <ilina@codeaurora.org>
Co-developed-by: Lina Iyer <lina.iyer@linaro.org>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
---
 drivers/firmware/psci/psci.c | 38 +++++++++++++++++++++++++++++++++++++-
 include/linux/psci.h         |  2 ++
 2 files changed, 39 insertions(+), 1 deletion(-)

diff --git a/drivers/firmware/psci/psci.c b/drivers/firmware/psci/psci.c
index 463f78c..80c286d 100644
--- a/drivers/firmware/psci/psci.c
+++ b/drivers/firmware/psci/psci.c
@@ -691,9 +691,14 @@ static int __init psci_1_0_init(struct device_node *np)
 	if (err)
 		return err;
 
-	if (psci_has_osi_support())
+	if (psci_has_osi_support()) {
 		pr_info("OSI mode supported.\n");
 
+		/* Make sure we default to PC mode. */
+		invoke_psci_fn(PSCI_1_0_FN_SET_SUSPEND_MODE,
+			       PSCI_1_0_SUSPEND_MODE_PC, 0, 0);
+	}
+
 	return 0;
 }
 
@@ -723,6 +728,37 @@ int __init psci_dt_init(void)
 	return ret;
 }
 
+int __init psci_dt_topology_init(void)
+{
+	struct device_node *np;
+	int ret;
+
+	if (!psci_has_osi_support())
+		return 0;
+
+	np = of_find_matching_node_and_match(NULL, psci_of_match, NULL);
+	if (!np)
+		return -ENODEV;
+
+	/* Initialize the CPU PM domains based on topology described in DT. */
+	ret = psci_dt_init_pm_domains(np);
+	if (ret <= 0)
+		goto out;
+
+	/* Enable OSI mode. */
+	ret = invoke_psci_fn(PSCI_1_0_FN_SET_SUSPEND_MODE,
+			     PSCI_1_0_SUSPEND_MODE_OSI, 0, 0);
+	if (ret) {
+		pr_info("failed to enable OSI mode: %d\n", ret);
+		goto out;
+	}
+
+	pr_info("OSI mode enabled.\n");
+out:
+	of_node_put(np);
+	return ret;
+}
+
 #ifdef CONFIG_ACPI
 /*
  * We use PSCI 0.2+ when ACPI is deployed on ARM64 and it's
diff --git a/include/linux/psci.h b/include/linux/psci.h
index 8b1b3b5..298a044 100644
--- a/include/linux/psci.h
+++ b/include/linux/psci.h
@@ -53,8 +53,10 @@ extern struct psci_operations psci_ops;
 
 #if defined(CONFIG_ARM_PSCI_FW)
 int __init psci_dt_init(void);
+int __init psci_dt_topology_init(void);
 #else
 static inline int psci_dt_init(void) { return 0; }
+static inline int psci_dt_topology_init(void) { return 0; }
 #endif
 
 #if defined(CONFIG_ARM_PSCI_FW) && defined(CONFIG_ACPI)
-- 
2.7.4

  parent reply	other threads:[~2018-04-12 11:14 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-12 11:14 [PATCH v7 00/26] PM / Domains: Support hierarchical CPU arrangement (PSCI/ARM) Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 01/26] PM / Domains: Don't treat zero found compatible idle states as an error Ulf Hansson
2018-04-16 17:33   ` Lina Iyer
2018-04-12 11:14 ` [PATCH v7 02/26] PM / Domains: Deal with multiple states but no governor in genpd Ulf Hansson
2018-04-16 17:34   ` Lina Iyer
2018-04-12 11:14 ` [PATCH v7 03/26] PM / Domains: Add generic data pointer to genpd_power_state struct Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 04/26] PM / Domains: Add support for CPU devices to genpd Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 05/26] PM / Domains: Add helper functions to attach/detach CPUs to/from genpd Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 06/26] timer: Export next wakeup time of a CPU Ulf Hansson
2018-04-13  8:47   ` Rafael J. Wysocki
2018-04-15 12:02     ` Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 07/26] PM / Domains: Add genpd governor for CPUs Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 08/26] PM / Domains: Extend genpd CPU governor to cope with QoS constraints Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 09/26] kernel/cpu_pm: Manage runtime PM in the idle path for CPUs Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 10/26] dt: psci: Update DT bindings to support hierarchical PSCI states Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 11/26] of: base: Add of_get_cpu_state_node() to get idle states for a CPU node Ulf Hansson
2018-04-13 15:05   ` Rob Herring
2018-04-15 11:59     ` Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 12/26] cpuidle: dt: Support hierarchical CPU idle states Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 13/26] drivers: firmware: psci: Move psci to separate directory Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 14/26] MAINTAINERS: Update files for PSCI Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 15/26] drivers: firmware: psci: Split psci_dt_cpu_init_idle() Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 16/26] drivers: firmware: psci: Support hierarchical CPU idle states Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 17/26] drivers: firmware: psci: Simplify error path of psci_dt_init() Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 18/26] drivers: firmware: psci: Announce support for OS initiated suspend mode Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 19/26] drivers: firmware: psci: Prepare to use " Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 20/26] drivers: firmware: psci: Share a few internal PSCI functions Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 21/26] drivers: firmware: psci: Add support for PM domains using genpd Ulf Hansson
2018-04-12 11:14 ` Ulf Hansson [this message]
2018-04-12 11:14 ` [PATCH v7 23/26] drivers: firmware: psci: Try to attach CPU devices to their PM domains Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 24/26] drivers: firmware: psci: Deal with CPU hotplug when using OSI mode Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 25/26] arm64: kernel: Respect the hierarchical CPU topology in DT for PSCI Ulf Hansson
2018-04-12 11:14 ` [PATCH v7 26/26] arm64: dts: Convert to the hierarchical CPU topology layout for MSM8916 Ulf Hansson
2018-05-24  9:16 ` [PATCH v7 00/26] PM / Domains: Support hierarchical CPU arrangement (PSCI/ARM) Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1523531671-27491-23-git-send-email-ulf.hansson@linaro.org \
    --to=ulf.hansson@linaro.org \
    --cc=Lorenzo.Pieralisi@arm.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=geert+renesas@glider.be \
    --cc=ilina@codeaurora.org \
    --cc=juri.lelli@arm.com \
    --cc=khilman@kernel.org \
    --cc=lina.iyer@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=rjw@rjwysocki.net \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=sudeep.holla@arm.com \
    --cc=tglx@linutronix.de \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).