From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13D6EC433EF for ; Tue, 28 Sep 2021 12:32:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E40EC611CA for ; Tue, 28 Sep 2021 12:32:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240566AbhI1Mdm (ORCPT ); Tue, 28 Sep 2021 08:33:42 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:47893 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240526AbhI1Mdl (ORCPT ); Tue, 28 Sep 2021 08:33:41 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1632832322; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=lz0RQ3WTqzUYVr3sYY2bnFpPgLz9uXHvoHlxlgCwPwk=; b=OI13nQ1PUXRZs9ryxQH9iu6QfoXFGwNWnXWVssL4jShrwvYsf6OSOD98kd2MhUoM/kEz27Um MsrkoYeLE/DfRoKDgwj7bEc3j78AH6s6lN4BhUcKZj8iVHF8vOc8MnyotYMPzmhPU4QBKZcJ 8I0iFWUVWK6VR06zjE7XCG5QeC4= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI1MzIzYiIsICJsaW51eC1hcm0tbXNtQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n05.prod.us-west-2.postgun.com with SMTP id 61530b3e47d64efb6d3b6f67 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 28 Sep 2021 12:31:58 GMT Sender: skakit=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id DB764C43616; Tue, 28 Sep 2021 12:31:57 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: skakit) by smtp.codeaurora.org (Postfix) with ESMTPSA id 27A68C4338F; Tue, 28 Sep 2021 12:31:56 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 28 Sep 2021 18:01:56 +0530 From: skakit@codeaurora.org To: Stephen Boyd Cc: Andy Gross , Bjorn Andersson , Rob Herring , Lee Jones , Liam Girdwood , Mark Brown , mka@chromium.org, Das Srinagesh , David Collins , kgunda@codeaurora.org, Subbaraman Narayanamurthy , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] dt-bindings: mfd: pm8008: Add pm8008 regulator node In-Reply-To: References: <1631875538-22473-1-git-send-email-skakit@codeaurora.org> <1631875538-22473-2-git-send-email-skakit@codeaurora.org> Message-ID: <1524de68017cfd6c9de706441496b3e5@codeaurora.org> X-Sender: skakit@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 2021-09-21 01:02, Stephen Boyd wrote: > Quoting Satya Priya (2021-09-17 03:45:35) >> Add pm8008-regulator node and example. >> >> Signed-off-by: Satya Priya >> --- >> .../devicetree/bindings/mfd/qcom,pm8008.yaml | 24 >> ++++++++++++++++++++++ >> 1 file changed, 24 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml >> b/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml >> index ec3138c..de182f8 100644 >> --- a/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml >> +++ b/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml >> @@ -45,6 +45,10 @@ properties: >> const: 0 >> >> patternProperties: >> + "^pm8008[a-z]?-regulator$": > > Shouldn't it be ^pm8008-regulator$ without the a-z optional letter? > Some platforms use 2 PM8008 PMICS, in that case we need suffixing like pm8008i pm8008j etc. So, I mentioned this way. >> + type: object >> + $ref: "../regulator/qcom,pm8008-regulator.yaml#" >> + >> "^gpio@[0-9a-f]+$": >> type: object >>