From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D21C725D915 for ; Mon, 24 Mar 2025 18:10:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742839822; cv=none; b=GPTNm+gnKOAMc9ppQeevyubxwJ0UJVgGM79AWrofXQE6doTz+TveWiktaJRpKrA6SAYYUuZw/77hqA9X6zO5PxikqY0ImdbyGucS+pgCNrjI8ae9pzlJh6XsWRoqZW5VS0sBf1J2U+ck+8CGCNRA5Zzwo8/6JG+X1sWKzSRqVtU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742839822; c=relaxed/simple; bh=TPQAGOfcHLRcPE0gq+D5qlh1MYUZEcj4Jf7qEr2aN2o=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=JKcUSzKAdllh8iXiIqlPyaJPufA2G0p28doXSVln1vssMS1OeLZj5pzLIVmBHMFTluQBcViVpJkjap3B6UpEwi900MM+D4jJ6OhyQi1F1NTFB8rNXEi2QklFxW21avVRiriFHpAghCJ94LbIYfnq8i8Y/yaDn+lLpBD19DhyFw4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=R8I5+fmW; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="R8I5+fmW" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-39141ffa9fcso4112799f8f.0 for ; Mon, 24 Mar 2025 11:10:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1742839819; x=1743444619; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=G6RnDtWvNpOaIVSBxV8j/X1kbaynp04OetAChdyC+3o=; b=R8I5+fmWI1/pLmFoSwm1xhakJkwAIKZws6FBt57lP+3efdMj/UHpTjnQsRCgmxdLCU XHunRcVizoLBDCM9yoFYhWWteztBpb/LoMm+4J2JUk6d6+QGb2vDZLpkKZ8KTyfV9oE3 Oxlp/XwrEtfl5yiE1gpt0guXgcwVTYQL8WEXfnxFSIU7sHoxkUTMWASxgEg2IgtiJlhD /oo5UsJO6ClOJF4hn8wA16wazSfbN805IunnDINsTFywuvReIUGkU4PodtvjU9wSTuvY x0A5+jw8VKu854HwXkTcvM0LWqaHum7J1ToLr8ImjiktxpkXZRoEnyycO/4XXPp2WvC2 5YxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742839819; x=1743444619; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=G6RnDtWvNpOaIVSBxV8j/X1kbaynp04OetAChdyC+3o=; b=eFFpifYz2Jq7c9wCX18bJgqbxiYdYa/MnJRVsL5HjrdRxMSB5ffNVrMOduXWHIue+w OevSwwHOlB/5KHbqG4G/KUUgYj6BjNDYS15aKTZOTdZxkLZQMuzZurp4/XWo0bFJmEDS 0cJ4+tVTPa7z/1QTcy+sWaTKJIJe09yL54CIZ+e5U9RZv/4ZruwdR9KYhm0bgr/pC5HT BxphprHXhwL+qTN7VbwXMxtA6eY1RZYhfZwelFO0L6hW25ApxJ9hpqnFcKFZLIP54P0D Dw3Deolq5X7xOuPlvhm7+uLoixf1HjMgyHAZIRxL3oCORk8iCfKdGbqSD78oZngBlpj9 rbZA== X-Gm-Message-State: AOJu0YzSVX0gdjBJAJq26T8qxvjkio0h8cpAjwMkWC+d5RKqLViwELqd +uhW0d8c7y17dtF/jdrIDmUIku+k9ngH6FOGsqIxH7Iv5jqXpDDtOQJcP/trCI8= X-Gm-Gg: ASbGncvpQo09oonn2YFm5BtEHxdHgiaZp33mI41LgWftadfsddN0r50qD9av5oXGdma XW558AjB+0W+LiUNwUa5wUKtpi0SwR5aq6Wi85kV9jUonRFND2J4y9OfcZ3jDw4vgU6puAiW2Ln Eb6BYiAByCKC9ZDx7zMFOGnNUBdm/K4K9V+6LS1RoXM/h6GpFSHJGTB/PkyiF2N22rBvGA3/iqR CFuPuVO8xa4i4a2QLUPwEvn+s4nwLWvo+Uy3u9MmdsJHKNlCu0JCONvQKC27z4z8qMR8xWSxehB qDGPxL8cKupEZR63azvGFIIpz0KAZtXRJQH7rQqvOp2y+MUmde9Z//deFyUxR3r7ubcnTfM5KfK NJQAdbp5WGyMDSIbx X-Google-Smtp-Source: AGHT+IFQXi6L+IpcN6afMH9c+hEtu1ugnJ/0f83qfJWd2Asbiidts4UoDfjyd3+t8WNtutogARq+Cg== X-Received: by 2002:a05:6000:21c2:b0:399:6d53:68d9 with SMTP id ffacd0b85a97d-3997f939949mr8863871f8f.38.1742839819049; Mon, 24 Mar 2025 11:10:19 -0700 (PDT) Received: from ?IPV6:2a01:e0a:3d9:2080:a356:8d0:d4d:bb5f? ([2a01:e0a:3d9:2080:a356:8d0:d4d:bb5f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3997f9b3ff7sm11435193f8f.48.2025.03.24.11.10.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Mar 2025 11:10:18 -0700 (PDT) Message-ID: <1526d8a4-9606-4fb3-bb86-79bd8eb8a789@linaro.org> Date: Mon, 24 Mar 2025 19:10:17 +0100 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH v2 2/6] phy: qcom-qmp-ufs: Add PHY Configuration support for sm8750 To: Melody Olvera , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam , Alim Akhtar , Avri Altman , Bart Van Assche , Bjorn Andersson , Andy Gross , Konrad Dybcio , Satya Durga Srinivasu Prabhala , Trilok Soni Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Nitin Rawat , Manish Pandey , Linux regressions mailing list References: <20250310-sm8750_ufs_master-v2-0-0dfdd6823161@quicinc.com> <20250310-sm8750_ufs_master-v2-2-0dfdd6823161@quicinc.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20250310-sm8750_ufs_master-v2-2-0dfdd6823161@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 10/03/2025 22:12, Melody Olvera wrote: > From: Nitin Rawat > > Add SM8750 specific register layout and table configs. The serdes > TX RX register offset has changed for SM8750 and hence keep UFS > specific serdes offsets in a dedicated header file. > > Reviewed-by: Neil Armstrong > Co-developed-by: Manish Pandey > Signed-off-by: Manish Pandey > Signed-off-by: Nitin Rawat > --- > drivers/phy/qualcomm/phy-qcom-qmp-qserdes-com-v6.h | 7 + > .../qualcomm/phy-qcom-qmp-qserdes-txrx-ufs-v7.h | 67 ++++++++ > drivers/phy/qualcomm/phy-qcom-qmp-ufs.c | 180 ++++++++++++++++++++- > 3 files changed, 246 insertions(+), 8 deletions(-) > This change breaks UFS on the SM8550-HDK: [ 7.418161] qcom-qmp-ufs-phy 1d80000.phy: phy initialization timed-out [ 7.427021] phy phy-1d80000.phy.0: phy poweron failed --> -110 [ 7.493514] ufshcd-qcom 1d84000.ufshc: Enabling the controller failed ... GIT bisect points to: b02cc9a176793b207e959701af1ec26222093b05 is the first bad commit Author: Nitin Rawat Date: Mon Mar 10 14:12:30 2025 -0700 phy: qcom-qmp-ufs: Add PHY Configuration support for sm8750 bisect log: git bisect start 'ff7f9b199e3f' 'v6.14-rc1' git bisect good 36c18c562846300d4e59f1a65008800b787f4fe4 git bisect good 85cf0293c3a75726e7bc54d3efdc5dc783debc07 git bisect good b2cd73e18cec75f917d14b9188f82a2fdef64ebe git bisect bad b247639d33ad16ea76797268fd0eef08d8027dfd git bisect good 9b3f2dfdad1cc0ab90a0fa371c8cbee08b2446e3 git bisect bad 8dc30c3e4cf8c4e370cf08bd09eb87b0deccd3de git bisect bad 100aeb03a437f30300894091627e4406605ee3cb git bisect bad b2a1a2ae7818c9d8da12bf7b1983c8b9f5fb712b git bisect good 8f831f272b4c89aa13b45bd010c2c18ad97a3f1b git bisect good e45cc62c23428eefbae18a9b4d88d10749741bdd git bisect bad ebf198f17b5ac967db6256f4083bbcbdcc2a3100 git bisect good 12185bc38f7667b1d895b2165a8a47335a4cf31b git bisect bad e46e59b77a9e6f322ef1ad08a8874211f389cf47 git bisect bad b02cc9a176793b207e959701af1ec26222093b05 CI run: https://git.codelinaro.org/linaro/qcomlt/ci/staging/cdba-tester/-/jobs/229880#L1281 #regzbot introduced: b02cc9a17679 Neil