From: Raju P L S S S N <rplsssn@codeaurora.org>
To: andy.gross@linaro.org, david.brown@linaro.org,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org
Cc: rnayak@codeaurora.org, bjorn.andersson@linaro.org,
linux-kernel@vger.kernel.org, sboyd@kernel.org,
evgreen@chromium.org, dianders@chromium.org, mka@chromium.org,
rplsssn@codeaurora.org, ilina@codeaurora.org
Subject: [PATCH v9 10/10] drivers: qcom: rpmh-rsc: allow active requests from wake TCS
Date: Thu, 24 May 2018 16:15:31 +0530 [thread overview]
Message-ID: <1527158731-17685-11-git-send-email-rplsssn@codeaurora.org> (raw)
In-Reply-To: <1527158731-17685-1-git-send-email-rplsssn@codeaurora.org>
From: Lina Iyer <ilina@codeaurora.org>
Some RSCs may only have sleep and wake TCS, i.e, there is no dedicated
TCS for active mode request, but drivers may still want to make active
requests from these RSCs. In such cases re-purpose the wake TCS to send
active state requests.
The requirement for this is that the driver is aware that the wake TCS
is being repurposed to send active request, hence the sleep and wake
TCSes be invalidated before the active request is sent.
Signed-off-by: Lina Iyer <ilina@codeaurora.org>
Signed-off-by: Raju P.L.S.S.S.N <rplsssn@codeaurora.org>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
---
Changes in v9:
- invalidate again if -EAGAIN is returned by rpmh_rsc_invalidate
---
drivers/soc/qcom/rpmh-rsc.c | 23 +++++++++++++++++++++--
1 file changed, 21 insertions(+), 2 deletions(-)
diff --git a/drivers/soc/qcom/rpmh-rsc.c b/drivers/soc/qcom/rpmh-rsc.c
index 4ab7001..83c3a65 100644
--- a/drivers/soc/qcom/rpmh-rsc.c
+++ b/drivers/soc/qcom/rpmh-rsc.c
@@ -151,7 +151,8 @@ int rpmh_rsc_invalidate(struct rsc_drv *drv)
static struct tcs_group *get_tcs_for_msg(struct rsc_drv *drv,
const struct tcs_request *msg)
{
- int type;
+ int type, ret;
+ struct tcs_group *tcs;
switch (msg->state) {
case RPMH_ACTIVE_ONLY_STATE:
@@ -167,7 +168,25 @@ static struct tcs_group *get_tcs_for_msg(struct rsc_drv *drv,
return ERR_PTR(-EINVAL);
}
- return get_tcs_of_type(drv, type);
+ /*
+ * If we are making an active request on a RSC that does not have a
+ * dedicated TCS for active state use, then re-purpose a wake TCS to
+ * send active votes.
+ * NOTE: The driver must be aware that this RSC does not have a
+ * dedicated AMC, and therefore would invalidate the sleep and wake
+ * TCSes before making an active state request.
+ */
+ tcs = get_tcs_of_type(drv, type);
+ if (msg->state == RPMH_ACTIVE_ONLY_STATE && IS_ERR(tcs)) {
+ tcs = get_tcs_of_type(drv, WAKE_TCS);
+ if (!IS_ERR(tcs)) {
+ do {
+ ret = rpmh_rsc_invalidate(drv);
+ } while (ret == -EAGAIN);
+ }
+ }
+
+ return tcs;
}
static const struct tcs_request *get_req_from_tcs(struct rsc_drv *drv,
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,\na Linux Foundation Collaborative Project
prev parent reply other threads:[~2018-05-24 10:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-24 10:45 [PATCH v9 00/10] drivers/qcom: add RPMH communication support Raju P L S S S N
2018-05-24 10:45 ` [PATCH v9 01/10] drivers: qcom: rpmh-rsc: add RPMH controller for QCOM SoCs Raju P L S S S N
2018-05-28 5:32 ` Raju P L S S S N
2018-05-30 21:49 ` Doug Anderson
2018-06-11 17:07 ` Raju P L S S S N
2018-05-24 10:45 ` [PATCH v9 02/10] dt-bindings: introduce RPMH RSC bindings for Qualcomm SoCs Raju P L S S S N
2018-05-24 10:45 ` [PATCH v9 03/10] drivers: qcom: rpmh-rsc: log RPMH requests in FTRACE Raju P L S S S N
2018-05-24 10:45 ` [PATCH v9 04/10] drivers: qcom: rpmh: add RPMH helper functions Raju P L S S S N
2018-05-30 21:49 ` Doug Anderson
2018-06-11 17:11 ` Raju P L S S S N
2018-05-24 10:45 ` [PATCH v9 05/10] drivers: qcom: rpmh-rsc: write sleep/wake requests to TCS Raju P L S S S N
2018-05-24 10:45 ` [PATCH v9 06/10] drivers: qcom: rpmh-rsc: allow invalidation of sleep/wake TCS Raju P L S S S N
2018-05-24 10:45 ` [PATCH v9 07/10] drivers: qcom: rpmh: cache sleep/wake state requests Raju P L S S S N
2018-05-24 10:45 ` [PATCH v9 08/10] drivers: qcom: rpmh: allow requests to be sent asynchronously Raju P L S S S N
2018-05-24 10:45 ` [PATCH v9 09/10] drivers: qcom: rpmh: add support for batch RPMH request Raju P L S S S N
2018-05-30 21:50 ` Doug Anderson
2018-06-11 17:17 ` Raju P L S S S N
2018-05-24 10:45 ` Raju P L S S S N [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1527158731-17685-11-git-send-email-rplsssn@codeaurora.org \
--to=rplsssn@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=dianders@chromium.org \
--cc=evgreen@chromium.org \
--cc=ilina@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mka@chromium.org \
--cc=rnayak@codeaurora.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).