From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78C53C4167B for ; Wed, 14 Dec 2022 18:40:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238843AbiLNSkL (ORCPT ); Wed, 14 Dec 2022 13:40:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53292 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238699AbiLNSkK (ORCPT ); Wed, 14 Dec 2022 13:40:10 -0500 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D30FB13D58 for ; Wed, 14 Dec 2022 10:40:08 -0800 (PST) Received: by mail-lf1-x12a.google.com with SMTP id bp15so11905713lfb.13 for ; Wed, 14 Dec 2022 10:40:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=84PVzy06Jez7WrqpA7scvmaFQfIAuLwwfaDiUooPlFI=; b=gR3RUbdtP2h5rhjbu9ETN1ccQZp6hk7IaSQibahbKZZXwXTSnp2ECnJDrlylJ+3Pss 3v4rTXnsLW1NgvfHGi1LkaSvMo65xG1F1zka65Yiszsmd2AePNGZH1GkKM1OgvbKJ/1t oGmX0Fy5dluJbI+LK9yOhT2hO6h36iaiuPHxXifUHvV71nucTO83hZChn6a71Z6sgeVz SW5u/8R2anqRl+qwBkF44JOBU9ewze/ElC2l5Vu8BXLv7wXLhOqpU0USfBkxVO1O67RZ cKyMrT7oGQ6jCy0oUw+B2UuuoJ753yzWd/JI9P7frzi9p9xwfUY0x7zNAeyulvEFyeDu Ewzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=84PVzy06Jez7WrqpA7scvmaFQfIAuLwwfaDiUooPlFI=; b=u6xczC2Ne0kJWhIWH4E/crX6ovMGCx+upWEhAPEITXrbZuJlldJhdz6Q1elkS7A7mO WOdpmp+XrqNdOju8xd4rJ5fj008Bb5yqeEZpHFEW7NNxYP+z6ote+dp515f69P0fBb2F BSrwVA1ekVQkqph+Wm57VJis+m9OIqSjVLNALiXEr3c13PaQENCTfDS41tBC7g6+K4jt xqANst2HKSLA2DBt+CrwDE5ENtHPwT44sIpOrEM0barWeO/uz1xBrTP8bw7Ibs95YM7N 3t1yKsfGi5M+h/rSGd+fztCxs38ddrRKNqRlJnLA63vYtY5MQGEZX4ZwztLobg/ogxUy i5KA== X-Gm-Message-State: ANoB5pmVqXhA7/R014QXiMykNgt6w9Y8A9svUhfwN1X0zzjJHKwvgSEQ KqnSCLZCzQrRU97BhitqC851Hg== X-Google-Smtp-Source: AA0mqf5huwxvJLpqWw8CtVjdxW1TVZkauT4Q4In5DVwTzyMs2NKw3KRNjJwviMs2hFfphsK4vzn7Pw== X-Received: by 2002:ac2:4f0e:0:b0:4a4:68b9:19e1 with SMTP id k14-20020ac24f0e000000b004a468b919e1mr7586088lfr.9.1671043207234; Wed, 14 Dec 2022 10:40:07 -0800 (PST) Received: from [10.10.15.130] ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id a23-20020a19f817000000b0049465afdd38sm901628lff.108.2022.12.14.10.40.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Dec 2022 10:40:06 -0800 (PST) Message-ID: <154b2e08-25a0-c8b7-1dc8-2d41b8787f05@linaro.org> Date: Wed, 14 Dec 2022 20:40:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [RFC PATCH 0/6] drm/msm: DSC Electric Boogaloo for sm8[12]50 Content-Language: en-GB To: Marijn Suijten , phone-devel@vger.kernel.org, Rob Clark , Abhinav Kumar , Vinod Koul Cc: ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , Sean Paul , David Airlie , Daniel Vetter , Stephen Boyd , Bjorn Andersson , Jessica Zhang , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , Kuogee Hsieh , Jani Nikula , sunliming , Sam Ravnborg , Haowen Bai , Konrad Dybcio , Loic Poulain , Vinod Polimera , Douglas Anderson , Vladimir Lypak , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20221213232207.113607-1-marijn.suijten@somainline.org> From: Dmitry Baryshkov In-Reply-To: <20221213232207.113607-1-marijn.suijten@somainline.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 14/12/2022 01:22, Marijn Suijten wrote: > This preliminary Display Stream Compression support package for > (initially tested on) sm8[12]50 is based on comparing DSC behaviour > between downstream and mainline. Some new callbacks are added (for > binding blocks on active CTLs), logic bugs are corrected, zeroed struct > members are now assigned proper values, and RM allocation and hw block > retrieval now hand out (or not) DSC blocks without causing null-pointer > dereferences. > > Unfortunately it is not yet enough to get rid of completely corrupted > display output on the boards I tested here: > - Sony Xperia 1 (sm8150), 1644x3840 or 1096x2560 pixels; > - Sony Xperia 5II (sm8250), 1080x2520, at 60 or 120Hz; > - (can include more Xperia boards if desired) > > Both devices use the DUALPIPE_DSCMERGE topology downstream: dual LM, PP > and DSC, but only a single INTF/encoder/DSI-link. > > Hopefully this spawns some community/upstream interest to help rootcause > our corruption issues (after we open a drm/msm report on GitLab for more > appropriate tracking). > > The Sony Xperia XZ3 (sdm845) was fully tested and validated with this > series to not cause any regressions (an one of the math fixes now allows > us to change slice_count in the panel driver, which would corrupt > previously). > > Marijn Suijten (6): > drm/msm/dpu1: Implement DSC binding to PP block for CTL V1 > drm/msm/dpu1: Add DSC config for sm8150 and sm8250 > drm/msm/dpu1: Wire up DSC mask for active CTL configuration > drm/msm/dsi: Use DSC slice(s) packet size to compute word count > drm/msm/dsi: Flip greater-than check for slice_count and > slice_per_intf > drm/msm/dpu: Disallow unallocated (DSC) resources to be returned General comment: patches with Fixes ideally should come first. Usually they are picked into -fixes and/or stable kernels. If the Fixes patches are in the middle of the series, one can not be sure that they do not have dependencies on previous patches. If there is one, it should probably be stated clearly to ease work on backporting them. > > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 3 +++ > .../drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 1 + > .../drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 1 + > .../drm/msm/disp/dpu1/dpu_encoder_phys_wb.c | 2 ++ > .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 23 +++++++++++----- > .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 9 +++++++ > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c | 27 +++++++++++++++++++ > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.h | 4 +++ > drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 10 +++++++ > drivers/gpu/drm/msm/dsi/dsi_host.c | 6 ++--- > 10 files changed, 77 insertions(+), 9 deletions(-) > > -- > 2.38.1 > -- With best wishes Dmitry