Re: [PATCH V2 3/3] arm64: dts: sdm845: Add interconnect properties for USB

Matthias Kaehlcke
2019-09-16T22:56:11Z

Hi Chandana.

On Mon, Sep 16, 2019 at 05:11:01PM +0530, Chandana Kishori Chiluveru wrote:
> Populate USB DT node with interconnect properties.

nit: nodes

> Signed-off-by: Chandana Kishori Chiluveru <cchiluve@codeaurora.org>
> ---
> arch/arm64/boot/dts/qcom/sdm845.dtsi | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index fcb9330..1c41922 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -1837,6 +1837,12 @@
>
> resets = <&gcc GCC_USB30_PRIM_BCR>;
>
> + interconnects = <&rsc_hlos MASTER_USB3_0
> + &rsc_hlos SLAVE_EBI1>,

nit: align second line after '<' for better readability (like
'interrupts' or 'clocks' properties):

interconnects = <&rsc_hlos MASTER_USB3_0
&rsc_hlos SLAVE_EBI1>,

same for the other entries.

> + <&rsc_hlos MASTER_APPSS_PROC
> + &rsc_hlos SLAVE_USB3_0>;
> + interconnect-names = "usb-ddr", "apps-usb";
> +
> usb_1_dwc3: dwc3@a600000 {
> compatible = "snps,dwc3";
> reg = <0 0x0a600000 0 0xcd00>;
> @@ -1881,6 +1887,12 @@
>
> resets = <&gcc GCC_USB30_SEC_BCR>;
>
> + interconnects = <&rsc_hlos MASTER_USB3_1
> + &rsc_hlos SLAVE_EBI1>,
> + <&rsc_hlos MASTER_APPSS_PROC
> + &rsc_hlos SLAVE_USB3_1>;
> + interconnect-names = "usb-ddr", "apps-usb";
> +
> usb_2_dwc3: dwc3@a800000 {
> compatible = "snps,dwc3";
> reg = <0 0x0a800000 0 0xcd00>;

Besides the nits:

Reviewed-by: Matthias Kaehlcke <mka@chromium.org>