From: Maulik Shah <mkshah@codeaurora.org>
To: swboyd@chromium.org, mka@chromium.org, evgreen@chromium.org,
bjorn.andersson@linaro.org
Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
agross@kernel.org, dianders@chromium.org, rnayak@codeaurora.org,
ilina@codeaurora.org, lsrao@codeaurora.org,
Maulik Shah <mkshah@codeaurora.org>
Subject: [PATCH v5 1/7] drivers: qcom: rpmh: fix macro to accept NULL argument
Date: Wed, 19 Feb 2020 16:10:04 +0530 [thread overview]
Message-ID: <1582108810-21263-2-git-send-email-mkshah@codeaurora.org> (raw)
In-Reply-To: <1582108810-21263-1-git-send-email-mkshah@codeaurora.org>
Device argument matches with dev variable declared in RPMH message.
Compiler reports error when the argument is NULL since the argument
matches the name of the property. Rename dev argument to device to
fix this.
Signed-off-by: Maulik Shah <mkshah@codeaurora.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
---
drivers/soc/qcom/rpmh.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/soc/qcom/rpmh.c b/drivers/soc/qcom/rpmh.c
index 035091f..3a4579d 100644
--- a/drivers/soc/qcom/rpmh.c
+++ b/drivers/soc/qcom/rpmh.c
@@ -23,7 +23,7 @@
#define RPMH_TIMEOUT_MS msecs_to_jiffies(10000)
-#define DEFINE_RPMH_MSG_ONSTACK(dev, s, q, name) \
+#define DEFINE_RPMH_MSG_ONSTACK(device, s, q, name) \
struct rpmh_request name = { \
.msg = { \
.state = s, \
@@ -33,7 +33,7 @@
}, \
.cmd = { { 0 } }, \
.completion = q, \
- .dev = dev, \
+ .dev = device, \
.needs_free = false, \
}
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2020-02-19 10:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-19 10:40 [PATCH v5 0/7] Add RSC power domain support Maulik Shah
2020-02-19 10:40 ` Maulik Shah [this message]
2020-02-20 19:31 ` [PATCH v5 1/7] drivers: qcom: rpmh: fix macro to accept NULL argument Matthias Kaehlcke
2020-02-21 9:32 ` Maulik Shah
2020-02-19 10:40 ` [PATCH v5 2/7] drivers: qcom: rpmh: remove rpmh_flush export Maulik Shah
2020-02-19 10:40 ` [PATCH v5 3/7] dt-bindings: soc: qcom: Add RSC power domain specifier Maulik Shah
2020-02-19 10:40 ` [PATCH v5 4/7] drivers: qcom: rpmh-rsc: Add RSC power domain support Maulik Shah
2020-02-19 10:40 ` [PATCH v5 5/7] arm64: dts: qcom: sc7180: Add cpuidle low power states Maulik Shah
2020-02-19 10:40 ` [PATCH v5 6/7] soc: qcom: rpmh: Update dirty flag only when data changes Maulik Shah
2020-02-19 10:40 ` [PATCH v5 7/7] soc: qcom: rpmh: Invoke rpmh_flush for dirty caches Maulik Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1582108810-21263-2-git-send-email-mkshah@codeaurora.org \
--to=mkshah@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=dianders@chromium.org \
--cc=evgreen@chromium.org \
--cc=ilina@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lsrao@codeaurora.org \
--cc=mka@chromium.org \
--cc=rnayak@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox