Re: [PATCH v4 4/5] arm64: dts: sdm845: Add OPP tables and power-domains for venus

Stanimir Varbanov
2020-07-23T18:06:54Z

Hi Rajendra,

After applying 2,3 and 4/5 patches on linaro-integration v5.8-rc2 I see
below messages on db845:

qcom-venus aa00000.video-codec: dev_pm_opp_set_rate: failed to find
current OPP for freq 533000097 (-34)

^^^ This one is new.

qcom_rpmh TCS Busy, retrying RPMH message send: addr=0x30000

^^^ and this message is annoying, can we make it pr_debug in rpmh?

On 7/23/20 2:26 PM, Rajendra Nayak wrote:
> Add the OPP tables in order to be able to vote on the performance state of
> a power-domain.
>
> Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
> ---
> arch/arm64/boot/dts/qcom/sdm845.dtsi | 40 ++++++++++++++++++++++++++++++++++--
> 1 file changed, 38 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index e506793..5ca2265 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -3631,8 +3631,10 @@
> interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>;
> power-domains = <&videocc VENUS_GDSC>,
> <&videocc VCODEC0_GDSC>,
> - <&videocc VCODEC1_GDSC>;
> - power-domain-names = "venus", "vcodec0", "vcodec1";
> + <&videocc VCODEC1_GDSC>,
> + <&rpmhpd SDM845_CX>;
> + power-domain-names = "venus", "vcodec0", "vcodec1", "cx";
> + operating-points-v2 = <&venus_opp_table>;
> clocks = <&videocc VIDEO_CC_VENUS_CTL_CORE_CLK>,
> <&videocc VIDEO_CC_VENUS_AHB_CLK>,
> <&videocc VIDEO_CC_VENUS_CTL_AXI_CLK>,
> @@ -3654,6 +3656,40 @@
> video-core1 {
> compatible = "venus-encoder";
> };
> +
> + venus_opp_table: venus-opp-table {
> + compatible = "operating-points-v2";
> +
> + opp-100000000 {
> + opp-hz = /bits/ 64 <100000000>;
> + required-opps = <&rpmhpd_opp_min_svs>;
> + };
> +
> + opp-200000000 {
> + opp-hz = /bits/ 64 <200000000>;
> + required-opps = <&rpmhpd_opp_low_svs>;
> + };
> +
> + opp-320000000 {
> + opp-hz = /bits/ 64 <320000000>;
> + required-opps = <&rpmhpd_opp_svs>;
> + };
> +
> + opp-380000000 {
> + opp-hz = /bits/ 64 <380000000>;
> + required-opps = <&rpmhpd_opp_svs_l1>;
> + };
> +
> + opp-444000000 {
> + opp-hz = /bits/ 64 <444000000>;
> + required-opps = <&rpmhpd_opp_nom>;
> + };
> +
> + opp-533000000 {
> + opp-hz = /bits/ 64 <533000000>;
> + required-opps = <&rpmhpd_opp_turbo>;
> + };
> + };
> };
>
> videocc: clock-controller@ab00000 {
>

--
regards,
Stan