From: patchwork-bot+linux-arm-msm@kernel.org
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] bus: mhi: core: Fix error handling in mhi_register_controller()
Date: Tue, 29 Dec 2020 20:15:35 +0000 [thread overview]
Message-ID: <160927293503.13751.4255690824804324085.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <X8XqbtkPpEKSfFi2@mwanda>
Hello:
This patch was applied to qcom/linux.git (refs/heads/for-next):
On Tue, 1 Dec 2020 10:02:54 +0300 you wrote:
> There are a few problems with the error handling in this function. They
> mostly center around the alloc_ordered_workqueue() allocation.
> 1) If that allocation fails or if the kcalloc() prior to it fails then
> it leads to a NULL dereference when we call
> destroy_workqueue(mhi_cntrl->hiprio_wq).
> 2) The error code is not set.
> 3) The "mhi_cntrl->mhi_cmd" allocation is not freed.
>
> [...]
Here is the summary with links:
- bus: mhi: core: Fix error handling in mhi_register_controller()
https://git.kernel.org/qcom/c/89828f632dec
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2020-12-29 20:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 7:02 [PATCH] bus: mhi: core: Fix error handling in mhi_register_controller() Dan Carpenter
2020-12-01 7:58 ` Loic Poulain
2020-12-01 13:35 ` Manivannan Sadhasivam
2020-12-01 13:37 ` Manivannan Sadhasivam
2020-12-29 20:15 ` patchwork-bot+linux-arm-msm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160927293503.13751.4255690824804324085.git-patchwork-notify@kernel.org \
--to=patchwork-bot+linux-arm-msm@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=linux-arm-msm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).