From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FE63C04EBC for ; Tue, 29 Dec 2020 20:18:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0DB6A21D94 for ; Tue, 29 Dec 2020 20:18:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726589AbgL2USk (ORCPT ); Tue, 29 Dec 2020 15:18:40 -0500 Received: from mail.kernel.org ([198.145.29.99]:60236 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726573AbgL2USh (ORCPT ); Tue, 29 Dec 2020 15:18:37 -0500 Received: by mail.kernel.org (Postfix) with ESMTPS id B25A122DA9; Tue, 29 Dec 2020 20:15:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1609272935; bh=a7AZrjTih0Q8/mhnUjiJIGAP1acRzHBwASahpXJrILg=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=V8ETrMp39CM7h7evViQ0eSIf3ZHYorqVdAuXvCPnjGugPqnIkUqKOWNwsfnvZkP6m PFnQDvszgSHtjgwIHtYDxk6B5huwJDqGLVO72tdJJFWMXsSLQ51mIYWmxe79k5vbCk IoDm57zMYwuWS0fgDhnkOfP8aK5dAMzHGcnoCO3GoUFNjM1DQnk1JGw2O4O/jm/iDN RXBwIw3AnxbODMILj2yJM3zJdS57pzrS8mDT6/qmgW451sluXYcyaYFaTbOoKi+YAX GvufljOahSdlBEOF3/bIX/0Et8W6GVJin//efYPjo7uiaM0gMqExsgdb0IeDx5s0j2 DC4rVct4PPogQ== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] watchdog: qcom: Avoid context switch in restart handler From: patchwork-bot+linux-arm-msm@kernel.org Message-Id: <160927293570.13751.14675429771398484369.git-patchwork-notify@kernel.org> Date: Tue, 29 Dec 2020 20:15:35 +0000 References: <20201207060005.21293-1-manivannan.sadhasivam@linaro.org> In-Reply-To: <20201207060005.21293-1-manivannan.sadhasivam@linaro.org> To: Manivannan Sadhasivam Cc: linux-arm-msm@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hello: This patch was applied to qcom/linux.git (refs/heads/for-next): On Mon, 7 Dec 2020 11:30:05 +0530 you wrote: > The use of msleep() in the restart handler will cause scheduler to > induce a context switch which is not desirable. This generates below > warning on SDX55 when WDT is the only available restart source: > > [ 39.800188] reboot: Restarting system > [ 39.804115] ------------[ cut here ]------------ > [ 39.807855] WARNING: CPU: 0 PID: 678 at kernel/rcu/tree_plugin.h:297 rcu_note_context_switch+0x190/0x764 > [ 39.812538] Modules linked in: > [ 39.821954] CPU: 0 PID: 678 Comm: reboot Not tainted 5.10.0-rc1-00063-g33a9990d1d66-dirty #47 > [ 39.824854] Hardware name: Generic DT based system > [ 39.833470] [] (unwind_backtrace) from [] (show_stack+0x10/0x14) > [ 39.838154] [] (show_stack) from [] (dump_stack+0x8c/0xa0) > [ 39.846049] [] (dump_stack) from [] (__warn+0xd8/0xf0) > [ 39.853058] [] (__warn) from [] (warn_slowpath_fmt+0x64/0xc8) > [ 39.859925] [] (warn_slowpath_fmt) from [] (rcu_note_context_switch+0x190/0x764) > [ 39.867503] [] (rcu_note_context_switch) from [] (__schedule+0x84/0x640) > [ 39.876685] [] (__schedule) from [] (schedule+0x58/0x10c) > [ 39.885095] [] (schedule) from [] (schedule_timeout+0x1e8/0x3d4) > [ 39.892135] [] (schedule_timeout) from [] (msleep+0x2c/0x38) > [ 39.899947] [] (msleep) from [] (qcom_wdt_restart+0xc4/0xcc) > [ 39.907319] [] (qcom_wdt_restart) from [] (watchdog_restart_notifier+0x18/0x28) > [ 39.914715] [] (watchdog_restart_notifier) from [] (atomic_notifier_call_chain+0x60/0x84) > [ 39.923487] [] (atomic_notifier_call_chain) from [] (machine_restart+0x78/0x7c) > [ 39.933551] [] (machine_restart) from [] (__do_sys_reboot+0xdc/0x1e0) > [ 39.942397] [] (__do_sys_reboot) from [] (ret_fast_syscall+0x0/0x54) > [ 39.950721] Exception stack(0xc3e0bfa8 to 0xc3e0bff0) > [ 39.958855] bfa0: 0001221c bed2fe24 fee1dead 28121969 01234567 00000000 > [ 39.963832] bfc0: 0001221c bed2fe24 00000003 00000058 000225e0 00000000 00000000 00000000 > [ 39.971985] bfe0: b6e62560 bed2fc84 00010fd8 b6e62580 > [ 39.980124] ---[ end trace 3f578288bad866e4 ]--- > > [...] Here is the summary with links: - watchdog: qcom: Avoid context switch in restart handler https://git.kernel.org/qcom/c/7948fab26bcc You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html